Skip to content

Commit 770cde9

Browse files
mikewestDevtools-frontend LUCI CQ
authored andcommitted
[SRI Message Signatures] Improve the network panel status.
This CL shifts the text in the network panel's status column from "(blocked:other)" to "(blocked:integrity)", and causes clicks on that column to expose the set of headers sent along with the response. Bug: 381044049 Change-Id: Ifbb493030cf3327cfd6954ba9f9b61a46a7b0648 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397062 Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Danil Somsikov <[email protected]> Auto-Submit: Mike West <[email protected]> Reviewed-by: Danil Somsikov <[email protected]>
1 parent bda3d99 commit 770cde9

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

front_end/panels/network/NetworkDataGridNode.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,10 @@ const UIStrings = {
9999
*@description Reason in Network Data Grid Node of the Network panel
100100
*/
101101
origin: 'origin',
102+
/**
103+
*@description Noun. Shown in a table cell as the reason why a network request failed. "integrity" here refers to the integrity of the network request itself in a cryptographic sense: signature verification might have failed, for instance.
104+
*/
105+
integrity: 'integrity',
102106
/**
103107
*@description Reason in Network Data Grid Node of the Network panel
104108
*/
@@ -1209,6 +1213,10 @@ export class NetworkRequestNode extends NetworkNode {
12091213
displayShowHeadersLink = true;
12101214
reason = i18n.i18n.lockedString('NotSameOriginAfterDefaultedToSameOriginByCoep');
12111215
break;
1216+
case Protocol.Network.BlockedReason.SriMessageSignatureMismatch:
1217+
displayShowHeadersLink = true;
1218+
reason = i18nString(UIStrings.integrity);
1219+
break;
12121220
}
12131221
if (displayShowHeadersLink) {
12141222
this.setTextAndTitleAsLink(

0 commit comments

Comments
 (0)