[cleanup] Remove unused code

Lightning00Blade · Devtools-frontend LUCI CQ · commit 77a381a176d2 · 2025-04-10T10:21:30.000-07:00
This is all the dead code that was unused and simple to remove. Bug: 409278895 Change-Id: I9f0f07440e83d0127ade86e12f447b052770983e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439641 Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org> Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org> Reviewed-by: Alina Varkki <alinavarkki@chromium.org> Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
diff --git a/front_end/panels/application/ApplicationPanelSidebar.ts b/front_end/panels/application/ApplicationPanelSidebar.ts
@@ -1004,10 +1004,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
     this.resourcesSection.revealAndSelectFrame(frame);
   }
 
-  private innerShowView(view: UI.Widget.Widget): void {
-    this.panel.showView(view);
-  }
-
   showPreloadingRuleSetView(revealInfo: PreloadingHelper.PreloadingForward.RuleSetView): void {
     if (this.preloadingSummaryTreeElement) {
       this.preloadingSummaryTreeElement.expandAndRevealRuleSet(revealInfo);
@@ -2170,7 +2166,6 @@ export class ResourcesSection implements SDK.TargetManager.Observer {
 export class FrameTreeElement extends ApplicationPanelTreeElement {
   private section: ResourcesSection;
   private frame: SDK.ResourceTreeModel.ResourceTreeFrame;
-  private frameId: string;
   private readonly categoryElements: Map<string, ExpandableApplicationPanelTreeElement>;
   private readonly treeElementForResource: Map<string, FrameResourceTreeElement>;
   private treeElementForWindow: Map<Protocol.Target.TargetID, FrameWindowTreeElement>;
@@ -2182,7 +2177,6 @@ export class FrameTreeElement extends ApplicationPanelTreeElement {
     super(section.panel, '', false, 'frame');
     this.section = section;
     this.frame = frame;
-    this.frameId = frame.id;
     this.categoryElements = new Map();
     this.treeElementForResource = new Map();
     this.treeElementForWindow = new Map();
@@ -2207,7 +2201,6 @@ export class FrameTreeElement extends ApplicationPanelTreeElement {
     this.setLeadingIcons([icon]);
     this.invalidateChildren();
 
-    this.frameId = frame.id;
     if (this.title !== frame.displayName()) {
       this.title = frame.displayName();
       UI.ARIAUtils.setLabel(this.listItemElement, this.title);
diff --git a/front_end/panels/application/CookieItemsView.ts b/front_end/panels/application/CookieItemsView.ts
@@ -165,7 +165,6 @@ class CookiePreviewWidget extends UI.Widget.VBox {
 export class CookieItemsView extends StorageItemsView {
   private model: SDK.CookieModel.CookieModel;
   private cookieDomain: string;
-  private totalSize: number;
   private cookiesTable: CookieTable.CookiesTable.CookiesTable;
   private readonly splitWidget: UI.SplitWidget.SplitWidget;
   private readonly previewPanel: UI.Widget.VBox;
@@ -185,7 +184,6 @@ export class CookieItemsView extends StorageItemsView {
     this.model = model;
     this.cookieDomain = cookieDomain;
 
-    this.totalSize = 0;
     this.cookiesTable = new CookieTable.CookiesTable.CookiesTable(
         /* renderInline */ false, this.saveCookie.bind(this), this.refreshItems.bind(this),
         this.handleCookieSelected.bind(this), this.deleteCookie.bind(this));
@@ -266,7 +264,6 @@ export class CookieItemsView extends StorageItemsView {
 
   private updateWithCookies(allCookies: SDK.Cookie.Cookie[]): void {
     this.allCookies = allCookies;
-    this.totalSize = allCookies.reduce((size, cookie) => size + cookie.size(), 0);
 
     const parsedURL = Common.ParsedURL.ParsedURL.fromString(this.cookieDomain);
     const host = parsedURL ? parsedURL.host : '';
diff --git a/front_end/panels/application/ServiceWorkersView.ts b/front_end/panels/application/ServiceWorkersView.ts
@@ -492,7 +492,6 @@ export class Section {
   private sourceField: Element;
   private readonly statusField: Element;
   private readonly clientsField: Element;
-  private readonly linkifier: Components.Linkifier.Linkifier;
   private readonly clientInfoCache: Map<string, Protocol.Target.TargetInfo>;
   private readonly throttler: Common.Throttler.Throttler;
   private updateCycleField?: Element;
@@ -552,7 +551,6 @@ export class Section {
     this.createUpdateCycleField();
     this.maybeCreateRouterField();
 
-    this.linkifier = new Components.Linkifier.Linkifier();
     this.clientInfoCache = new Map();
     this.throttler = new Common.Throttler.Throttler(500);
   }
diff --git a/front_end/panels/application/preloading/PreloadingView.ts b/front_end/panels/application/preloading/PreloadingView.ts
@@ -202,7 +202,6 @@ function pageURL(): Platform.DevToolsPath.UrlString {
 export class PreloadingRuleSetView extends UI.Widget.VBox {
   private model: SDK.PreloadingModel.PreloadingModel;
   private focusedRuleSetId: Protocol.Preload.RuleSetId|null = null;
-  private focusedPreloadingAttemptId: SDK.PreloadingModel.PreloadingAttemptId|null = null;
 
   private readonly warningsContainer: HTMLDivElement;
   private readonly warningsView = new PreloadingWarningsView();
diff --git a/front_end/panels/layer_viewer/PaintProfilerView.ts b/front_end/panels/layer_viewer/PaintProfilerView.ts
@@ -495,13 +495,11 @@ export class PaintProfilerCommandLogView extends UI.ThrottledWidget.ThrottledWid
 export class LogTreeElement extends UI.TreeOutline.TreeElement {
   readonly logItem: SDK.PaintProfiler.PaintProfilerLogItem;
   private readonly ownerView: PaintProfilerCommandLogView;
-  private readonly filled: boolean;
 
   constructor(ownerView: PaintProfilerCommandLogView, logItem: SDK.PaintProfiler.PaintProfilerLogItem) {
     super('', Boolean(logItem.params));
     this.logItem = logItem;
     this.ownerView = ownerView;
-    this.filled = false;
   }
 
   override onattach(): void {
diff --git a/front_end/panels/layers/LayerTreeModel.ts b/front_end/panels/layers/LayerTreeModel.ts
@@ -230,7 +230,6 @@ export class AgentLayer implements SDK.LayerTreeBase.Layer {
   private scrollRectsInternal!: Protocol.LayerTree.ScrollRect[];
   private quadInternal!: number[];
   private childrenInternal!: AgentLayer[];
-  private image!: HTMLImageElement|null;
   private parentInternal!: AgentLayer|null;
   private layerPayload!: Protocol.LayerTree.Layer;
   private layerTreeModel: LayerTreeModel;
@@ -378,7 +377,6 @@ export class AgentLayer implements SDK.LayerTreeBase.Layer {
   didPaint(rect: Protocol.DOM.Rect): void {
     this.lastPaintRectInternal = rect;
     this.paintCountInternal = this.paintCount() + 1;
-    this.image = null;
   }
 
   reset(layerPayload: Protocol.LayerTree.Layer): void {
@@ -387,7 +385,6 @@ export class AgentLayer implements SDK.LayerTreeBase.Layer {
     this.parentInternal = null;
     this.paintCountInternal = 0;
     this.layerPayload = layerPayload;
-    this.image = null;
     this.scrollRectsInternal = this.layerPayload.scrollRects || [];
     this.stickyPositionConstraintInternal = this.layerPayload.stickyPositionConstraint ?
         new SDK.LayerTreeBase.StickyPositionConstraint(
diff --git a/front_end/panels/linear_memory_inspector/LinearMemoryInspectorController.test.ts b/front_end/panels/linear_memory_inspector/LinearMemoryInspectorController.test.ts
@@ -12,8 +12,6 @@ const {LinearMemoryInspectorController} = LinearMemoryInspector;
 const {ValueInterpreterDisplayUtils} = LinearMemoryInspectorComponents;
 
 class MockRemoteObject extends SDK.RemoteObject.LocalJSONObject {
-  private objSubtype?: string;
-
   constructor(array: ArrayBuffer) {
     super(array);
   }
diff --git a/front_end/panels/media/PlayerMessagesView.ts b/front_end/panels/media/PlayerMessagesView.ts
@@ -99,7 +99,6 @@ class MessageLevelSelector implements UI.SoftDropDown.Delegate<SelectableLevel>
   private readonly itemMap: Map<number, SelectableLevel>;
   private hiddenLevels: string[];
   private bitFieldValue: MessageLevelBitfield;
-  private readonly savedBitFieldValue: MessageLevelBitfield;
   private readonly defaultTitleInternal: Common.UIString.LocalizedString;
   private readonly customTitle: Common.UIString.LocalizedString;
   private readonly allTitle: Common.UIString.LocalizedString;
@@ -113,7 +112,6 @@ class MessageLevelSelector implements UI.SoftDropDown.Delegate<SelectableLevel>
     this.hiddenLevels = [];
 
     this.bitFieldValue = MessageLevelBitfield.DEFAULT;
-    this.savedBitFieldValue = MessageLevelBitfield.DEFAULT;
 
     this.defaultTitleInternal = i18nString(UIStrings.default);
     this.customTitle = i18nString(UIStrings.custom);
diff --git a/front_end/panels/media/PlayerPropertiesView.ts b/front_end/panels/media/PlayerPropertiesView.ts
@@ -172,7 +172,6 @@ export const enum PlayerPropertyKeys {
 }
 
 export class PropertyRenderer extends UI.Widget.VBox {
-  private readonly title: Platform.UIString.LocalizedString;
   private readonly contents: HTMLElement;
   private value: string|null;
   private pseudoColorProtectionElement: HTMLDivElement|null;
@@ -183,7 +182,6 @@ export class PropertyRenderer extends UI.Widget.VBox {
     const titleElement = this.contentElement.createChild('span', 'media-property-renderer-title');
     this.contents = this.contentElement.createChild('div', 'media-property-renderer-contents');
     UI.UIUtils.createTextChild(titleElement, title);
-    this.title = title;
     this.value = null;
     this.pseudoColorProtectionElement = null;
     this.contentElement.classList.add('media-property-renderer-hidden');
@@ -437,7 +435,6 @@ export class PlayerPropertiesView extends UI.Widget.VBox {
   private readonly mediaElements: PropertyRenderer[];
   private readonly videoDecoderElements: PropertyRenderer[];
   private readonly audioDecoderElements: PropertyRenderer[];
-  private readonly textTrackElements: PropertyRenderer[];
   private readonly attributeMap: Map<string, PropertyRenderer|TrackManager>;
   private readonly videoProperties: AttributesView;
   private readonly videoDecoderProperties: AttributesView;
@@ -457,7 +454,6 @@ export class PlayerPropertiesView extends UI.Widget.VBox {
     this.mediaElements = [];
     this.videoDecoderElements = [];
     this.audioDecoderElements = [];
-    this.textTrackElements = [];
     this.attributeMap = new Map();
 
     this.populateAttributesAndElements();
diff --git a/front_end/panels/media/TickingFlameChart.ts b/front_end/panels/media/TickingFlameChart.ts
@@ -53,7 +53,6 @@ export interface EventProperties {
   duration?: number;
   name: string;
   color?: string;
-  hoverData?: Object|null;
 }
 
 /**
@@ -69,12 +68,11 @@ export class Event {
   title: string;
   private colorInternal: string;
   private fontColorInternal: string;
-  private readonly hoverData: Object;
 
   constructor(
       timelineData: PerfUI.FlameChart.FlameChartTimelineData, eventHandlers: EventHandlers,
       eventProperties: EventProperties|
-      undefined = {color: undefined, duration: undefined, hoverData: {}, level: 0, name: '', startTime: 0}) {
+      undefined = {color: undefined, duration: undefined, level: 0, name: '', startTime: 0}) {
     // These allow the event to privately change it's own data in the timeline.
     this.timelineData = timelineData;
     this.setLive = eventHandlers.setLive;
@@ -100,7 +98,6 @@ export class Event {
     this.title = eventProperties['name'] || '';
     this.colorInternal = eventProperties['color'] || HotColorScheme[0];
     this.fontColorInternal = calculateFontColor(this.colorInternal);
-    this.hoverData = eventProperties['hoverData'] || {};
   }
 
   /**
diff --git a/front_end/panels/network/NetworkDataGridNode.ts b/front_end/panels/network/NetworkDataGridNode.ts
@@ -555,7 +555,6 @@ export const _backgroundColors: {
 };
 
 export class NetworkRequestNode extends NetworkNode {
-  private nameCell: Element|null;
   private initiatorCell: Element|null;
   private requestInternal: SDK.NetworkRequest.NetworkRequest;
   private readonly isNavigationRequestInternal: boolean;
@@ -566,7 +565,6 @@ export class NetworkRequestNode extends NetworkNode {
 
   constructor(parentView: NetworkLogViewInterface, request: SDK.NetworkRequest.NetworkRequest) {
     super(parentView);
-    this.nameCell = null;
     this.initiatorCell = null;
     this.requestInternal = request;
     this.isNavigationRequestInternal = false;
@@ -912,7 +910,6 @@ export class NetworkRequestNode extends NetworkNode {
   }
 
   override createCells(element: Element): void {
-    this.nameCell = null;
     this.initiatorCell = null;
 
     element.classList.toggle('network-warning-row', this.isWarning());
@@ -1086,7 +1083,6 @@ export class NetworkRequestNode extends NetworkNode {
       const leftPadding = this.leftPadding ? this.leftPadding + 'px' : '';
       cell.style.setProperty('padding-left', leftPadding);
       cell.tabIndex = -1;
-      this.nameCell = cell;
       cell.addEventListener('dblclick', this.openInNewTab.bind(this), false);
       cell.addEventListener('mousedown', () => {
         // When the request panel isn't visible yet, firing the RequestActivated event
diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts
@@ -2663,7 +2663,6 @@ export class MoreFiltersDropDownUI extends Common.ObjectWrapper.ObjectWrapper<UI
   private networkShowBlockedCookiesOnlySetting: Common.Settings.Setting<boolean>;
   private networkOnlyBlockedRequestsSetting: Common.Settings.Setting<boolean>;
   private networkOnlyThirdPartySetting: Common.Settings.Setting<boolean>;
-  private contextMenu?: UI.ContextMenu.ContextMenu;
   private activeFiltersCount: HTMLElement;
   private activeFiltersCountAdorner: Adorners.Adorner.Adorner;
 
diff --git a/front_end/panels/network/ResourceWebSocketFrameView.ts b/front_end/panels/network/ResourceWebSocketFrameView.ts
@@ -159,7 +159,6 @@ export class ResourceWebSocketFrameView extends UI.Widget.VBox {
   private readonly filterTextInput: UI.Toolbar.ToolbarInput;
   private filterRegex: RegExp|null;
   private readonly frameEmptyWidget: UI.EmptyWidget.EmptyWidget;
-  private readonly selectedNode: ResourceWebSocketFrameNode|null;
   private currentSelectedNode?: ResourceWebSocketFrameNode|null;
 
   private messageFilterSetting: Common.Settings.Setting<string> =
@@ -246,7 +245,6 @@ export class ResourceWebSocketFrameView extends UI.Widget.VBox {
         i18nString(UIStrings.noMessageSelected), i18nString(UIStrings.selectMessageToBrowseItsContent));
     this.splitWidget.setSidebarWidget(this.frameEmptyWidget);
 
-    this.selectedNode = null;
     if (filter) {
       this.applyFilter(filter);
     }
diff --git a/front_end/panels/sources/NavigatorView.ts b/front_end/panels/sources/NavigatorView.ts
@@ -1232,7 +1232,7 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
     }
   }
 
-  private resetForTest(): void {
+  protected resetForTest(): void {
     this.reset();
     this.workspaceInternal.uiSourceCodes().forEach(this.addUISourceCode.bind(this));
   }
diff --git a/front_end/panels/timeline/TimelinePanel.ts b/front_end/panels/timeline/TimelinePanel.ts
@@ -423,11 +423,6 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
   private fileSelectorElement?: HTMLInputElement;
   private selection: TimelineSelection|null = null;
   private traceLoadStart!: Trace.Types.Timing.Milli|null;
-  private primaryPageTargetPromiseCallback = (_target: SDK.Target.Target): void => {};
-  // Note: this is technically unused, but we need it to define the promiseCallback function above.
-  private primaryPageTargetPromise = new Promise<SDK.Target.Target>(res => {
-    this.primaryPageTargetPromiseCallback = res;
-  });
 
   #traceEngineModel: Trace.TraceModel.Model;
   #sourceMapsResolver: Utils.SourceMapsResolver.SourceMapsResolver|null = null;
@@ -704,15 +699,6 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
           },
         },
     );
-    SDK.TargetManager.TargetManager.instance().observeTargets({
-      targetAdded: (target: SDK.Target.Target) => {
-        if (target !== SDK.TargetManager.TargetManager.instance().primaryPageTarget()) {
-          return;
-        }
-        this.primaryPageTargetPromiseCallback(target);
-      },
-      targetRemoved: (_: SDK.Target.Target) => {},
-    });
   }
 
   /**
@@ -1681,7 +1667,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
         // If we profile all target, but this will cause some bugs like time for the function is calculated wrong,
         // because the profiles will be concated and sorted together, so the total time will be amplified.
         // Multiple targets problem might happen when you inspect multiple node servers on different port at same time,
-        // or when you let DevTools listen to both locolhost:9229 & 127.0.0.1:9229.
+        // or when you let DevTools listen to both localhost:9229 & 127.0.0.1:9229.
         const firstNodeTarget =
             SDK.TargetManager.TargetManager.instance().targets().find(target => target.type() === SDK.Target.Type.NODE);
         if (!firstNodeTarget) {
diff --git a/front_end/ui/legacy/Context.ts b/front_end/ui/legacy/Context.ts
@@ -4,7 +4,6 @@
 
 import * as Common from '../../core/common/common.js';
 import type * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';  // eslint-disable-line @typescript-eslint/no-unused-vars
 
 import type {ContextFlavorListener} from './ContextFlavorListener.js';
 

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,6 @@ const {LinearMemoryInspectorController} = LinearMemoryInspector;`
`12`	`12`	`const {ValueInterpreterDisplayUtils} = LinearMemoryInspectorComponents;`
`13`	`13`
`14`	`14`	`class MockRemoteObject extends SDK.RemoteObject.LocalJSONObject {`
`15`		`- private objSubtype?: string;`
`16`		`-`
`17`	`15`	`constructor(array: ArrayBuffer) {`
`18`	`16`	`super(array);`
`19`	`17`	`}`