RPP: sort process windows before setting them

In the screenshot of the bug below, notice how for one process for a
frame we end up setting its time range to invalid, negative numbers.
This is because we were not sorting the windows first, which is
required. We had an assumption that the timestamps of the trace events
come in time order, but that is clearly not always true, so this CL
updates the code to sort first to ensure we have them ordered correctly
before we then set the bounds for each process.

Bug: 402658800
Change-Id: I1b0a394f98cf4538f81cfa4debada97987655593
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346911
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Nancy Li <[email protected]>
Commit-Queue: Nancy Li <[email protected]>

Author: jackfranklin

front_end/models/trace/handlers/MetaHandler.ts

@@ -333,7 +333,13 @@ export async function finalize(): Promise<void> {
   // each particular renderer started and stopped being the main renderer
   // process.
   for (const [, processWindows] of rendererProcessesByFrameId) {
-    const processWindowValues = [...processWindows.values()].flat();
+    // Sort the windows by time; we cannot assume by default they arrive via
+    // events in time order. Because we set the window bounds per-process based
+    // on the time of the current + next window, we need them sorted in ASC
+    // order.
+    const processWindowValues = [...processWindows.values()].flat().sort((a, b) => {
+      return a.window.min - b.window.min;
+    });
     for (let i = 0; i < processWindowValues.length; i++) {
       const currentWindow = processWindowValues[i];
       const nextWindow = processWindowValues[i + 1];