Skip to content

Commit 798b81f

Browse files
and-oliDevtools-frontend LUCI CQ
authored andcommitted
Do not reset trace data when custom tracks setting changes
When the checkbox for the setting is clicked, we are calling FlameChartDataProvider::reset, which as of [1] resets the trace data. This is not the initially intended behavior as we only want to reset the UI data. To fix this we simply call clearTimelineDataCache instead of reset. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6098009 Fixed: 391039190 Change-Id: I9987f00e6bfc2abfcd3d9c649fdc2f2b52b7f37e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6185442 Reviewed-by: Jack Franklin <[email protected]> Auto-Submit: Andres Olivares <[email protected]> Commit-Queue: Jack Franklin <[email protected]>
1 parent a018174 commit 798b81f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

front_end/panels/timeline/TimelineFlameChartView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -976,7 +976,7 @@ export class TimelineFlameChartView extends Common.ObjectWrapper.eventMixin<Even
976976
extensionDataVisibilityChanged(): void {
977977
this.reset();
978978
this.setupWindowTimes();
979-
this.mainDataProvider.reset();
979+
this.mainDataProvider.clearTimelineDataCache();
980980
this.mainDataProvider.timelineData(true);
981981
this.refreshMainFlameChart();
982982
}

0 commit comments

Comments
 (0)