Commit 798b81f
Do not reset trace data when custom tracks setting changes
When the checkbox for the setting is clicked, we are calling
FlameChartDataProvider::reset, which as of [1] resets the trace data.
This is not the initially intended behavior as we only want to reset the
UI data. To fix this we simply call clearTimelineDataCache instead of
reset.
[1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6098009
Fixed: 391039190
Change-Id: I9987f00e6bfc2abfcd3d9c649fdc2f2b52b7f37e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6185442
Reviewed-by: Jack Franklin <[email protected]>
Auto-Submit: Andres Olivares <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>1 parent a018174 commit 798b81f
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
976 | 976 | | |
977 | 977 | | |
978 | 978 | | |
979 | | - | |
| 979 | + | |
980 | 980 | | |
981 | 981 | | |
982 | 982 | | |
| |||
0 commit comments