Skip to content

Commit 7ac3672

Browse files
nsatragnoDevtools-frontend LUCI CQ
authored andcommitted
Fix adding authenticator with large blob
Adding an authenticator with the large blob option requires a CTAP 2 version of at least 2.1. Patch `77915ee6b` unintentionally removed this attribute. Fixed: 443515811 Change-Id: I69fc1325070d131d59ed43b3e7e16fa20cd35345 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6936712 Auto-Submit: Nina Satragno <[email protected]> Reviewed-by: Adam Raine <[email protected]> Reviewed-by: Connor Clark <[email protected]> Commit-Queue: Nina Satragno <[email protected]>
1 parent 438874a commit 7ac3672

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

front_end/panels/webauthn/WebauthnPane.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ describeWithMockConnection('WebAuthn pane', () => {
9898
const options = addAuthenticator.firstCall.firstArg;
9999
assert.isTrue(options.hasLargeBlob);
100100
assert.isTrue(options.hasResidentKey);
101+
assert.strictEqual(options.ctap2Version, Protocol.WebAuthn.Ctap2Version.Ctap2_1);
101102
});
102103

103104
it('adds an authenticator without the large blob option', async () => {

front_end/panels/webauthn/WebauthnPane.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -562,6 +562,7 @@ export class WebauthnPaneImpl extends UI.Panel.Panel implements
562562
#model?: SDK.WebAuthnModel.WebAuthnModel;
563563
#newAuthenticatorOptions: Protocol.WebAuthn.VirtualAuthenticatorOptions = {
564564
protocol: Protocol.WebAuthn.AuthenticatorProtocol.Ctap2,
565+
ctap2Version: Protocol.WebAuthn.Ctap2Version.Ctap2_1,
565566
transport: Protocol.WebAuthn.AuthenticatorTransport.Usb,
566567
hasResidentKey: false,
567568
hasUserVerification: false,

0 commit comments

Comments
 (0)