Insights: move setting frameId onto Processor

Connor had some nice feedback that we could do this in the processor
rather than require every single Insight to define it.

Bug: 401519930
Change-Id: I9b12a89399343c8e5fa9ae69bd0914baf2cb9269
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6343131
Auto-Submit: Jack Franklin <[email protected]>
Commit-Queue: Nancy Li <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Nancy Li <[email protected]>

Author: jackfranklin

front_end/models/trace/Processor.ts

@@ -441,6 +441,7 @@ export class TraceProcessor extends EventTarget {
       let insightResult;
       try {
         insightResult = insight.generateInsight(parsedTrace, context);
+        insightResult.frameId = context.frameId;
         const navId = context.navigation?.args.data?.navigationId;
         if (navId) {
           insightResult.navigationId = navId;

front_end/models/trace/insights/CLSCulprits.ts

@@ -582,7 +582,6 @@ export function generateInsight(
   }
 
   return finalize({
-    frameId: context.frameId,
     relatedEvents,
     animationFailures,
     shifts: rootCausesByShift,

front_end/models/trace/insights/DOMSize.ts

@@ -165,7 +165,6 @@ export function generateInsight(
   }
 
   return finalize({
-    frameId: context.frameId,
     largeLayoutUpdates,
     largeStyleRecalcs,
     maxDOMStats,

front_end/models/trace/insights/DocumentLatency.ts

@@ -181,13 +181,13 @@ function finalize(partialModel: PartialInsightModel<DocumentLatencyInsightModel>
 export function generateInsight(
     parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): DocumentLatencyInsightModel {
   if (!context.navigation) {
-    return finalize({frameId: context.frameId});
+    return finalize({});
   }
 
   const documentRequest =
       parsedTrace.NetworkRequests.byTime.find(req => req.args.data.requestId === context.navigationId);
   if (!documentRequest) {
-    return finalize({frameId: context.frameId, warnings: [InsightWarning.NO_DOCUMENT_REQUEST]});
+    return finalize({warnings: [InsightWarning.NO_DOCUMENT_REQUEST]});
   }
 
   const serverResponseTime = getServerResponseTime(documentRequest);
@@ -217,7 +217,6 @@ export function generateInsight(
   const usesCompression = uncompressedResponseBytes === 0;
 
   return finalize({
-    frameId: context.frameId,
     relatedEvents: [documentRequest],
     data: {
       serverResponseTime,

front_end/models/trace/insights/DuplicateJavaScript.ts

@@ -65,5 +65,5 @@ export function generateInsight(
   });
 
   const duplication = Extras.ScriptDuplication.computeScriptDuplication({scripts});
-  return finalize({frameId: context.frameId, duplication});
+  return finalize({duplication});
 }

front_end/models/trace/insights/FontDisplay.ts

@@ -100,7 +100,6 @@ export function generateInsight(
   const savings = Math.max(...fonts.map(f => f.wastedTime)) as Types.Timing.Milli;
 
   return finalize({
-    frameId: context.frameId,
     relatedEvents: fonts.map(f => f.request),
     fonts,
     metricSavings: {FCP: savings},

front_end/models/trace/insights/ForcedReflow.ts

@@ -201,7 +201,7 @@ function finalize(partialModel: PartialInsightModel<ForcedReflowInsightModel>):
 }
 
 export function generateInsight(
-    traceParsedData: Handlers.Types.ParsedTrace, context: InsightSetContext): ForcedReflowInsightModel {
+    traceParsedData: Handlers.Types.ParsedTrace, _context: InsightSetContext): ForcedReflowInsightModel {
   const warningsData = traceParsedData.Warnings;
   const entryToNodeMap = traceParsedData.Renderer.entryToNode;
 
@@ -217,7 +217,6 @@ export function generateInsight(
       aggregateForcedReflow(warningsData.perWarning, entryToNodeMap);
 
   return finalize({
-    frameId: context.frameId,
     relatedEvents: topLevelFunctionCallData?.topLevelFunctionCallEvents,
     topLevelFunctionCallData,
     aggregatedBottomUpData,

front_end/models/trace/insights/ImageDelivery.ts

@@ -309,7 +309,6 @@ export function generateInsight(
   });
 
   return finalize({
-    frameId: context.frameId,
     optimizableImages,
     totalByteSavings: optimizableImages.reduce((total, img) => total + img.byteSavings, 0),
     metricSavings: metricSavingsForWastedBytes(wastedBytesByRequestId, context),

front_end/models/trace/insights/InteractionToNextPaint.ts

@@ -80,10 +80,7 @@ export function generateInsight(parsedTrace: Handlers.Types.ParsedTrace, context
 
   if (!interactionEvents.length) {
     // A valid result, when there is no user interaction.
-    return finalize({
-
-      frameId: context.frameId,
-    });
+    return finalize({});
   }
 
   const longestByInteractionId = new Map<number, SyntheticInteractionPair>();
@@ -104,7 +101,6 @@ export function generateInsight(parsedTrace: Handlers.Types.ParsedTrace, context
   const highPercentileIndex = Math.min(9, Math.floor(normalizedInteractionEvents.length / 50));
 
   return finalize({
-    frameId: context.frameId,
     relatedEvents: [normalizedInteractionEvents[0]],
     longestInteractionEvent: normalizedInteractionEvents[0],
     highPercentileInteractionEvent: normalizedInteractionEvents[highPercentileIndex],

front_end/models/trace/insights/LCPDiscovery.ts

@@ -96,10 +96,7 @@ function finalize(partialModel: PartialInsightModel<LCPDiscoveryInsightModel>):
 export function generateInsight(
     parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): LCPDiscoveryInsightModel {
   if (!context.navigation) {
-    return finalize({
-
-      frameId: context.frameId,
-    });
+    return finalize({});
   }
 
   const networkRequests = parsedTrace.NetworkRequests;
@@ -116,17 +113,17 @@ export function generateInsight(
   const metricScore = navMetrics.get(Handlers.ModelHandlers.PageLoadMetrics.MetricName.LCP);
   const lcpEvent = metricScore?.event;
   if (!lcpEvent || !Types.Events.isLargestContentfulPaintCandidate(lcpEvent)) {
-    return finalize({frameId: context.frameId, warnings: [InsightWarning.NO_LCP]});
+    return finalize({warnings: [InsightWarning.NO_LCP]});
   }
 
   const docRequest = networkRequests.byTime.find(req => req.args.data.requestId === context.navigationId);
   if (!docRequest) {
-    return finalize({frameId: context.frameId, lcpEvent, warnings: [InsightWarning.NO_DOCUMENT_REQUEST]});
+    return finalize({warnings: [InsightWarning.NO_DOCUMENT_REQUEST]});
   }
 
   const lcpRequest = parsedTrace.LargestImagePaint.lcpRequestByNavigation.get(context.navigation);
   if (!lcpRequest) {
-    return finalize({frameId: context.frameId, lcpEvent});
+    return finalize({lcpEvent});
   }
 
   const initiatorUrl = lcpRequest.args.data.initiator?.url;
@@ -147,7 +144,6 @@ export function generateInsight(
   const priorityHintFound = imageFetchPriorityHint === 'high';
 
   return finalize({
-    frameId: context.frameId,
     lcpEvent,
     lcpRequest,
     earliestDiscoveryTimeTs: earliestDiscoveryTime ? Types.Timing.Micro(earliestDiscoveryTime) : undefined,