[RPP] Avoid 3P tree expanding on keydown

drive by "Third party" case fix

Bug:393420237
Change-Id: I74b5959904186d39be721087486f6971c180175c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6217307
Reviewed-by: Adam Raine <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Adriana Ixba <[email protected]>

Author: Adriana Ixba

front_end/panels/timeline/ThirdPartyTreeView.ts

@@ -18,7 +18,7 @@ const UIStrings = {
   /**
    *@description Title for the name of either 1st or 3rd Party entities.
    */
-  firstOrThirdPartyName: '1st / 3rd Party',
+  firstOrThirdPartyName: '1st / 3rd party',
   /**
    *@description Title referencing transfer size.
    */
@@ -47,6 +47,11 @@ export class ThirdPartyTreeViewWidget extends TimelineTreeView.TimelineTreeView
     this.element.setAttribute('jslog', `${VisualLogging.pane('third-party-tree').track({hover: true})}`);
     this.init();
     this.dataGrid.markColumnAsSortedBy('self', DataGrid.DataGrid.Order.Descending);
+    /**
+     * By default data grids always expand when arrowing.
+     * For 3P table, we don't use this feature.
+     */
+    this.dataGrid.expandNodesWhenArrowing = false;
   }
 
   override buildTree(): Trace.Extras.TraceTree.Node {
@@ -74,6 +79,13 @@ export class ThirdPartyTreeViewWidget extends TimelineTreeView.TimelineTreeView
         this.groupingFunction());
   }
 
+  /**
+   * Third party tree view doesn't require the select feature, as this expands the node.
+   */
+  override selectProfileNode(): void {
+    return;
+  }
+
   protected groupingFunction(): ((arg0: Trace.Types.Events.Event) => string)|null {
     return this.domainByEvent.bind(this);
   }

front_end/panels/timeline/TimelinePanel.ts

@@ -333,7 +333,7 @@ const UIStrings = {
   /**
    * @description Title for the Dim 3rd Parties checkbox.
    */
-  dimThirdParties: 'Dim 3rd Parties',
+  dimThirdParties: 'Dim 3rd parties',
   /**
    * @description Description for the Dim 3rd Parties checkbox tooltip describing how 3rd parties are classified.
    */

front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -227,7 +227,8 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
 
     this.editing = false;
     this.selectedNode = null;
-    this.expandNodesWhenArrowing = false;
+    /** Currently by default this is true to expand nodes when arrowing with keyboard. */
+    this.expandNodesWhenArrowing = true;
     this.setRootNode(new DataGridNode<T>());
 
     this.setHasSelection(false);
@@ -1174,6 +1175,10 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
         }
       }
     } else if (event.key === 'ArrowRight') {
+      /** We do not want to expand if this setting is disabled. */
+      if (!this.expandNodesWhenArrowing) {
+        return;
+      }
       if (!this.selectedNode.revealed) {
         this.selectedNode.reveal();
         handled = true;