Skip to content

Commit 7eacf7e

Browse files
ergunshDevtools-frontend LUCI CQ
authored andcommitted
[AiAgent] Fix not saving requests resulting in function call for eval
If `#aidaFetch` results in a functionCall, it means the fetch loop is already finished (we directly break afterwards). However, when it yields the function call, the `run` method breaks from the async generator loop causing rest of the `#aidaFetch` method not to run. This CL removes the `break` from `run` method so that the rest of the `#aidaFetch` will continue to run. Bug: none Change-Id: Ife7adf28c944d9dff5844d48a72e0cbac86739f7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6432430 Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]>
1 parent e7c68e8 commit 7eacf7e

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

front_end/models/ai_assistance/agents/AiAgent.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -454,9 +454,6 @@ export abstract class AiAgent<T> {
454454
complete: false,
455455
};
456456
}
457-
if (functionCall) {
458-
break;
459-
}
460457
}
461458
} catch (err) {
462459
debugLog('Error calling the AIDA API', err);

0 commit comments

Comments
 (0)