Skip to content

Commit 7f3a48f

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
Unblock CfT roll
Bug: 396633671 Change-Id: I70c923366a99251d90d931a01c2fc4ce8d20ad5b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6268791 Reviewed-by: Alina Varkki <[email protected]> Commit-Queue: Alina Varkki <[email protected]> Auto-Submit: Nikolay Vitkov <[email protected]> Reviewed-by: Samiya Caur <[email protected]> Commit-Queue: Samiya Caur <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
1 parent 22c2aed commit 7f3a48f

File tree

2 files changed

+29
-23
lines changed

2 files changed

+29
-23
lines changed

test/e2e/host/user-metrics_test.ts

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -534,17 +534,20 @@ describe('User Metrics for Issue Panel', () => {
534534
]);
535535
});
536536

537-
it('dispatches an event when a SelectElementAccessibility DisallowedOptGroupChild issue is created', async () => {
538-
await goToResource('issues/select-element-accessibility-issue-DisallowedOptGroupChild.html');
539-
await waitFor('.issue');
540-
541-
await assertHistogramEventsInclude([
542-
{
543-
actionName: 'DevTools.IssueCreated',
544-
actionCode: 87, // SelectElementAccessibilityIssue::DisallowedOptGroupChild
545-
},
546-
]);
547-
});
537+
// crbug.com/396633671 failing with latest Cft roll
538+
it.skip(
539+
'[crbug.com/396633671] dispatches an event when a SelectElementAccessibility DisallowedOptGroupChild issue is created',
540+
async () => {
541+
await goToResource('issues/select-element-accessibility-issue-DisallowedOptGroupChild.html');
542+
await waitFor('.issue');
543+
544+
await assertHistogramEventsInclude([
545+
{
546+
actionName: 'DevTools.IssueCreated',
547+
actionCode: 87, // SelectElementAccessibilityIssue::DisallowedOptGroupChild
548+
},
549+
]);
550+
});
548551

549552
it('dispatches an event when a SelectElementAccessibility NonPhrasingContentOptionChild issue is created',
550553
async () => {

test/e2e/issues/select-element-accessibility-issues_test.ts

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,22 @@ describe('Select element accessibility issues test', () => {
2626
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
2727
});
2828

29-
it('should display issue when there is a disallowed child of an optgroup element', async () => {
30-
await goToResource('issues/select-element-accessibility-issue-DisallowedOptGroupChild.html');
31-
await navigateToIssuesTab();
32-
const issueElement = await getAndExpandSpecificIssueByTitle('Invalid element or text node within <optgroup>');
33-
assertNotNullOrUndefined(issueElement);
29+
// crbug.com/396633671 failing with latest Cft roll
30+
it.skip(
31+
'[crbug.com/396633671] should display issue when there is a disallowed child of an optgroup element',
32+
async () => {
33+
await goToResource('issues/select-element-accessibility-issue-DisallowedOptGroupChild.html');
34+
await navigateToIssuesTab();
35+
const issueElement = await getAndExpandSpecificIssueByTitle('Invalid element or text node within <optgroup>');
36+
assertNotNullOrUndefined(issueElement);
3437

35-
const section = await getResourcesElement('1 element', issueElement);
36-
await ensureResourceSectionIsExpanded(section);
37-
const expectedTableRows = [
38-
['Disallowed descendant'],
39-
];
40-
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
41-
});
38+
const section = await getResourcesElement('1 element', issueElement);
39+
await ensureResourceSectionIsExpanded(section);
40+
const expectedTableRows = [
41+
['Disallowed descendant'],
42+
];
43+
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
44+
});
4245

4346
it('should display issue when there is a non-phrasing child element of an option element', async () => {
4447
await goToResource('issues/select-element-accessibility-issue-NonPhrasingContentOptionChild.html');

0 commit comments

Comments
 (0)