[Patch agent] Handle automatic workspaces in select workspace dialog

Show automatic workspace folder in SelectWorkspaceDialog and enable
connecting to it.

Screencast: https://i.imgur.com/GNBp3oY.mp4

Bug: 399560823
Change-Id: If81564dd1b294b89b04f8c505f3e271117ed909a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382152
Commit-Queue: Wolfgang Beyer <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>

Author: wolfib

front_end/models/workspace/WorkspaceImpl.ts

@@ -293,6 +293,11 @@ export class WorkspaceImpl extends Common.ObjectWrapper.ObjectWrapper<EventTypes
     return this.projectsInternal.get(projectId) || null;
   }
 
+  projectForFileSystemRoot(root: Platform.DevToolsPath.RawPathString): Project|null {
+    const projectId = Common.ParsedURL.ParsedURL.rawPathToUrlString(root);
+    return this.project(projectId);
+  }
+
   projects(): Project[] {
     return [...this.projectsInternal.values()];
   }

front_end/panels/ai_assistance/PatchWidget.test.ts

@@ -17,6 +17,7 @@ import {
   MockAidaAbortError,
   mockAidaClient,
   MockAidaFetchError,
+  setupAutomaticFileSystem,
 } from '../../testing/AiAssistanceHelpers.js';
 import {updateHostConfig} from '../../testing/EnvironmentHelpers.js';
 import {describeWithMockConnection} from '../../testing/MockConnection.js';
@@ -30,6 +31,7 @@ describeWithMockConnection('PatchWidget', () => {
     showFreDialogStub = sinon.stub(PanelCommon.FreDialog, 'show');
 
     initializePersistenceImplForTests();
+    setupAutomaticFileSystem();
   });
 
   afterEach(() => {
@@ -265,6 +267,7 @@ Files:
 
       // Simulate clicking the "Change" button
       assert.isTrue(showSelectWorkspaceDialogStub.notCalled);
+      assert.isDefined(view.input.onChangeWorkspaceClick);
       view.input.onChangeWorkspaceClick();
       assert.isTrue(showSelectWorkspaceDialogStub.calledOnce);
 

front_end/panels/ai_assistance/PatchWidget.ts

@@ -14,6 +14,7 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 import * as AiAssistanceModel from '../../models/ai_assistance/ai_assistance.js';
+import * as Persistence from '../../models/persistence/persistence.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as WorkspaceDiff from '../../models/workspace_diff/workspace_diff.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
@@ -159,7 +160,7 @@ export interface ViewInput {
   onCancel: () => void;
   onDiscard: () => void;
   onSaveAll: () => void;
-  onChangeWorkspaceClick: () => void;
+  onChangeWorkspaceClick?: () => void;
 }
 
 export interface ViewOutput {
@@ -188,6 +189,8 @@ export class PatchWidget extends UI.Widget.Widget {
   #patchSuggestionState = PatchSuggestionState.INITIAL;
   #workspaceDiff = WorkspaceDiff.WorkspaceDiff.workspaceDiff();
   #workspace = Workspace.Workspace.WorkspaceImpl.instance();
+  #automaticFileSystem =
+      Persistence.AutomaticFileSystemManager.AutomaticFileSystemManager.instance().automaticFileSystem;
 
   constructor(element?: HTMLElement, view?: View, opts?: {
     aidaClient: Host.AidaClient.AidaClient,
@@ -324,13 +327,15 @@ export class PatchWidget extends UI.Widget.Widget {
               <div class="selected-folder">
                 <devtools-icon .name=${'folder'}></devtools-icon> <span class="folder-name" title=${input.projectPath}>${input.projectName}</span>
               </div>
-              <devtools-button
-                @click=${input.onChangeWorkspaceClick}
-                .jslogContext=${'change-workspace'}
-                .variant=${Buttons.Button.Variant.TEXT}
-                .title=${lockedString(UIStringsNotTranslate.changeRootFolder)}
-                ${Directives.ref(output.changeRef)}
-              >${lockedString(UIStringsNotTranslate.change)}</devtools-button>
+              ${input.onChangeWorkspaceClick ? html`
+                <devtools-button
+                  @click=${input.onChangeWorkspaceClick}
+                  .jslogContext=${'change-workspace'}
+                  .variant=${Buttons.Button.Variant.TEXT}
+                  .title=${lockedString(UIStringsNotTranslate.changeRootFolder)}
+                  ${Directives.ref(output.changeRef)}
+                >${lockedString(UIStringsNotTranslate.change)}</devtools-button>
+              ` : nothing}
             </div>
           ` : nothing}
           <div class="apply-to-workspace-container">
@@ -412,6 +417,15 @@ export class PatchWidget extends UI.Widget.Widget {
         Common.ParsedURL.ParsedURL.urlToRawPathString(
             this.#project.id() as Platform.DevToolsPath.UrlString, Host.Platform.isWin()) :
         Platform.DevToolsPath.EmptyRawPathString;
+    const automaticFileSystemProject =
+        this.#automaticFileSystem ? this.#workspace.projectForFileSystemRoot(this.#automaticFileSystem.root) : null;
+    const projects = this.#workspace.projectsForType(Workspace.Workspace.projectTypes.FileSystem)
+                         .filter(
+                             project => project instanceof Persistence.FileSystemWorkspaceBinding.FileSystem &&
+                                 project.fileSystem().type() ===
+                                     Persistence.PlatformFileSystem.PlatformFileSystemType.WORKSPACE_PROJECT);
+    const showChangeButton = projects.length > 1 || this.#project !== automaticFileSystemProject;
+
     this.#view(
         {
           workspaceDiff: this.#workspaceDiff,
@@ -431,7 +445,8 @@ export class PatchWidget extends UI.Widget.Widget {
           },
           onDiscard: this.#onDiscard.bind(this),
           onSaveAll: this.#onSaveAll.bind(this),
-          onChangeWorkspaceClick: this.#showSelectWorkspaceDialog.bind(this, {applyPatch: false}),
+          onChangeWorkspaceClick: showChangeButton ? this.#showSelectWorkspaceDialog.bind(this, {applyPatch: false}) :
+                                                     undefined,
         },
         this.#viewOutput, this.contentElement);
   }
@@ -499,7 +514,9 @@ export class PatchWidget extends UI.Widget.Widget {
   }
 
   #selectDefaultProject(): void {
-    const project = this.#workspace.project(this.#projectIdSetting.get());
+    const automaticFileSystemProject =
+        this.#automaticFileSystem ? this.#workspace.projectForFileSystemRoot(this.#automaticFileSystem.root) : null;
+    const project = automaticFileSystemProject || this.#workspace.project(this.#projectIdSetting.get());
     if (project) {
       this.#project = project;
     } else {

front_end/panels/ai_assistance/SelectWorkspaceDialog.test.ts

@@ -4,7 +4,7 @@
 
 import * as Persistence from '../../models/persistence/persistence.js';
 import * as Workspace from '../../models/workspace/workspace.js';
-import {createTestFilesystem} from '../../testing/AiAssistanceHelpers.js';
+import {createTestFilesystem, setupAutomaticFileSystem} from '../../testing/AiAssistanceHelpers.js';
 import {dispatchKeyDownEvent, renderElementIntoDOM} from '../../testing/DOMHelpers.js';
 import {describeWithEnvironment} from '../../testing/EnvironmentHelpers.js';
 import {createViewFunctionStub, type ViewFunctionStub} from '../../testing/ViewFunctionHelpers.js';
@@ -13,11 +13,18 @@ import * as UI from '../../ui/legacy/legacy.js';
 import * as AiAssistance from './ai_assistance.js';
 
 describeWithEnvironment('SelectWorkspaceDialog', () => {
+  const root = '/path/to/my-automatic-file-system';
+
+  beforeEach(() => {
+    setupAutomaticFileSystem();
+  });
+
   afterEach(() => {
     const workspace = Workspace.Workspace.WorkspaceImpl.instance();
     for (const project of workspace.projects()) {
       workspace.removeProject(project);
     }
+    Persistence.AutomaticFileSystemManager.AutomaticFileSystemManager.removeInstance();
   });
 
   function createComponent(): {
@@ -87,7 +94,7 @@ describeWithEnvironment('SelectWorkspaceDialog', () => {
         sinon.spy(Persistence.IsolatedFileSystemManager.IsolatedFileSystemManager.instance(), 'addFileSystem');
     const {view} = createComponent();
     assert.strictEqual(view.callCount, 1);
-    assert.lengthOf(view.input.projects, 2);
+    assert.lengthOf(view.input.folders, 2);
     assert.strictEqual(view.input.selectedIndex, 0);
 
     view.input.onAddFolderButtonClick();
@@ -96,8 +103,8 @@ describeWithEnvironment('SelectWorkspaceDialog', () => {
     createTestFilesystem('file://test3');
     const input = await view.nextInput;
     assert.strictEqual(view.callCount, 2);
-    assert.lengthOf(input.projects, 3);
-    assert.strictEqual(input.projects[2].name, 'test3');
+    assert.lengthOf(input.folders, 3);
+    assert.strictEqual(input.folders[2].name, 'test3');
     assert.strictEqual(input.selectedIndex, 2);
   });
 
@@ -109,15 +116,32 @@ describeWithEnvironment('SelectWorkspaceDialog', () => {
     view.input.onProjectSelected(1);
     let input = await view.nextInput;
     assert.strictEqual(view.callCount, 2);
-    assert.lengthOf(input.projects, 2);
+    assert.lengthOf(input.folders, 2);
     assert.strictEqual(input.selectedIndex, 1);
 
     input.onAddFolderButtonClick();
     assert.isTrue(addProjectSpy.calledOnce);
 
     Workspace.Workspace.WorkspaceImpl.instance().removeProject(project);
     input = await view.nextInput;
-    assert.lengthOf(input.projects, 1);
+    assert.lengthOf(input.folders, 1);
     assert.strictEqual(input.selectedIndex, 0);
   });
+
+  it('allows selecting an automatic workspace', async () => {
+    setupAutomaticFileSystem({hasFileSystem: true});
+    const {view, onProjectSelected, hideDialogSpy} = createComponent();
+
+    assert.strictEqual(view.callCount, 1);
+    assert.lengthOf(view.input.folders, 3);
+    assert.strictEqual(view.input.selectedIndex, 0);
+    assert.strictEqual(view.input.folders[0].name, 'my-automatic-file-system');
+
+    view.input.onSelectButtonClick();
+    await new Promise(resolve => setTimeout(resolve, 0));
+    const {project: automaticFileSystemProject} = createTestFilesystem(`file://${root}`);
+
+    assert.isTrue(onProjectSelected.calledOnceWith(automaticFileSystemProject));
+    assert.isTrue(hideDialogSpy.calledOnce);
+  });
 });