[AI] Add new Performance agent behind experiment

Adds a new conversation type for the new Performance agent, and a button
to access it in the Performance panel toolbar (behind an experiment).

This CL implements most of the planned "high-level" data as facts, and a
few of the planned agent functions. More to come.

The only impact on existing behavior should be no longer repeating the
context as a "context" ResponseType on every user message (which seemed
unintentional).

Bypass-Check-License: the presubmit check is wrong
Bug: 425270067
Change-Id: I4002688b5a202f674c05c4f30f6fc89b296e3aa8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6819863
Reviewed-by: Jack Franklin <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
Commit-Queue: Connor Clark <[email protected]>

Author: Connor Clark

config/gni/devtools_grd_files.gni

@@ -1016,6 +1016,7 @@ grd_files_unbundled_sources = [
   "front_end/models/ai_assistance/data_formatters/FileFormatter.js",
   "front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.js",
   "front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.js",
+  "front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.js",
   "front_end/models/ai_assistance/debug.js",
   "front_end/models/ai_assistance/injected.js",
   "front_end/models/ai_code_completion/AiCodeCompletion.js",

front_end/core/host/AidaClient.ts

@@ -113,6 +113,7 @@ export enum FunctionalityType {
   AGENTIC_CHAT = 5,
 }
 
+// See: cs/aida.proto (google3).
 export enum ClientFeature {
   // Unspecified client feature.
   CLIENT_FEATURE_UNSPECIFIED = 0,
@@ -132,6 +133,8 @@ export enum ClientFeature {
   CHROME_PATCH_AGENT = 12,
   // Chrome AI Assistance Performance Insights Agent.
   CHROME_PERFORMANCE_INSIGHTS_AGENT = 13,
+  // Chrome AI Assistance Performance Agent.
+  CHROME_PERFORMANCE_FULL_AGENT = 24,
 }
 
 export enum UserTier {

front_end/core/host/UserMetrics.ts

@@ -526,7 +526,7 @@ export enum Action {
   AiAssistanceOpenedFromNetworkPanel = 170,
   AiAssistanceOpenedFromSourcesPanel = 171,
   AiAssistanceOpenedFromSourcesPanelFloatingButton = 172,
-  AiAssistanceOpenedFromPerformancePanel = 173,
+  AiAssistanceOpenedFromPerformancePanelCallTree = 173,
   AiAssistanceOpenedFromNetworkPanelFloatingButton = 174,
   AiAssistancePanelOpened = 175,
   AiAssistanceQuerySubmitted = 176,
@@ -536,7 +536,8 @@ export enum Action {
   AiAssistanceSideEffectRejected = 180,
   AiAssistanceError = 181,
   AiAssistanceOpenedFromPerformanceInsight = 182,
-  MAX_VALUE = 183,
+  AiAssistanceOpenedFromPerformanceFullButton = 183,
+  MAX_VALUE = 184,
   /* eslint-enable @typescript-eslint/naming-convention */
 }
 
@@ -824,14 +825,15 @@ export enum DevtoolsExperiments {
   'use-source-map-scopes' = 76,
   'timeline-show-postmessage-events' = 86,
   'timeline-save-as-gz' = 108,
+  'timeline-ask-ai-full-button' = 109,
   'timeline-enhanced-traces' = 90,
   'timeline-compiled-sources' = 91,
   'timeline-debug-mode' = 93,
   'vertical-drawer' = 107,
   /* eslint-enable @typescript-eslint/naming-convention */
 
   // Increment this when new experiments are added.
-  MAX_VALUE = 109,
+  MAX_VALUE = 110,
 }
 
 // Update DevToolsIssuesPanelIssueExpanded from tools/metrics/histograms/enums.xml if new enum is added.

front_end/core/root/Runtime.ts

@@ -323,6 +323,7 @@ export const enum ExperimentName {
   TIMELINE_DEBUG_MODE = 'timeline-debug-mode',
   TIMELINE_ENHANCED_TRACES = 'timeline-enhanced-traces',
   TIMELINE_COMPILED_SOURCES = 'timeline-compiled-sources',
+  TIMELINE_ASK_AI_FULL_BUTTON = 'timeline-ask-ai-full-button',
   TIMELINE_SAVE_AS_GZ = 'timeline-save-as-gz',
   VERTICAL_DRAWER = 'vertical-drawer',
   // Adding or removing an entry from this enum?

front_end/entrypoints/main/MainImpl.ts

@@ -361,6 +361,9 @@ export class MainImpl {
     );
     Root.Runtime.experiments.register(
         Root.Runtime.ExperimentName.TIMELINE_SAVE_AS_GZ, 'Performance panel: enable saving traces as .gz');
+    Root.Runtime.experiments.register(
+        Root.Runtime.ExperimentName.TIMELINE_ASK_AI_FULL_BUTTON,
+        'Performance panel: enable new, more powerful Ask AI in trace view');
 
     Root.Runtime.experiments.enableExperimentsByDefault([
       Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE,

front_end/models/ai_assistance/AiHistoryStorage.ts

@@ -13,8 +13,9 @@ export const enum ConversationType {
   STYLING = 'freestyler',
   FILE = 'drjones-file',
   NETWORK = 'drjones-network-request',
-  PERFORMANCE = 'drjones-performance',
+  PERFORMANCE_CALL_TREE = 'drjones-performance',
   PERFORMANCE_INSIGHT = 'performance-insight',
+  PERFORMANCE_FULL = 'drjones-performance-full',
 }
 
 export const NOT_FOUND_IMAGE_DATA = '';

front_end/models/ai_assistance/BUILD.gn

@@ -26,6 +26,7 @@ devtools_module("ai_assistance") {
     "data_formatters/FileFormatter.ts",
     "data_formatters/NetworkRequestFormatter.ts",
     "data_formatters/PerformanceInsightFormatter.ts",
+    "data_formatters/PerformanceTraceFormatter.ts",
     "debug.ts",
     "injected.ts",
   ]
@@ -86,6 +87,7 @@ ts_library("unittests") {
     "data_formatters/FileFormatter.test.ts",
     "data_formatters/NetworkRequestFormatter.test.ts",
     "data_formatters/PerformanceInsightFormatter.test.ts",
+    "data_formatters/PerformanceTraceFormatter.test.ts",
   ]
 
   deps = [
@@ -102,5 +104,8 @@ ts_library("unittests") {
 }
 
 copy_to_gen("snapshots") {
-  sources = [ "data_formatters/PerformanceInsightFormatter.snapshot.txt" ]
+  sources = [
+    "data_formatters/PerformanceInsightFormatter.snapshot.txt",
+    "data_formatters/PerformanceTraceFormatter.snapshot.txt",
+  ]
 }

front_end/models/ai_assistance/ConversationHandler.ts

@@ -343,8 +343,9 @@ export class ConversationHandler {
         agent = new FileAgent(options);
         break;
       }
+      case ConversationType.PERFORMANCE_FULL:
       case ConversationType.PERFORMANCE_INSIGHT:
-      case ConversationType.PERFORMANCE: {
+      case ConversationType.PERFORMANCE_CALL_TREE: {
         agent = new PerformanceAgent(options, conversationType);
         break;
       }

front_end/models/ai_assistance/agents/PerformanceAgent.test.ts

@@ -48,7 +48,7 @@ describeWithEnvironment('PerformanceAgent', () => {
           {
             aidaClient: {} as Host.AidaClient.AidaClient,
           },
-          ConversationType.PERFORMANCE);
+          ConversationType.PERFORMANCE_CALL_TREE);
       assert.strictEqual(
           agent.buildRequest({text: 'test input'}, Host.AidaClient.Role.USER).options?.model_id,
           'test model',
@@ -61,7 +61,7 @@ describeWithEnvironment('PerformanceAgent', () => {
           {
             aidaClient: {} as Host.AidaClient.AidaClient,
           },
-          ConversationType.PERFORMANCE);
+          ConversationType.PERFORMANCE_CALL_TREE);
       assert.strictEqual(
           agent.buildRequest({text: 'test input'}, Host.AidaClient.Role.USER).options?.temperature,
           1,
@@ -76,7 +76,7 @@ describeWithEnvironment('PerformanceAgent', () => {
             aidaClient: mockAidaClient([[{explanation: 'answer'}]]),
             serverSideLoggingEnabled: true,
           },
-          ConversationType.PERFORMANCE);
+          ConversationType.PERFORMANCE_CALL_TREE);
 
       await Array.fromAsync(agent.run('question', {selected: null}));
       setUserAgentForTesting();
@@ -168,7 +168,7 @@ describeWithEnvironment('PerformanceAgent – call tree focus', () => {
               },
             }]]),
           },
-          ConversationType.PERFORMANCE);
+          ConversationType.PERFORMANCE_CALL_TREE);
 
       const context = PerformanceTraceContext.fromCallTree(aiCallTree);
       const responses = await Array.fromAsync(agent.run('test', {selected: context}));
@@ -226,7 +226,7 @@ describeWithEnvironment('PerformanceAgent – call tree focus', () => {
           {
             aidaClient: {} as Host.AidaClient.AidaClient,
           },
-          ConversationType.PERFORMANCE);
+          ConversationType.PERFORMANCE_CALL_TREE);
 
       const mockAiCallTree = {
         serialize: () => 'Mock call tree',
@@ -289,7 +289,7 @@ describeWithEnvironment('PerformanceAgent – insight focus', () => {
     const lcpBreakdown = getInsightOrError('LCPBreakdown', insights, firstNav);
     const insightSet = getInsightSetOrError(insights, firstNav);
     const context = PerformanceTraceContext.fromInsight(parsedTrace, lcpBreakdown, insightSet.bounds);
-    assert.strictEqual(context.getOrigin(), 'trace-658799706428-658804825864');
+    assert.strictEqual(context.getOrigin(), 'insight-658799706428-658804825864');
   });
 
   it('outputs the right title for the selected insight', async () => {
@@ -546,8 +546,8 @@ Help me understand?`;
       const action = responses.find(response => response.type === ResponseType.ACTION);
       assert.exists(action);
 
-      const expectedTree =
-          TimelineUtils.InsightAIContext.AIQueries.mainThreadActivity(lcpBreakdown, insightSet.bounds, parsedTrace);
+      const expectedTree = TimelineUtils.InsightAIContext.AIQueries.mainThreadActivityForInsight(
+          lcpBreakdown, insightSet.bounds, parsedTrace);
       assert.isOk(expectedTree);
 
       const expectedBytesSize = Platform.StringUtilities.countWtf8Bytes(expectedTree.serialize());
@@ -631,8 +631,8 @@ Help me understand?`;
       const mainThreadActivityFact = Array.from(agent.currentFacts()).at(0);
       assert.exists(mainThreadActivityFact);
 
-      const expectedTree =
-          TimelineUtils.InsightAIContext.AIQueries.mainThreadActivity(lcpBreakdown, insightSet.bounds, parsedTrace);
+      const expectedTree = TimelineUtils.InsightAIContext.AIQueries.mainThreadActivityForInsight(
+          lcpBreakdown, insightSet.bounds, parsedTrace);
       assert.isOk(expectedTree);
       assert.include(mainThreadActivityFact.text, expectedTree.serialize());
 
@@ -729,20 +729,31 @@ Help me understand?`;
 
          const expectedFormatDescription =
              `The tree is represented as a call frame with a root task and a series of children.
-  The format of each callframe is:
+The format of each callframe is:
 
-    'id;name;duration;selfTime;urlIndex;childRange;[S]'
+  'id;name;duration;selfTime;urlIndex;childRange;[S]'
 
-  The fields are:
+The fields are:
 
-  * id: A unique numerical identifier for the call frame.
-  * name: A concise string describing the call frame (e.g., 'Evaluate Script', 'render', 'fetchData').
-  * duration: The total execution time of the call frame, including its children.
-  * selfTime: The time spent directly within the call frame, excluding its children's execution.
-  * urlIndex: Index referencing the "All URLs" list. Empty if no specific script URL is associated.
-  * childRange: Specifies the direct children of this node using their IDs. If empty ('' or 'S' at the end), the node has no children. If a single number (e.g., '4'), the node has one child with that ID. If in the format 'firstId-lastId' (e.g., '4-5'), it indicates a consecutive range of child IDs from 'firstId' to 'lastId', inclusive.
-  * S: **Optional marker.** The letter 'S' appears at the end of the line **only** for the single call frame selected by the user.`;
+* id: A unique numerical identifier for the call frame.
+* name: A concise string describing the call frame (e.g., 'Evaluate Script', 'render', 'fetchData').
+* duration: The total execution time of the call frame, including its children.
+* selfTime: The time spent directly within the call frame, excluding its children's execution.
+* urlIndex: Index referencing the "All URLs" list. Empty if no specific script URL is associated.
+* childRange: Specifies the direct children of this node using their IDs. If empty ('' or 'S' at the end), the node has no children. If a single number (e.g., '4'), the node has one child with that ID. If in the format 'firstId-lastId' (e.g., '4-5'), it indicates a consecutive range of child IDs from 'firstId' to 'lastId', inclusive.
+* S: **Optional marker.** The letter 'S' appears at the end of the line **only** for the single call frame selected by the user.`;
          assert.deepEqual(mainThreadActivityDescriptionFact.text, expectedFormatDescription);
        });
   });
 });
+
+describeWithEnvironment('PerformanceAgent – all focus', () => {
+  it('uses the min and max bounds of the trace as the origin', async function() {
+    const {parsedTrace, insights, metadata} = await TraceLoader.traceEngine(this, 'lcp-images.json.gz');
+    assert.isOk(insights);
+    const [firstNav] = parsedTrace.Meta.mainFrameNavigations;
+    const insightSet = getInsightSetOrError(insights, firstNav);
+    const context = PerformanceTraceContext.full(parsedTrace, insightSet, metadata);
+    assert.strictEqual(context.getOrigin(), 'trace-658799706428-658804825864');
+  });
+});