Convert prefer-assert-is-ok to TypeScript

Bug: chromium:397586315
Change-Id: I2720845c34287bfbc0c3af6d0312765cf112246c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6441158
Auto-Submit: Mathias Bynens <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Mathias Bynens <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: mathiasbynens

scripts/eslint_rules/lib/prefer-assert-is-ok.js renamed to scripts/eslint_rules/lib/prefer-assert-is-ok.ts

@@ -1,25 +1,13 @@
 // Copyright 2024 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
 
-/**
- * @fileoverview Prefer `assert.isOk` and `assert.isNotOk` over `assert.ok`
- * and `assert.notOk`.
- *
- * For consistency with the other `assert.isXXX` checks, we standardize on
- * `assert.isOk` and `assert.isNotOk`. We still also allow plain `assert`.
- */
+import {createRule} from './tsUtils.ts';
 
-// ------------------------------------------------------------------------------
-// Rule Definition
-// ------------------------------------------------------------------------------
-
-/** @type {import('eslint').Rule.RuleModule} */
-module.exports = {
+export default createRule({
+  name: 'prefer-assert-is-ok',
   meta: {
     type: 'suggestion',
-
     docs: {
       description: 'Prefer `assert.isOk` and `assert.isNotOk` over `assert.ok` and `assert.notOk`.',
       category: 'Best Practices',
@@ -29,23 +17,20 @@ module.exports = {
       useAssertIsNotOk: 'Use `assert.isNotOk(e)` or `assert(!e)` instead of `assert.notOk(e)`',
     },
     fixable: 'code',
-    schema: [], // no options
+    schema: [],  // no options
   },
-  create: function (context) {
+  defaultOptions: [],
+  create: function(context) {
     function isAssertOk(calleeNode) {
-      return calleeNode.type === 'MemberExpression' &&
-             calleeNode.object.type === 'Identifier' &&
-             calleeNode.object.name === 'assert' &&
-             calleeNode.property.type === 'Identifier' &&
-             calleeNode.property.name === 'ok';
+      return calleeNode.type === 'MemberExpression' && calleeNode.object.type === 'Identifier' &&
+          calleeNode.object.name === 'assert' && calleeNode.property.type === 'Identifier' &&
+          calleeNode.property.name === 'ok';
     }
 
     function isAssertNotOk(calleeNode) {
-      return calleeNode.type === 'MemberExpression' &&
-             calleeNode.object.type === 'Identifier' &&
-             calleeNode.object.name === 'assert' &&
-             calleeNode.property.type === 'Identifier' &&
-             calleeNode.property.name === 'notOk';
+      return calleeNode.type === 'MemberExpression' && calleeNode.object.type === 'Identifier' &&
+          calleeNode.object.name === 'assert' && calleeNode.property.type === 'Identifier' &&
+          calleeNode.property.name === 'notOk';
     }
 
     function reportError(node, calleeText, messageId) {
@@ -68,4 +53,4 @@ module.exports = {
       }
     };
   },
-};
+});

scripts/eslint_rules/tests/prefer-assert-is-ok.test.js renamed to scripts/eslint_rules/tests/prefer-assert-is-ok.test.ts

@@ -1,11 +1,10 @@
 // Copyright 2024 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
 
-const rule = require('../lib/prefer-assert-is-ok.js');
+import rule from '../lib/prefer-assert-is-ok.ts';
 
-const {RuleTester} = require('./utils/utils.js');
+import {RuleTester} from './utils/tsUtils.ts';
 
 new RuleTester().run('prefer-assert-is-ok', rule, {
   valid: [