Skip to content

Commit 8882e30

Browse files
pfaffeDevtools-frontend LUCI CQ
authored andcommitted
Flaky test "fix"
We've seen some flaky behavior in the beforeEach for VE logging. Drop the beforeEach so that flake exoneration can do its job. Bug: none Change-Id: I530e37a6135f90bb9cbd3fa27d810c6e10a6bae1 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6343237 Commit-Queue: Philip Pfaffe <[email protected]> Auto-Submit: Philip Pfaffe <[email protected]> Reviewed-by: Danil Somsikov <[email protected]> Commit-Queue: Danil Somsikov <[email protected]>
1 parent 7daafbe commit 8882e30

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

test/e2e/application/service-worker-update_test.ts

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import {assert} from 'chai';
55

66
import {unregisterAllServiceWorkers} from '../../conductor/hooks.js';
7-
import {step, waitFor} from '../../shared/helper.js';
7+
import {waitFor} from '../../shared/helper.js';
88
import {
99
navigateToApplicationTab,
1010
navigateToServiceWorkers,
@@ -15,20 +15,14 @@ const TEST_HTML_FILE = 'service-worker-network';
1515
const SERVICE_WORKER_UPDATE_TIMELINE_SELECTOR = '.service-worker-update-timing-table';
1616

1717
describe('The Application Tab', function() {
18-
beforeEach(async function() {
18+
it('Navigate to a page with service worker we should find service worker update timeline info', async () => {
1919
await navigateToApplicationTab(TEST_HTML_FILE);
2020
await navigateToServiceWorkers();
21-
});
2221

23-
afterEach(async () => {
24-
await unregisterAllServiceWorkers();
25-
});
22+
const timeline = await waitFor(SERVICE_WORKER_UPDATE_TIMELINE_SELECTOR);
23+
assert.isDefined(timeline);
2624

27-
it('Navigate to a page with service worker we should find service worker update timeline info', async () => {
28-
await step('wait and locate service worker update time line', async () => {
29-
const timeline = await waitFor(SERVICE_WORKER_UPDATE_TIMELINE_SELECTOR);
30-
assert.isDefined(timeline);
31-
});
3225
await unregisterServiceWorker();
26+
await unregisterAllServiceWorkers();
3327
});
3428
});

0 commit comments

Comments
 (0)