Skip to content

Commit 8b2f1e6

Browse files
jackfranklinDevtools-frontend LUCI CQ
authored andcommitted
Fix this in Mocha it
This custom declaration leaks into all of DevTools (a problem we should solve more broadly) and causes noise in tests where we rely on the `this` to set timeouts, etc. Bug: none Change-Id: I5253787e8e3c494540c4768a1c48c7b4bd0be444 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6308827 Commit-Queue: Nikolay Vitkov <[email protected]> Commit-Queue: Jack Franklin <[email protected]> Reviewed-by: Nikolay Vitkov <[email protected]> Auto-Submit: Jack Franklin <[email protected]>
1 parent 5f037a6 commit 8b2f1e6

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/e2e_non_hosted/types.d.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
import type {Platform} from '../conductor/platform.js';
32

43
import type {BrowserSettings, BrowserWrapper} from './shared/browser-helper.js';
@@ -30,6 +29,6 @@ declare global {
3029
}
3130

3231
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
33-
export type TestCallbackWithState = (state: State) => PromiseLike<any>;
32+
export type TestCallbackWithState = (this: Mocha.Context, state: State) => PromiseLike<any>;
3433
}
3534
}

0 commit comments

Comments
 (0)