[Freestyler] Add AiAgent test to build

The file was omitted so the test were never run.
Fixed the test and re-wrote a part to be easier to use

Bug: none
Change-Id: I18e635d07eee297e161fe6ad8acc87c29fff13f6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5962000
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

front_end/panels/freestyler/AiAgent.test.ts

@@ -24,7 +24,7 @@ class AiAgentMock extends AiAgent<unknown> {
 
   options: Freestyler.AidaRequestOptions = {
     temperature: 1,
-    model_id: 'test model',
+    modelId: 'test model',
   };
 }
 
@@ -110,7 +110,7 @@ describeWithEnvironment('AiAgent', () => {
         aidaClient: {} as Host.AidaClient.AidaClient,
       });
       const request = agent.buildRequest({input: 'test input'});
-      assert.strictEqual(request.metadata?.string_session_id, 'session_id');
+      assert.strictEqual(request.metadata?.string_session_id, 'sessionId');
     });
 
     it('builds a request with preamble', async () => {

front_end/panels/freestyler/AiAgent.ts

@@ -98,8 +98,7 @@ export interface HistoryChunk {
 
 export interface AidaRequestOptions {
   temperature?: number;
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  model_id?: string;
+  modelId?: string;
 }
 
 interface AgentOptions {
@@ -205,7 +204,11 @@ export abstract class AiAgent<T> {
       // eslint-disable-next-line @typescript-eslint/naming-convention
       chat_history: this.#history.size ? this.#historyEntry : undefined,
       client: Host.AidaClient.CLIENT_NAME,
-      options: this.options,
+      options: {
+        temperature: AiAgent.validTemperature(this.options.temperature),
+        // eslint-disable-next-line @typescript-eslint/naming-convention
+        model_id: this.options.modelId,
+      },
       metadata: {
         disable_user_content_logging: !(this.#serverSideLoggingEnabled ?? false),
         string_session_id: this.#sessionId,

front_end/panels/freestyler/BUILD.gn

@@ -77,6 +77,7 @@ ts_library("unittests") {
   testonly = true
 
   sources = [
+    "AiAgent.test.ts",
     "ChangeManager.test.ts",
     "DrJonesFileAgent.test.ts",
     "DrJonesNetworkAgent.test.ts",

front_end/panels/freestyler/DrJonesFileAgent.ts

@@ -76,12 +76,12 @@ export class DrJonesFileAgent extends AiAgent<Workspace.UISourceCode.UISourceCod
   }
   get options(): AidaRequestOptions {
     const config = Common.Settings.Settings.instance().getHostConfig();
-    const temperature = AiAgent.validTemperature(config.devToolsAiAssistanceFileAgentDogfood?.temperature);
+    const temperature = config.devToolsAiAssistanceFileAgentDogfood?.temperature;
     const modelId = config.devToolsAiAssistanceFileAgentDogfood?.modelId;
 
     return {
       temperature,
-      model_id: modelId,
+      modelId,
     };
   }
 

front_end/panels/freestyler/DrJonesNetworkAgent.ts

@@ -109,12 +109,12 @@ export class DrJonesNetworkAgent extends AiAgent<SDK.NetworkRequest.NetworkReque
   }
   get options(): AidaRequestOptions {
     const config = Common.Settings.Settings.instance().getHostConfig();
-    const temperature = AiAgent.validTemperature(config.devToolsExplainThisResourceDogfood?.temperature);
+    const temperature = config.devToolsExplainThisResourceDogfood?.temperature;
     const modelId = config.devToolsExplainThisResourceDogfood?.modelId;
 
     return {
       temperature,
-      model_id: modelId,
+      modelId,
     };
   }
 

front_end/panels/freestyler/DrJonesPerformanceAgent.ts

@@ -80,12 +80,12 @@ export class DrJonesPerformanceAgent extends AiAgent<Trace.Helpers.TreeHelpers.A
   }
   get options(): AidaRequestOptions {
     const config = Common.Settings.Settings.instance().getHostConfig();
-    const temperature = AiAgent.validTemperature(config.devToolsAiAssistancePerformanceAgentDogfood?.temperature);
+    const temperature = config.devToolsAiAssistancePerformanceAgentDogfood?.temperature;
     const modelId = config.devToolsAiAssistancePerformanceAgentDogfood?.modelId;
 
     return {
       temperature,
-      model_id: modelId,
+      modelId,
     };
   }
 

front_end/panels/freestyler/FreestylerAgent.ts

@@ -208,12 +208,12 @@ export class FreestylerAgent extends AiAgent<SDK.DOMModel.DOMNode> {
 
   get options(): AidaRequestOptions {
     const config = Common.Settings.Settings.instance().getHostConfig();
-    const temperature = AiAgent.validTemperature(config.devToolsFreestyler?.temperature);
+    const temperature = config.devToolsFreestyler?.temperature;
     const modelId = config.devToolsFreestyler?.modelId;
 
     return {
       temperature,
-      model_id: modelId,
+      modelId,
     };
   }