[Conversation History] Fix history context menu

Compare IDs instead of the conversation objects when determining which
conversation should be checked and when switching to a historic
conversation.

Fixed: 462384422
Change-Id: I3c018498dbf95cb65ba298bcec4f3a7343b41e1d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7185564
Commit-Queue: Nikolay Vitkov <[email protected]>
Commit-Queue: Wolfgang Beyer <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Auto-Submit: Wolfgang Beyer <[email protected]>

Author: wolfib

front_end/panels/ai_assistance/AiAssistancePanel.test.ts

@@ -752,6 +752,66 @@ describeWithMockConnection('AI Assistance Panel', () => {
       ]);
     });
 
+    it('allows continuing the active conversation if re-opened via history context menu', async () => {
+      updateHostConfig({
+        devToolsFreestyler: {
+          enabled: true,
+        },
+      });
+      const {panel, view} = await createAiAssistancePanel(
+          {
+            aidaClient: mockAidaClient(
+                [
+                  [{explanation: 'test'}],
+                  [{explanation: 'test2'}],
+                ],
+                ),
+          },
+      );
+      void panel.handleAction('freestyler.elements-floating-button');
+      let nextInput = await view.nextInput;
+      assert(nextInput.state === AiAssistancePanel.ViewState.CHAT_VIEW);
+      nextInput.props.onTextSubmit('User question to Freestyler?');
+      nextInput = await view.nextInput;
+      assert(nextInput.state === AiAssistancePanel.ViewState.CHAT_VIEW);
+
+      const {contextMenu, id, entry} = openHistoryContextMenu(nextInput, 'User question to Freestyler?');
+      assert.isTrue(entry?.buildDescriptor().checked);
+
+      assert.isDefined(id);
+      contextMenu.invokeHandler(id);
+
+      nextInput.props.onTextSubmit('Second question to Freestyler?');
+      nextInput = await view.nextInput;
+      assert(nextInput.state === AiAssistancePanel.ViewState.CHAT_VIEW);
+      assert.deepEqual(nextInput.props.messages, [
+        {
+          entity: AiAssistancePanel.ChatMessageEntity.USER,
+          text: 'User question to Freestyler?',
+          imageInput: undefined,
+        },
+        {
+          answer: 'test',
+          entity: AiAssistancePanel.ChatMessageEntity.MODEL,
+          rpcId: undefined,
+          suggestions: undefined,
+          steps: [],
+        },
+        {
+          entity: AiAssistancePanel.ChatMessageEntity.USER,
+          text: 'Second question to Freestyler?',
+          imageInput: undefined,
+        },
+        {
+          answer: 'test2',
+          entity: AiAssistancePanel.ChatMessageEntity.MODEL,
+          rpcId: undefined,
+          suggestions: undefined,
+          steps: [],
+        },
+      ]);
+    });
+
     describe('action-triggered prompts', () => {
       it('runs action-triggered prompts when the user can execute a prompt', async () => {
         updateHostConfig({

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -1166,7 +1166,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
       contextMenu.defaultSection().appendCheckboxItem(conversation.title, () => {
         void this.#openHistoricConversation(conversation);
-      }, {checked: (this.#conversation === conversation), jslogContext: 'freestyler.history-item'});
+      }, {checked: (this.#conversation?.id === conversation.id), jslogContext: 'freestyler.history-item'});
     }
 
     const historyEmpty = contextMenu.defaultSection().items.length === 0;
@@ -1224,7 +1224,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   }
 
   async #openHistoricConversation(conversation: AiAssistanceModel.AiConversation.AiConversation): Promise<void> {
-    if (this.#conversation === conversation) {
+    if (this.#conversation?.id === conversation.id) {
       return;
     }
 

front_end/testing/AiAssistanceHelpers.ts

@@ -314,10 +314,11 @@ export function openHistoryContextMenu(
   const contextMenu = new UI.ContextMenu.ContextMenu(new MouseEvent('click'));
   lastUpdate.populateHistoryMenu(contextMenu);
 
-  const freestylerEntry = findMenuItemWithLabel(contextMenu.defaultSection(), item);
+  const entry = findMenuItemWithLabel(contextMenu.defaultSection(), item);
   return {
     contextMenu,
-    id: freestylerEntry?.id(),
+    id: entry?.id(),
+    entry,
   };
 }