Skip to content

Commit 8f3a941

Browse files
szuendDevtools-frontend LUCI CQ
authored andcommitted
[build] Cleanup devtools_module.gni
Introduce a "devtools_base_module" template that the others can use. [email protected] Bug: 451542954 Change-Id: I1b95870d7a34ab6b4156fbddaabb3b976ea03e8c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7048337 Auto-Submit: Simon Zünd <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Alex Rudenko <[email protected]>
1 parent 18c271b commit 8f3a941

File tree

1 file changed

+24
-22
lines changed

1 file changed

+24
-22
lines changed

scripts/build/ninja/devtools_module.gni

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@
44

55
import("../../../scripts/build/typescript/typescript.gni")
66

7-
template("devtools_module") {
7+
template("devtools_base_module") {
88
ts_library(target_name) {
99
forward_variables_from(invoker,
1010
[
1111
"deps",
1212
"public_deps",
1313
"sources",
1414
"data",
15+
"es_target",
16+
"es_libs",
1517
])
1618

1719
reset_timestamps = true
@@ -20,32 +22,32 @@ template("devtools_module") {
2022
}
2123
}
2224

23-
set_defaults("devtools_module") {
24-
visibility = []
25-
data = []
26-
public_deps = []
25+
template("devtools_module") {
26+
devtools_base_module(target_name) {
27+
forward_variables_from(invoker, "*")
28+
}
2729
}
2830

2931
template("devtools_ui_module") {
30-
ts_library(target_name) {
31-
forward_variables_from(invoker,
32-
[
33-
"deps",
34-
"public_deps",
35-
"sources",
36-
"data",
37-
])
32+
devtools_base_module(target_name) {
33+
forward_variables_from(invoker, "*")
3834

3935
es_target = "esnext"
40-
es_libs = ["dom", "dom.iterable"]
41-
42-
reset_timestamps = true
43-
44-
visibility += [ ":*" ]
36+
es_libs = [
37+
"dom",
38+
"dom.iterable",
39+
]
4540
}
4641
}
47-
set_defaults("devtools_ui_module") {
48-
visibility = []
49-
data = []
50-
public_deps = []
42+
43+
foreach(module,
44+
[
45+
"devtools_module",
46+
"devtools_ui_module",
47+
]) {
48+
set_defaults(module) {
49+
visibility = []
50+
data = []
51+
public_deps = []
52+
}
5153
}

0 commit comments

Comments
 (0)