Skip to content

Commit 8f5d339

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
devtools-ci-autoroll-builder
authored and
Devtools-frontend LUCI CQ
committed
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8718882819977049313 [email protected] Bug: none Change-Id: Idd3d0b1de31dc784a35eac2b497aa3c74af8a563 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414692 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Simon Zünd <[email protected]>
1 parent 53fc6d3 commit 8f5d339

File tree

8 files changed

+214
-38
lines changed

8 files changed

+214
-38
lines changed

‎DEPS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '940abfc668be2591483f7132145593c6a047f3cf',
2525

2626
# Keeping track of the last time we rollerd the browser protocol files.
27-
'chromium_browser_protocol_revision' : '69ba25d7708ae207fc6a879039984dc4dd71a056',
27+
'chromium_browser_protocol_revision' : '43e4a99fb37358d50c74187b7944a4519683b8a7',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

‎front_end/generated/InspectorBackendCommands.js‎

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎front_end/generated/protocol-mapping.d.ts‎

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4744,19 +4744,36 @@ export namespace ProtocolMapping {
47444744
returnType: void;
47454745
};
47464746
/**
4747-
* Adds a service with |uuid| to the peripheral with |address|.
4747+
* Adds a service with |serviceUuid| to the peripheral with |address|.
47484748
*/
47494749
'BluetoothEmulation.addService': {
47504750
paramsType: [Protocol.BluetoothEmulation.AddServiceRequest];
47514751
returnType: Protocol.BluetoothEmulation.AddServiceResponse;
47524752
};
47534753
/**
4754-
* Removes the service respresented by |id| from the peripheral with |address|.
4754+
* Removes the service respresented by |serviceId| from the peripheral with
4755+
* |address|.
47554756
*/
47564757
'BluetoothEmulation.removeService': {
47574758
paramsType: [Protocol.BluetoothEmulation.RemoveServiceRequest];
47584759
returnType: void;
47594760
};
4761+
/**
4762+
* Adds a characteristic with |characteristicUuid| and |properties| to the
4763+
* service represented by |serviceId| in the peripheral with |address|.
4764+
*/
4765+
'BluetoothEmulation.addCharacteristic': {
4766+
paramsType: [Protocol.BluetoothEmulation.AddCharacteristicRequest];
4767+
returnType: Protocol.BluetoothEmulation.AddCharacteristicResponse;
4768+
};
4769+
/**
4770+
* Removes the characteristic respresented by |characteristicId| from the
4771+
* service respresented by |serviceId| in the peripheral with |address|.
4772+
*/
4773+
'BluetoothEmulation.removeCharacteristic': {
4774+
paramsType: [Protocol.BluetoothEmulation.RemoveCharacteristicRequest];
4775+
returnType: void;
4776+
};
47604777
/**
47614778
* Continues execution until specific location is reached.
47624779
*/

‎front_end/generated/protocol-proxy-api.d.ts‎

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4219,15 +4219,28 @@ declare namespace ProtocolProxyApi {
42194219
invoke_simulateGATTOperationResponse(params: Protocol.BluetoothEmulation.SimulateGATTOperationResponseRequest): Promise<Protocol.ProtocolResponseWithError>;
42204220

42214221
/**
4222-
* Adds a service with |uuid| to the peripheral with |address|.
4222+
* Adds a service with |serviceUuid| to the peripheral with |address|.
42234223
*/
42244224
invoke_addService(params: Protocol.BluetoothEmulation.AddServiceRequest): Promise<Protocol.BluetoothEmulation.AddServiceResponse>;
42254225

42264226
/**
4227-
* Removes the service respresented by |id| from the peripheral with |address|.
4227+
* Removes the service respresented by |serviceId| from the peripheral with
4228+
* |address|.
42284229
*/
42294230
invoke_removeService(params: Protocol.BluetoothEmulation.RemoveServiceRequest): Promise<Protocol.ProtocolResponseWithError>;
42304231

4232+
/**
4233+
* Adds a characteristic with |characteristicUuid| and |properties| to the
4234+
* service represented by |serviceId| in the peripheral with |address|.
4235+
*/
4236+
invoke_addCharacteristic(params: Protocol.BluetoothEmulation.AddCharacteristicRequest): Promise<Protocol.BluetoothEmulation.AddCharacteristicResponse>;
4237+
4238+
/**
4239+
* Removes the characteristic respresented by |characteristicId| from the
4240+
* service respresented by |serviceId| in the peripheral with |address|.
4241+
*/
4242+
invoke_removeCharacteristic(params: Protocol.BluetoothEmulation.RemoveCharacteristicRequest): Promise<Protocol.ProtocolResponseWithError>;
4243+
42314244
}
42324245
export interface BluetoothEmulationDispatcher {
42334246
/**

‎front_end/generated/protocol.ts‎

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18360,6 +18360,21 @@ export namespace BluetoothEmulation {
1836018360
scanRecord: ScanRecord;
1836118361
}
1836218362

18363+
/**
18364+
* Describes the properties of a characteristic. This follows Bluetooth Core
18365+
* Specification BT 4.2 Vol 3 Part G 3.3.1. Characteristic Properties.
18366+
*/
18367+
export interface CharacteristicProperties {
18368+
broadcast?: boolean;
18369+
read?: boolean;
18370+
writeWithoutResponse?: boolean;
18371+
write?: boolean;
18372+
notify?: boolean;
18373+
indicate?: boolean;
18374+
authenticatedSignedWrites?: boolean;
18375+
extendedProperties?: boolean;
18376+
}
18377+
1836318378
export interface EnableRequest {
1836418379
/**
1836518380
* State of the simulated central.
@@ -18404,12 +18419,32 @@ export namespace BluetoothEmulation {
1840418419
/**
1840518420
* An identifier that uniquely represents this service.
1840618421
*/
18407-
id: string;
18422+
serviceId: string;
1840818423
}
1840918424

1841018425
export interface RemoveServiceRequest {
1841118426
address: string;
18412-
id: string;
18427+
serviceId: string;
18428+
}
18429+
18430+
export interface AddCharacteristicRequest {
18431+
address: string;
18432+
serviceId: string;
18433+
characteristicUuid: string;
18434+
properties: CharacteristicProperties;
18435+
}
18436+
18437+
export interface AddCharacteristicResponse extends ProtocolResponseWithError {
18438+
/**
18439+
* An identifier that uniquely represents this characteristic.
18440+
*/
18441+
characteristicId: string;
18442+
}
18443+
18444+
export interface RemoveCharacteristicRequest {
18445+
address: string;
18446+
serviceId: string;
18447+
characteristicId: string;
1841318448
}
1841418449

1841518450
/**

‎front_end/models/javascript_metadata/NativeFunctions.js‎

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,6 @@ export const NativeFunctions = [
111111
signatures: [["name"],["?options"]],
112112
receivers: ["CookieStore"]
113113
},
114-
{
115-
name: "get",
116-
signatures: [["instrumentKey"]],
117-
receivers: ["PaymentInstruments"]
118-
},
119114
{
120115
name: "set",
121116
signatures: [["v"]],
@@ -171,11 +166,6 @@ export const NativeFunctions = [
171166
signatures: [["cookieInit"],["name","value"]],
172167
receivers: ["CookieStore"]
173168
},
174-
{
175-
name: "set",
176-
signatures: [["instrumentKey","details"]],
177-
receivers: ["PaymentInstruments"]
178-
},
179169
{
180170
name: "toLocaleString",
181171
signatures: [["?locales","?options"]],
@@ -1581,11 +1571,6 @@ export const NativeFunctions = [
15811571
signatures: [["name"],["options"]],
15821572
receivers: ["CookieStore"]
15831573
},
1584-
{
1585-
name: "delete",
1586-
signatures: [["instrumentKey"]],
1587-
receivers: ["PaymentInstruments"]
1588-
},
15891574
{
15901575
name: "matchAll",
15911576
signatures: [["?request","?options"]],
@@ -1656,11 +1641,6 @@ export const NativeFunctions = [
16561641
signatures: [["value"]],
16571642
receivers: ["Set","ReadonlySet","WeakSet","ReadonlySetLike"]
16581643
},
1659-
{
1660-
name: "has",
1661-
signatures: [["instrumentKey"]],
1662-
receivers: ["PaymentInstruments"]
1663-
},
16641644
{
16651645
name: "open",
16661646
signatures: [["cacheName"]],
@@ -8855,7 +8835,7 @@ export const NativeFunctions = [
88558835
},
88568836
{
88578837
name: "copyBufferToBuffer",
8858-
signatures: [["src","srcOffset","dst","dstOffset","size"]]
8838+
signatures: [["source","destination","?size"],["source","sourceOffset","destination","destinationOffset","?size"]]
88598839
},
88608840
{
88618841
name: "copyBufferToTexture",

‎third_party/blink/public/devtools_protocol/browser_protocol.json‎

Lines changed: 98 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27922,6 +27922,53 @@
2792227922
"$ref": "ScanRecord"
2792327923
}
2792427924
]
27925+
},
27926+
{
27927+
"id": "CharacteristicProperties",
27928+
"description": "Describes the properties of a characteristic. This follows Bluetooth Core\nSpecification BT 4.2 Vol 3 Part G 3.3.1. Characteristic Properties.",
27929+
"type": "object",
27930+
"properties": [
27931+
{
27932+
"name": "broadcast",
27933+
"optional": true,
27934+
"type": "boolean"
27935+
},
27936+
{
27937+
"name": "read",
27938+
"optional": true,
27939+
"type": "boolean"
27940+
},
27941+
{
27942+
"name": "writeWithoutResponse",
27943+
"optional": true,
27944+
"type": "boolean"
27945+
},
27946+
{
27947+
"name": "write",
27948+
"optional": true,
27949+
"type": "boolean"
27950+
},
27951+
{
27952+
"name": "notify",
27953+
"optional": true,
27954+
"type": "boolean"
27955+
},
27956+
{
27957+
"name": "indicate",
27958+
"optional": true,
27959+
"type": "boolean"
27960+
},
27961+
{
27962+
"name": "authenticatedSignedWrites",
27963+
"optional": true,
27964+
"type": "boolean"
27965+
},
27966+
{
27967+
"name": "extendedProperties",
27968+
"optional": true,
27969+
"type": "boolean"
27970+
}
27971+
]
2792527972
}
2792627973
],
2792727974
"commands": [
@@ -28014,7 +28061,7 @@
2801428061
},
2801528062
{
2801628063
"name": "addService",
28017-
"description": "Adds a service with |uuid| to the peripheral with |address|.",
28064+
"description": "Adds a service with |serviceUuid| to the peripheral with |address|.",
2801828065
"parameters": [
2801928066
{
2802028067
"name": "address",
@@ -28027,22 +28074,69 @@
2802728074
],
2802828075
"returns": [
2802928076
{
28030-
"name": "id",
28077+
"name": "serviceId",
2803128078
"description": "An identifier that uniquely represents this service.",
2803228079
"type": "string"
2803328080
}
2803428081
]
2803528082
},
2803628083
{
2803728084
"name": "removeService",
28038-
"description": "Removes the service respresented by |id| from the peripheral with |address|.",
28085+
"description": "Removes the service respresented by |serviceId| from the peripheral with\n|address|.",
2803928086
"parameters": [
2804028087
{
2804128088
"name": "address",
2804228089
"type": "string"
2804328090
},
2804428091
{
28045-
"name": "id",
28092+
"name": "serviceId",
28093+
"type": "string"
28094+
}
28095+
]
28096+
},
28097+
{
28098+
"name": "addCharacteristic",
28099+
"description": "Adds a characteristic with |characteristicUuid| and |properties| to the\nservice represented by |serviceId| in the peripheral with |address|.",
28100+
"parameters": [
28101+
{
28102+
"name": "address",
28103+
"type": "string"
28104+
},
28105+
{
28106+
"name": "serviceId",
28107+
"type": "string"
28108+
},
28109+
{
28110+
"name": "characteristicUuid",
28111+
"type": "string"
28112+
},
28113+
{
28114+
"name": "properties",
28115+
"$ref": "CharacteristicProperties"
28116+
}
28117+
],
28118+
"returns": [
28119+
{
28120+
"name": "characteristicId",
28121+
"description": "An identifier that uniquely represents this characteristic.",
28122+
"type": "string"
28123+
}
28124+
]
28125+
},
28126+
{
28127+
"name": "removeCharacteristic",
28128+
"description": "Removes the characteristic respresented by |characteristicId| from the\nservice respresented by |serviceId| in the peripheral with |address|.",
28129+
"parameters": [
28130+
{
28131+
"name": "address",
28132+
"type": "string"
28133+
},
28134+
{
28135+
"name": "serviceId",
28136+
"type": "string"
28137+
},
28138+
{
28139+
"name": "characteristicId",
2804628140
"type": "string"
2804728141
}
2804828142
]

0 commit comments

Comments
 (0)