[AI Assistance] Don't send rpcId for partial answers

This makes sure that we don't show any UI for rating before the
answer is complete.

Bug: none
Change-Id: I62f09390fb384bece9efb220e946b83c7fbec9f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6037626
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

front_end/panels/freestyler/AiAgent.test.ts

@@ -356,7 +356,6 @@ describeWithEnvironment('AiAgent', () => {
           {
             type: ResponseType.ANSWER,
             text: 'Partial ans',
-            rpcId: undefined,
           },
           {
             type: ResponseType.ANSWER,
@@ -421,7 +420,6 @@ describeWithEnvironment('AiAgent', () => {
         {
           type: ResponseType.ERROR,
           error: ErrorType.UNKNOWN,
-          rpcId: undefined,
         },
       ]);
     });

front_end/panels/freestyler/AiAgent.ts

@@ -36,7 +36,6 @@ export interface AnswerResponse {
 export interface ErrorResponse {
   type: ResponseType.ERROR;
   error: ErrorType;
-  rpcId?: number;
 }
 
 export interface ContextDetail {
@@ -464,7 +463,6 @@ STOP`;
             yield {
               type: ResponseType.ANSWER,
               text: parsedResponse.answer,
-              rpcId,
             };
           }
         }
@@ -475,7 +473,6 @@ STOP`;
           const response = {
             type: ResponseType.ERROR,
             error: ErrorType.ABORT,
-            rpcId,
           } as const;
           this.#addHistory(response);
           yield response;
@@ -486,7 +483,6 @@ STOP`;
         const response = {
           type: ResponseType.ERROR,
           error,
-          rpcId,
         } as const;
         Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceError);
         this.#addHistory(response);
@@ -499,7 +495,6 @@ STOP`;
         const response = {
           type: ResponseType.ERROR,
           error: ErrorType.UNKNOWN,
-          rpcId,
         } as const;
         Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceError);
         this.#addHistory(response);
@@ -526,7 +521,6 @@ STOP`;
           const response = {
             type: ResponseType.ERROR,
             error: ErrorType.UNKNOWN,
-            rpcId,
           } as const;
           Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceError);
           this.#addHistory(response);

front_end/panels/freestyler/FreestylerAgent.test.ts

@@ -928,7 +928,6 @@ STOP`,
       const agent = new FreestylerAgent({
         aidaClient: mockAidaClient(generateAnswer),
         execJs: sinon.spy(),
-
       });
 
       const responses = await Array.fromAsync(agent.run('test', {selected: new Freestyler.NodeContext(element)}));
@@ -952,12 +951,10 @@ STOP`,
           query: '# Inspected element\n\n* Its selector is `undefined`\n\n# User request\n\nQUERY: test',
         },
         {
-          rpcId: 123,
           text: 'this is the answer',
           type: Freestyler.ResponseType.ANSWER,
         },
         {
-          rpcId: 123,
           type: Freestyler.ResponseType.ERROR,
           error: Freestyler.ErrorType.BLOCK,
         },
@@ -1088,7 +1085,6 @@ STOP
         {
           type: Freestyler.ResponseType.ERROR,
           error: Freestyler.ErrorType.UNKNOWN,
-          rpcId: undefined,
         },
       ]);
       sinon.assert.notCalled(execJs);