Skip to content

Commit 939c09e

Browse files
szuendDevtools-frontend LUCI CQ
authored andcommitted
[stack_trace] Add 'MissingDebugInfo' to 'Frame's
The 'DebuggerLanguagePlugin' annotates each DebuggerModel.CallFrame in case symbol files are missing. We want to preserve this functionality with the new StackTrace abstraction. Once the CallStackSidebarPane is migrated, we can move the SDK.DebuggerModel.MissingDebugFiles type to models/stack_trace, and remove the SDK.DebuggerModel.MissingDebugInfoDetails all-together. Note that we use an enum on purpose. We want to move the localized UIStrings to the UI layer. [email protected] Bug: 433162438 Change-Id: Id7967973f9306d0054c9b56a4a448dd28de5f612 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6903182 Reviewed-by: Philip Pfaffe <[email protected]> Auto-Submit: Simon Zünd <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]>
1 parent 7a8c035 commit 939c09e

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

front_end/models/stack_trace/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ devtools_module("stack_trace") {
1010

1111
deps = [
1212
"../../core/common:bundle",
13+
"../../core/sdk:bundle",
1314
"../workspace:bundle",
1415
]
1516
}

front_end/models/stack_trace/StackTrace.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// found in the LICENSE file.
44

55
import type * as Common from '../../core/common/common.js';
6+
import type * as SDK from '../../core/sdk/sdk.js';
67
import type * as Workspace from '../workspace/workspace.js';
78

89
export interface StackTrace extends Common.EventTarget.EventTarget<EventTypes> {
@@ -24,8 +25,25 @@ export interface Frame {
2425
readonly name?: string;
2526
readonly line: number;
2627
readonly column: number;
28+
29+
readonly missingDebugInfo?: MissingDebugInfo;
2730
}
2831

32+
export const enum MissingDebugInfoType {
33+
/** No debug information at all for the call frame */
34+
NO_INFO = 'NO_INFO',
35+
36+
/** Some debug information available, but it references files with debug information we were not able to retrieve */
37+
PARTIAL_INFO = 'PARTIAL_INFO',
38+
}
39+
40+
export type MissingDebugInfo = {
41+
type: MissingDebugInfoType.NO_INFO,
42+
}|{
43+
type: MissingDebugInfoType.PARTIAL_INFO,
44+
missingDebugFiles: SDK.DebuggerModel.MissingDebugFiles[],
45+
};
46+
2947
export const enum Events {
3048
UPDATED = 'UPDATED',
3149
}

0 commit comments

Comments
 (0)