[Unit] Don't wait for RAF between normal tests

There are still gonna be rafs between test using withMockConnection,
withLocal and similar, but there we kinda need it with the way things are currently setup.

Bug: 449849125
Change-Id: I0fae30ef1eddafd7e4999950b6b131c816e87541
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7002876
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>

Author: Lightning00Blade

front_end/testing/DOMHooks.ts

@@ -57,7 +57,7 @@ function removeCSSEvaluationElement() {
  * Completely cleans out the test DOM to ensure it's empty for the next test run.
  * This is run automatically between tests - you should not be manually calling this yourself.
  **/
-export const cleanTestDOM = async (testName = '') => {
+export const cleanTestDOM = (testName = '') => {
   const previousContainer = document.getElementById(TEST_CONTAINER_ID);
   if (previousContainer) {
     removeChildren(previousContainer);
@@ -67,8 +67,6 @@ export const cleanTestDOM = async (testName = '') => {
   removeTextEditorTooltip();
   removeAnnouncer();
   removeCSSEvaluationElement();
-  // Make sure all DOM clean up happens before the raf
-  await raf();
   // Verify that nothing was left behind
   for (const child of document.body.children) {
     if (!documentBodyElements.has(child)) {
@@ -92,7 +90,8 @@ export const setupTestDOM = async () => {
     // AfterEach hook fails before cleaning the DOM.
     // Clean it here and report
     console.error('Non clean test state found!');
-    await cleanTestDOM();
+    cleanTestDOM();
+    await raf();
   }
   // Tests are run in light mode by default.
   setColorScheme('light');

front_end/testing/MockConnection.ts

@@ -7,6 +7,7 @@ import type * as SDK from '../core/sdk/sdk.js';
 import type {ProtocolMapping} from '../generated/protocol-mapping.js';
 import type * as ProtocolProxyApi from '../generated/protocol-proxy-api.js';
 
+import {raf} from './DOMHelpers.js';
 import {cleanTestDOM} from './DOMHooks.js';
 import {deinitializeGlobalVars, initializeGlobalVars} from './EnvironmentHelpers.js';
 import {setMockResourceTree} from './ResourceTreeHelpers.js';
@@ -136,7 +137,8 @@ async function disable() {
   }
   // Some Widgets rely on Global vars to be there so they
   // can properly remove state once they detach.
-  await cleanTestDOM();
+  cleanTestDOM();
+  await raf();
   await deinitializeGlobalVars();
   // @ts-expect-error Setting back to undefined as a hard reset.
   ProtocolClient.InspectorBackend.Connection.setFactory(undefined);

front_end/testing/test_setup.ts

@@ -77,7 +77,7 @@ beforeEach(async () => {
 });
 
 afterEach(async function() {
-  await cleanTestDOM(this.currentTest?.fullTitle());
+  cleanTestDOM(this.currentTest?.fullTitle());
   await checkForPendingActivity(this.currentTest?.fullTitle());
   stopTrackingAsyncActivity();
   // Clear out any Sinon stubs or spies between individual tests.