Skip to content

Commit 9532135

Browse files
danilsomsikovDevtools-frontend LUCI CQ
authored andcommitted
Use <devtools-new-data-grid> in TimelineSelectorStats
Bug: 390346490 Change-Id: Id9fea3853bcca6133341a4e5d6129cd6b7bdc6e3 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6213831 Auto-Submit: Danil Somsikov <[email protected]> Commit-Queue: Jack Franklin <[email protected]> Commit-Queue: Danil Somsikov <[email protected]> Reviewed-by: Jack Franklin <[email protected]>
1 parent 40a817d commit 9532135

File tree

9 files changed

+187
-200
lines changed

9 files changed

+187
-200
lines changed

config/gni/devtools_grd_files.gni

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1912,6 +1912,7 @@ grd_files_debug_sources = [
19121912
"front_end/panels/timeline/timelineMiniMap.css.js",
19131913
"front_end/panels/timeline/timelinePaintProfiler.css.js",
19141914
"front_end/panels/timeline/timelinePanel.css.js",
1915+
"front_end/panels/timeline/timelineSelectorStatsView.css.js",
19151916
"front_end/panels/timeline/timelineStatusDialog.css.js",
19161917
"front_end/panels/timeline/utils/AICallTree.js",
19171918
"front_end/panels/timeline/utils/EntityMapper.js",

front_end/panels/timeline/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ generate_css("css_files") {
4545
"timelineMiniMap.css",
4646
"timelinePaintProfiler.css",
4747
"timelinePanel.css",
48+
"timelineSelectorStatsView.css",
4849
"timelineStatusDialog.css",
4950
]
5051
}

front_end/panels/timeline/TimelineSelectorStatsView.ts

Lines changed: 152 additions & 185 deletions
Large diffs are not rendered by default.

front_end/panels/timeline/components/FieldSettingsDialog.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
import '../../../ui/components/data_grid/data_grid.js';
65
import './OriginMap.js';
76

87
import * as i18n from '../../../core/i18n/i18n.js';
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
/*
2+
* Copyright 2025 The Chromium Authors. All rights reserved.
3+
* Use of this source code is governed by a BSD-style license that can be
4+
* found in the LICENSE file.
5+
*/
6+
7+
devtools-new-data-grid {
8+
flex: auto;
9+
}

front_end/ui/components/linkifier/LinkifierImpl.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export class LinkifierClick extends Event {
3131
}
3232

3333
export class Linkifier extends HTMLElement {
34-
3534
readonly #shadow = this.attachShadow({mode: 'open'});
3635
#url: Platform.DevToolsPath.UrlString = Platform.DevToolsPath.EmptyUrlString;
3736
#lineNumber?: number;
@@ -53,6 +52,18 @@ export class Linkifier extends HTMLElement {
5352
void this.#render();
5453
}
5554

55+
override cloneNode(deep?: boolean): Node {
56+
const node = super.cloneNode(deep) as Linkifier;
57+
node.data = {
58+
url: this.#url,
59+
lineNumber: this.#lineNumber,
60+
columnNumber: this.#columnNumber,
61+
linkText: this.#linkText,
62+
title: this.#title
63+
};
64+
return node;
65+
}
66+
5667
connectedCallback(): void {
5768
this.#shadow.adoptedStyleSheets = [linkifierImplStyles];
5869
}

front_end/ui/legacy/components/data_grid/DataGridElement.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ class DataGridElement extends HTMLElement {
171171
if (align !== Align.CENTER && align !== Align.RIGHT) {
172172
align = undefined;
173173
}
174-
const weight = parseInt(column.getAttribute('weight') || '', 10) ?? undefined;
174+
const weight = parseFloat(column.getAttribute('weight') || '') ?? undefined;
175175
this.#dataGrid.addColumn({
176176
id,
177177
title: title as Platform.UIString.LocalizedString,

front_end/ui/visual_logging/KnownContextValues.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1237,9 +1237,8 @@ export const knownContextValues = new Set([
12371237
'edit-title',
12381238
'editor',
12391239
'el',
1240-
'elapsed (us)',
1241-
'elapsed(us)',
12421240
'elapsed-time',
1241+
'elapsed-us',
12431242
'element-class',
12441243
'element-properties',
12451244
'element-states',
@@ -2256,10 +2255,10 @@ export const knownContextValues = new Set([
22562255
'masonry-track',
22572256
'masonry-track-end',
22582257
'masonry-track-start',
2258+
'match-attempts',
22592259
'match-case',
2260+
'match-count',
22602261
'match-whole-word',
2261-
'match_attempts',
2262-
'match_count',
22632262
'matched-address-item',
22642263
'math',
22652264
'math-depth',
@@ -2770,7 +2769,7 @@ export const knownContextValues = new Set([
27702769
'refresh-watch-expressions',
27712770
'regular-breakpoint',
27722771
'regular-expression',
2773-
'reject_percentage',
2772+
'reject-percentage',
27742773
'release-note',
27752774
'release-notes',
27762775
'reload-required',
@@ -3312,7 +3311,7 @@ export const knownContextValues = new Set([
33123311
'style-attribute',
33133312
'style-properties',
33143313
'style-sheet-header',
3315-
'style_sheet_id',
3314+
'style-sheet-id',
33163315
'styles',
33173316
'styles-metrics',
33183317
'styles-pane-css-changes',

test/e2e/helpers/performance-helpers.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -289,13 +289,13 @@ export async function navigateToSelectorStatsTab() {
289289
veImpression(
290290
'Pane', 'selector-stats',
291291
[
292-
veImpression('TableHeader', 'elapsed(us)'),
293-
veImpression('TableHeader', 'match_attempts'),
294-
veImpression('TableHeader', 'match_count'),
295-
veImpression('TableHeader', 'reject_percentage'),
292+
veImpression('TableHeader', 'elapsed-us'),
293+
veImpression('TableHeader', 'match-attempts'),
294+
veImpression('TableHeader', 'match-count'),
295+
veImpression('TableHeader', 'reject-percentage'),
296296
veImpression('TableHeader', 'selector'),
297-
veImpression('TableHeader', 'style_sheet_id'),
298-
veImpression('TableRow', undefined, [veImpression('TableCell')]),
297+
veImpression('TableHeader', 'style-sheet-id'),
298+
veImpression('TableRow', undefined, [veImpression('TableCell', 'elapsed-us')]),
299299
]),
300300
],
301301
'Panel: timeline > Section: timeline.flame-chart-view');

0 commit comments

Comments
 (0)