Skip to content

Commit 96f160e

Browse files
Kuba MikulskiDevtools-frontend LUCI CQ
authored andcommitted
[TDR] Remove TODOs linked to issue 40910554.
This is an AI-generated dead TODOs removal. Please review to ensure this change is correct. This CL was verified by the CL owner before sending it out. See http://go/dead-todo-removal-agent for more info. The TODO requested a refactoring to remove circular calls, which was completed by removing the registerTrackForLevel method from the CompatibilityTracksAppender class, as confirmed by the bug's resolution and analysis of the current source code. Change-Id: I64cd40d417195e6e5e3d80b61640d5d88e2a2373 Bug: 40910554 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7231687 Reviewed-by: Benedikt Meurer <[email protected]> Reviewed-by: Jack Franklin <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]>
1 parent 523c513 commit 96f160e

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

front_end/panels/timeline/CompatibilityTracksAppender.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,6 @@ export class CompatibilityTracksAppender {
510510
* @returns the index of the event in all events to be rendered in the flamechart.
511511
*/
512512
appendEventAtLevel(event: Trace.Types.Events.Event, level: number, appender: TrackAppender): number {
513-
// TODO(crbug.com/1442454) Figure out how to avoid the circular calls.
514513
this.#trackForLevel.set(level, appender);
515514
const index = this.#entryData.length;
516515
this.#entryData.push(event);

0 commit comments

Comments
 (0)