Convert no-underscored-properties to TypeScript

Bug: chromium:397586315
Change-Id: Ie27d1c96b4b40ccdef26a5e8271937e522dc125b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6441162
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Auto-Submit: Mathias Bynens <[email protected]>

Author: mathiasbynens

scripts/eslint_rules/lib/no-underscored-properties.js renamed to scripts/eslint_rules/lib/no-underscored-properties.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-'use strict';
+import {createRule} from './tsUtils.ts';
 
 function hasPublicMethodForUnderscoredProperty(node) {
   const nodeName = node.key.name;
@@ -15,6 +15,7 @@ function hasPublicMethodForUnderscoredProperty(node) {
   });
   return hasMethodDeclaredWithNonUnderscoredName;
 }
+
 function checkNodeForUnderscoredProperties(context, node, typeOfNode) {
   if (node.key.type !== 'Identifier') {
     return;
@@ -33,23 +34,25 @@ function checkNodeForUnderscoredProperties(context, node, typeOfNode) {
   context.report({
     node,
     data: {propName: nodeName, typeOfNode},
-    message: 'Class {{typeOfNode}} {{propName}} should not begin with an underscore.'
+    messageId: 'underscorePrefix',
   });
 }
-/**
- * @type {import('eslint').Rule.RuleModule}
- */
-module.exports = {
+
+export default createRule({
+  name: 'no-underscored-properties',
   meta: {
     type: 'problem',
-
     docs: {
       description: 'enforce that class properties and methods do not start with an underscore',
       category: 'Possible Errors',
     },
+    messages: {
+      underscorePrefix: 'Class {{typeOfNode}} {{propName}} should not begin with an underscore.',
+    },
     fixable: 'code',
     schema: []  // no options
   },
+  defaultOptions: [],
   create: function(context) {
     return {
       PropertyDefinition(node) {
@@ -64,4 +67,4 @@ module.exports = {
       }
     };
   }
-};
+});

scripts/eslint_rules/tests/no-underscored-properties.test.js renamed to scripts/eslint_rules/tests/no-underscored-properties.test.ts

@@ -1,10 +1,10 @@
 // Copyright 2020 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
-const rule = require('../lib/no-underscored-properties.js');
 
-const {RuleTester} = require('./utils/utils.js');
+import rule from '../lib/no-underscored-properties.ts';
+
+import {RuleTester} from './utils/tsUtils.ts';
 
 new RuleTester().run('no-underscored-properties', rule, {
   valid: [
@@ -53,7 +53,7 @@ new RuleTester().run('no-underscored-properties', rule, {
         private _foo: string = '';
       }`,
       errors: [
-        {message: 'Class property _foo should not begin with an underscore.'},
+        {messageId: 'underscorePrefix'},
       ],
     },
     {
@@ -62,7 +62,7 @@ new RuleTester().run('no-underscored-properties', rule, {
         public _foo: string = '';
       }`,
       errors: [
-        {message: 'Class property _foo should not begin with an underscore.'},
+        {messageId: 'underscorePrefix'},
       ],
     },
     {
@@ -71,7 +71,7 @@ new RuleTester().run('no-underscored-properties', rule, {
         _foo: string = '';
       }`,
       errors: [
-        {message: 'Class property _foo should not begin with an underscore.'},
+        {messageId: 'underscorePrefix'},
       ],
     },
     {
@@ -81,7 +81,7 @@ new RuleTester().run('no-underscored-properties', rule, {
         }
       }`,
       errors: [
-        {message: 'Class method _foo should not begin with an underscore.'},
+        {messageId: 'underscorePrefix'},
       ],
     },
     {
@@ -92,7 +92,7 @@ new RuleTester().run('no-underscored-properties', rule, {
         }
       }`,
       errors: [
-        {message: 'Class method _foo should not begin with an underscore.'},
+        {messageId: 'underscorePrefix'},
       ],
     },
   ],