[test] Don't assert in recording

If the assertion is wrong the test will timeout instead of failing.
Which will trigger a afterAll hook to fail due to us using
console.error when a run fails.

Bug: none
Change-Id: I7aac1487086ae22fe158370a2fa30b541f97eb35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6258002
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

test/conductor/hooks.ts

@@ -211,10 +211,11 @@ async function throttleCPUIfRequired(page: puppeteer.Page): Promise<void> {
     return;
   }
   console.log(`Throttling CPU: ${envThrottleRate}x slowdown`);
-  const client = await page.target().createCDPSession();
+  const client = await page.createCDPSession();
   await client.send('Emulation.setCPUThrottlingRate', {
     rate: envThrottleRate,
   });
+  await client.detach();
 }
 
 export async function reloadDevTools(options?: DevToolsFrontendReloadOptions) {

test/conductor/target_tab.ts

@@ -29,7 +29,7 @@ export class TargetTab {
 
   async reset(): Promise<void> {
     await loadEmptyPageAndWaitForContent(this.page);
-    const client = await this.page.target().createCDPSession();
+    const client = await this.page.createCDPSession();
     await client.send('ServiceWorker.enable');
     await client.send('ServiceWorker.stopAllWorkers');
     await client.detach();

test/e2e/layers/layers_test.ts

@@ -50,21 +50,24 @@ describe('The Layers Panel', () => {
     await waitFor('[aria-label="layers"]:not([test-current-url=""])');
     assert.strictEqual(await getCurrentUrl(), `${getResourcesPath()}/${targetUrl}`);
 
-    const session = await target.target().createCDPSession();
-    await session.send('Network.emulateNetworkConditions', {
-      offline: true,
-      latency: 0,
-      downloadThroughput: 0,
-      uploadThroughput: 0,
-    });
-    await target.reload({waitUntil: 'networkidle0'});
-    await target.bringToFront();
-    await raf(target);
-    await frontend.bringToFront();
-    await waitFor(`[aria-label="layers"]:not([test-current-url="${targetUrl}"])`);
-    await waitForFunction(async () => {
-      return (await getCurrentUrl()) === 'chrome-error://chromewebdata/';
-    });
-    await session.detach();
+    const session = await target.createCDPSession();
+    try {
+      await session.send('Network.emulateNetworkConditions', {
+        offline: true,
+        latency: 0,
+        downloadThroughput: 0,
+        uploadThroughput: 0,
+      });
+      await target.reload({waitUntil: 'networkidle0'});
+      await target.bringToFront();
+      await raf(target);
+      await frontend.bringToFront();
+      await waitFor(`[aria-label="layers"]:not([test-current-url="${targetUrl}"])`);
+      await waitForFunction(async () => {
+        return (await getCurrentUrl()) === 'chrome-error://chromewebdata/';
+      });
+    } finally {
+      await session.detach();
+    }
   });
 });

test/e2e/recorder/replay_test.ts

@@ -656,6 +656,7 @@ describe('Recorder', function() {
   });
 
   it('should be able to navigate to a prerendered page', async () => {
+    const {target} = getBrowserAndPages();
     await setupRecorderWithScriptAndReplay({
       title: 'Test Recording',
       steps: [
@@ -674,12 +675,14 @@ describe('Recorder', function() {
               url: `${getResourcesPath()}/recorder/prerendered.html`,
             },
           ],
-        },
-        {
-          type: 'waitForExpression' as StepType.WaitForExpression,
-          expression: 'document.querySelector("div").innerText === "true"',
-        },
+        }
       ],
+
     });
+    const isPrerendered = await target.evaluate(() => {
+      return document.querySelector('div')!.innerText === 'true';
+    });
+
+    assert.isTrue(isPrerendered);
   });
 });