Prerender2Fallback: Show only representative preloading attempt of pipeline

This CL merges preloading attempts in the same pipeline and shows only
representatives in PreloadingGrid.

Further UI change follows in the next CL.

Bug: 364509578
Change-Id: I18d7451ae4e494fa6298551bc78c080e020fb25e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6068032
Reviewed-by: Lingqi Chi <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Ken Okada <[email protected]>

Author: kenoss

front_end/core/sdk/PreloadingModel.test.ts

@@ -83,7 +83,7 @@ describeWithMockConnection('PreloadingModel', () => {
         },
       },
     ]);
-    assert.deepEqual(model.getPreloadingAttempts(null), [
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
       {
         id: `${loaderId}:Prefetch:https://example.com/subresource.js:undefined`,
         value: {
@@ -189,7 +189,7 @@ describeWithMockConnection('PreloadingModel', () => {
         },
       },
     ]);
-    assert.deepEqual(model.getPreloadingAttempts(null), [
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
       {
         id: `${loaderId}:Prefetch:https://example.com/subresource.js:undefined`,
         value: {
@@ -275,7 +275,7 @@ describeWithMockConnection('PreloadingModel', () => {
         },
       },
     ]);
-    assert.deepEqual(model.getPreloadingAttempts(null), [
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
       {
         id: `${loaderId}:Prerender:https://example.com/page.html:undefined`,
         value: {
@@ -336,7 +336,7 @@ describeWithMockConnection('PreloadingModel', () => {
       ],
     });
 
-    assert.deepEqual(model.getPreloadingAttempts(null), [
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
       {
         id: `${loaderId}:Prefetch:https://example.com/subresource.js:undefined`,
         value: {
@@ -364,7 +364,7 @@ describeWithMockConnection('PreloadingModel', () => {
     assert.exists(model);
 
     assert.deepEqual(model.getAllRuleSets(), []);
-    assert.deepEqual(model.getPreloadingAttempts(null), []);
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), []);
 
     let loaderId = getMainFrame(target).loaderId as Protocol.Network.LoaderId;
 
@@ -471,7 +471,7 @@ describeWithMockConnection('PreloadingModel', () => {
         },
       },
     ]);
-    assert.deepEqual(model.getPreloadingAttempts(null), [
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
       {
         id: `${loaderId}:Prefetch:https://example.com/subresource2.js:undefined`,
         value: {
@@ -498,7 +498,7 @@ describeWithMockConnection('PreloadingModel', () => {
     assert.exists(model);
 
     assert.deepEqual(model.getAllRuleSets(), []);
-    assert.deepEqual(model.getPreloadingAttempts(null), []);
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), []);
 
     const loaderId = getMainFrame(target).loaderId as Protocol.Network.LoaderId;
 
@@ -580,7 +580,7 @@ describeWithMockConnection('PreloadingModel', () => {
       requestId: 'requestId:2',
     });
 
-    assert.deepEqual(model.getPreloadingAttempts(null), [
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
       {
         id: `${loaderId}:Prefetch:https://example.com/subresource12.js:undefined`,
         value: {
@@ -617,7 +617,7 @@ describeWithMockConnection('PreloadingModel', () => {
       },
     ]);
 
-    assert.deepEqual(model.getPreloadingAttempts('ruleSetId:1' as Protocol.Preload.RuleSetId), [
+    assert.deepEqual(model.getRepresentativePreloadingAttempts('ruleSetId:1' as Protocol.Preload.RuleSetId), [
       {
         id: `${loaderId}:Prefetch:https://example.com/subresource12.js:undefined`,
         value: {
@@ -637,7 +637,7 @@ describeWithMockConnection('PreloadingModel', () => {
       },
     ]);
 
-    assert.deepEqual(model.getPreloadingAttempts('ruleSetId:2' as Protocol.Preload.RuleSetId), [
+    assert.deepEqual(model.getRepresentativePreloadingAttempts('ruleSetId:2' as Protocol.Preload.RuleSetId), [
       {
         id: `${loaderId}:Prefetch:https://example.com/subresource12.js:undefined`,
         value: {
@@ -674,4 +674,202 @@ describeWithMockConnection('PreloadingModel', () => {
       },
     ]);
   });
+
+  it('regards attempts with strongest action as representative', async () => {
+    const target = createTarget();
+    const model = target.model(SDK.PreloadingModel.PreloadingModel);
+    assert.exists(model);
+
+    assert.deepEqual(model.getAllRuleSets(), []);
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), []);
+
+    const loaderId = getMainFrame(target).loaderId as Protocol.Network.LoaderId;
+
+    dispatchEvent(target, 'Preload.ruleSetUpdated', {
+      ruleSet: {
+        id: 'ruleSetId:1',
+        loaderId,
+        sourceText: `
+{
+  "prerender": [
+    {
+      "source": "list",
+      "urls": ["/prerendered.html"]
+    }
+  ]
+}
+`,
+      },
+    });
+    dispatchEvent(target, 'Preload.preloadingAttemptSourcesUpdated', {
+      loaderId,
+      preloadingAttemptSources: [
+        {
+          action: Protocol.Preload.SpeculationAction.Prerender,
+          key: {
+            loaderId,
+            action: Protocol.Preload.SpeculationAction.Prerender,
+            url: 'https://example.com/prerendered.html',
+          },
+          ruleSetIds: ['ruleSetId:1'],
+          nodeIds: [1],
+        },
+      ],
+    });
+
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
+      {
+        id: `${loaderId}:Prerender:https://example.com/prerendered.html:undefined`,
+        value: {
+          action: Protocol.Preload.SpeculationAction.Prerender,
+          key: {
+            loaderId,
+            action: Protocol.Preload.SpeculationAction.Prerender,
+            url: 'https://example.com/prerendered.html' as Platform.DevToolsPath.UrlString,
+          },
+          pipelineId: null,
+          status: SDK.PreloadingModel.PreloadingStatus.NOT_TRIGGERED,
+          prerenderStatus: null,
+          disallowedMojoInterface: null,
+          mismatchedHeaders: null,
+          ruleSetIds: ['ruleSetId:1'] as Protocol.Preload.RuleSetId[],
+          nodeIds: [1] as Protocol.DOM.BackendNodeId[],
+        },
+      },
+    ]);
+
+    dispatchEvent(target, 'Preload.prefetchStatusUpdated', {
+      key: {
+        loaderId,
+        action: Protocol.Preload.SpeculationAction.Prefetch,
+        url: 'https://example.com/prerendered.html',
+      },
+      pipelineId: 'pipelineId:1',
+      status: SDK.PreloadingModel.PreloadingStatus.RUNNING,
+      requestId: 'requestId:1',
+    });
+
+    // Here, we get two different attemtps, which should sit in the same pipeline actually.
+    // It is because
+    //
+    // - The `NOT_TRIGGERED` entry is synthesized from
+    //   `Preload.preloadingAttemptSourcesUpdated` event.
+    // - It is associated with the following entry for *prerender*, not prefetch.
+    //
+    // We admit the phenomenon as prefetch and prerender are triggered simultaneously and we don't
+    // expect the duration is very short that these entries are shown.
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
+      {
+        id: `${loaderId}:Prerender:https://example.com/prerendered.html:undefined`,
+        value: {
+          action: Protocol.Preload.SpeculationAction.Prerender,
+          key: {
+            loaderId,
+            action: Protocol.Preload.SpeculationAction.Prerender,
+            url: 'https://example.com/prerendered.html' as Platform.DevToolsPath.UrlString,
+          },
+          pipelineId: null,
+          status: SDK.PreloadingModel.PreloadingStatus.NOT_TRIGGERED,
+          prerenderStatus: null,
+          disallowedMojoInterface: null,
+          mismatchedHeaders: null,
+          ruleSetIds: ['ruleSetId:1'] as Protocol.Preload.RuleSetId[],
+          nodeIds: [1] as Protocol.DOM.BackendNodeId[],
+        },
+      },
+      {
+        id: `${loaderId}:Prefetch:https://example.com/prerendered.html:undefined`,
+        value: {
+          action: Protocol.Preload.SpeculationAction.Prefetch,
+          key: {
+            loaderId,
+            action: Protocol.Preload.SpeculationAction.Prefetch,
+            url: 'https://example.com/prerendered.html' as Platform.DevToolsPath.UrlString,
+          },
+          pipelineId: 'pipelineId:1' as Protocol.Preload.PreloadPipelineId,
+          status: SDK.PreloadingModel.PreloadingStatus.RUNNING,
+          prefetchStatus: null,
+          requestId: 'requestId:1' as Protocol.Network.RequestId,
+          ruleSetIds: [] as Protocol.Preload.RuleSetId[],
+          nodeIds: [] as Protocol.DOM.BackendNodeId[],
+        },
+      },
+    ]);
+
+    dispatchEvent(target, 'Preload.prerenderStatusUpdated', {
+      key: {
+        loaderId,
+        action: Protocol.Preload.SpeculationAction.Prerender,
+        url: 'https://example.com/prerendered.html',
+      },
+      pipelineId: 'pipelineId:1',
+      status: SDK.PreloadingModel.PreloadingStatus.RUNNING,
+    });
+
+    // Converges to an entry.
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
+      {
+        id: `${loaderId}:Prerender:https://example.com/prerendered.html:undefined`,
+        value: {
+          action: Protocol.Preload.SpeculationAction.Prerender,
+          key: {
+            loaderId,
+            action: Protocol.Preload.SpeculationAction.Prerender,
+            url: 'https://example.com/prerendered.html' as Platform.DevToolsPath.UrlString,
+          },
+          pipelineId: 'pipelineId:1' as Protocol.Preload.PreloadPipelineId,
+          status: SDK.PreloadingModel.PreloadingStatus.RUNNING,
+          prerenderStatus: null,
+          disallowedMojoInterface: null,
+          mismatchedHeaders: null,
+          ruleSetIds: ['ruleSetId:1'] as Protocol.Preload.RuleSetId[],
+          nodeIds: [1] as Protocol.DOM.BackendNodeId[],
+        },
+      },
+    ]);
+
+    dispatchEvent(target, 'Preload.prefetchStatusUpdated', {
+      key: {
+        loaderId,
+        action: Protocol.Preload.SpeculationAction.Prefetch,
+        url: 'https://example.com/prerendered.html',
+      },
+      pipelineId: 'pipelineId:1',
+      status: SDK.PreloadingModel.PreloadingStatus.SUCCESS,
+      requestId: 'requestId:1',
+    });
+    dispatchEvent(target, 'Preload.prerenderStatusUpdated', {
+      key: {
+        loaderId,
+        action: Protocol.Preload.SpeculationAction.Prerender,
+        url: 'https://example.com/prerendered.html',
+      },
+      pipelineId: 'pipelineId:1',
+      status: SDK.PreloadingModel.PreloadingStatus.FAILURE,
+      prerenderStatus: Protocol.Preload.PrerenderFinalStatus.MojoBinderPolicy,
+      disallowedMojoInterface: 'device.mojom.GamepadMonitor',
+    });
+
+    // The prerender is the representative of the pipeline even if it failed.
+    assert.deepEqual(model.getRepresentativePreloadingAttempts(null), [
+      {
+        id: `${loaderId}:Prerender:https://example.com/prerendered.html:undefined`,
+        value: {
+          action: Protocol.Preload.SpeculationAction.Prerender,
+          key: {
+            loaderId,
+            action: Protocol.Preload.SpeculationAction.Prerender,
+            url: 'https://example.com/prerendered.html' as Platform.DevToolsPath.UrlString,
+          },
+          pipelineId: 'pipelineId:1' as Protocol.Preload.PreloadPipelineId,
+          status: SDK.PreloadingModel.PreloadingStatus.FAILURE,
+          prerenderStatus: Protocol.Preload.PrerenderFinalStatus.MojoBinderPolicy,
+          disallowedMojoInterface: 'device.mojom.GamepadMonitor',
+          mismatchedHeaders: null,
+          ruleSetIds: ['ruleSetId:1'] as Protocol.Preload.RuleSetId[],
+          nodeIds: [1] as Protocol.DOM.BackendNodeId[],
+        },
+      },
+    ]);
+  });
 });