[AI Assistance] Remove unnecessary rpcIds

Only steps coming from the LLM should have these ids

Bug: none
Change-Id: Icc47826c4403d58fda6a7096383a652fdc084cd3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6063881
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>

Author: Lightning00Blade

front_end/panels/freestyler/AiAgent.ts

@@ -65,15 +65,13 @@ export interface SideEffectResponse {
   type: ResponseType.SIDE_EFFECT;
   code: string;
   confirm: (confirm: boolean) => void;
-  rpcId?: number;
 }
 
 export interface ActionResponse {
   type: ResponseType.ACTION;
   code: string;
   output: string;
   canceled: boolean;
-  rpcId?: number;
 }
 
 export interface QueryResponse {
@@ -303,7 +301,7 @@ export abstract class AiAgent<T> {
     return request;
   }
 
-  handleAction(action: string, rpcId?: number): AsyncGenerator<SideEffectResponse, ActionResponse, void>;
+  handleAction(action: string): AsyncGenerator<SideEffectResponse, ActionResponse, void>;
   handleAction(): never {
     throw new Error('Unexpected action found');
   }
@@ -557,7 +555,7 @@ STOP`;
       }
 
       if (action) {
-        const result = yield* this.handleAction(action, rpcId);
+        const result = yield* this.handleAction(action);
         this.#addHistory(result);
         query = `OBSERVATION: ${result.output}`;
         // Capture history state for the next iteration query.

front_end/panels/freestyler/FreestylerAgent.test.ts

@@ -1154,7 +1154,6 @@ ANSWER: this is the answer`,
           code: 'console.log(\'hello\');',
           output: 'hello',
           canceled: false,
-          rpcId: undefined,
         },
         {
           type: Freestyler.ResponseType.QUERYING,
@@ -1342,7 +1341,6 @@ ANSWER: this is the answer`,
           code: 'console.log(\'test\')',
           output: 'undefined',
           canceled: false,
-          rpcId: undefined,
         },
         {
           type: Freestyler.ResponseType.QUERYING,

front_end/panels/freestyler/FreestylerAgent.ts

@@ -580,16 +580,14 @@ export class FreestylerAgent extends AiAgent<SDK.DOMModel.DOMNode> {
     return output.trim();
   }
 
-  override async *
-      handleAction(action: string, rpcId?: number): AsyncGenerator<SideEffectResponse, ActionResponse, void> {
+  override async * handleAction(action: string): AsyncGenerator<SideEffectResponse, ActionResponse, void> {
     debugLog(`Action to execute: ${action}`);
     if (this.executionMode === Root.Runtime.HostConfigFreestylerExecutionMode.NO_SCRIPTS) {
       return {
         type: ResponseType.ACTION,
         code: action,
         output: 'Error: JavaScript execution is currently disabled.',
         canceled: true,
-        rpcId,
       };
     }
 
@@ -605,7 +603,6 @@ export class FreestylerAgent extends AiAgent<SDK.DOMModel.DOMNode> {
             code: action,
             output: 'Error: JavaScript execution that modifies the page is currently disabled.',
             canceled: true,
-            rpcId,
           };
         }
 
@@ -621,7 +618,6 @@ export class FreestylerAgent extends AiAgent<SDK.DOMModel.DOMNode> {
                          Host.UserMetrics.Action.AiAssistanceSideEffectRejected,
             );
           },
-          rpcId,
         };
 
         result = await this.#generateObservation(action, {
@@ -634,7 +630,6 @@ export class FreestylerAgent extends AiAgent<SDK.DOMModel.DOMNode> {
         code: action,
         output: result.observation,
         canceled: result.canceled,
-        rpcId,
       };
     } finally {
       await scope.uninstall();