Skip to content

Commit 9d92aac

Browse files
Connor ClarkDevtools-frontend LUCI CQ
authored andcommitted
Call res.end() when snapshot file is missing
This accidentally made this request hang forever if the snapshot file does not exist. Bug: 434252192 Change-Id: I402043c95ba4331a3c349e7d94ade0ef0339f247 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6961120 Reviewed-by: Paul Irish <[email protected]> Auto-Submit: Connor Clark <[email protected]> Commit-Queue: Paul Irish <[email protected]>
1 parent d45a582 commit 9d92aac

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/unit/karma.conf.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ function snapshotTesterFactory() {
291291
const snapshotPath = path.join(SOURCE_ROOT, parsedUrl.query.snapshotPath);
292292
if (!fs.existsSync(snapshotPath)) {
293293
res.writeHead(404);
294+
res.end();
294295
return;
295296
}
296297

0 commit comments

Comments
 (0)