Update name of the setting for AI code completion

This CL also updates the string for opt-in and setting to include "the currently inspected CSS"

Bug: 425865106
Change-Id: I00b3f8ff8d37f106c7013f3fa0506316764b6c87
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6826465
Auto-Submit: Samiya Caur <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>

Author: Samiya Caur

front_end/panels/common/AiCodeCompletionTeaser.test.ts

@@ -35,7 +35,7 @@ describeWithEnvironment('AiCodeCompletionTeaser', () => {
 
   afterEach(() => {
     Common.Settings.Settings.instance().settingForTest('ai-code-completion-teaser-dismissed').set(false);
-    Common.Settings.Settings.instance().settingForTest('ai-code-completion-fre-completed').set(false);
+    Common.Settings.Settings.instance().settingForTest('ai-code-completion-enabled').set(false);
     sinon.restore();
   });
 

front_end/panels/common/AiCodeCompletionTeaser.ts

@@ -60,12 +60,12 @@ const UIStringsNotTranslate = {
    * @description Second disclaimer item text for the fre dialog.
    */
   freDisclaimerTextPrivacy:
-      'To generate code suggestions, your console input, the history of your current console session, and the contents of the currently open file are shared with Google. This data may be seen by human reviewers to improve this feature.',
+      'To generate code suggestions, your console input, the history of your current console session, the currently inspected CSS, and the contents of the currently open file are shared with Google. This data may be seen by human reviewers to improve this feature.',
   /**
    * @description Second disclaimer item text for the fre dialog when enterprise logging is off.
    */
   freDisclaimerTextPrivacyNoLogging:
-      'To generate code suggestions, your console input, the history of your current console session, and the contents of the currently open file are shared with Google. This data will not be used to improve Google’s AI models. Your organization may change these settings at any time.',
+      'To generate code suggestions, your console input, the history of your current console session, the currently inspected CSS, and the contents of the currently open file are shared with Google. This data will not be used to improve Google’s AI models. Your organization may change these settings at any time.',
   /**
    * @description Third disclaimer item text for the fre dialog.
    */
@@ -124,7 +124,7 @@ export class AiCodeCompletionTeaser extends UI.Widget.Widget {
 
   // Whether the user completed first run experience dialog or not.
   #aiCodeCompletionFreCompletedSetting =
-      Common.Settings.Settings.instance().createSetting('ai-code-completion-fre-completed', false);
+      Common.Settings.Settings.instance().createSetting('ai-code-completion-enabled', false);
   // Whether the user dismissed the teaser or not.
   #aiCodeCompletionTeaserDismissedSetting =
       Common.Settings.Settings.instance().createSetting('ai-code-completion-teaser-dismissed', false);

front_end/panels/console/ConsolePrompt.test.ts

@@ -52,7 +52,7 @@ describeWithMockConnection('ConsoleContextSelector', () => {
     UI.Context.Context.instance().setFlavor(SDK.RuntimeModel.ExecutionContext, targetContext);
     evaluateOnTarget = sinon.stub(target.runtimeAgent(), 'invoke_evaluate');
 
-    Common.Settings.Settings.instance().createSetting('ai-code-completion-fre-completed', false);
+    Common.Settings.Settings.instance().createSetting('ai-code-completion-enabled', false);
   });
 
   afterEach(async () => {
@@ -157,7 +157,7 @@ describeWithMockConnection('ConsoleContextSelector', () => {
 
   it('updates aiCodeCompletion when FRE setting is updated', () => {
     assert.isUndefined(consolePrompt['aiCodeCompletion']);
-    const setting = Common.Settings.Settings.instance().settingForTest('ai-code-completion-fre-completed');
+    const setting = Common.Settings.Settings.instance().settingForTest('ai-code-completion-enabled');
     setting.set(true);
     assert.exists(consolePrompt['aiCodeCompletion']);
     setting.set(false);
@@ -169,7 +169,7 @@ describeWithMockConnection('ConsoleContextSelector', () => {
       completeCode: Promise.resolve(null),
     });
     consolePrompt.setAidaClientForTest(mockAidaClient);
-    Common.Settings.Settings.instance().settingForTest('ai-code-completion-fre-completed').set(true);
+    Common.Settings.Settings.instance().settingForTest('ai-code-completion-enabled').set(true);
     const onTextChangedSpy = sinon.spy(
         consolePrompt['aiCodeCompletion'] as AiCodeCompletion.AiCodeCompletion.AiCodeCompletion, 'onTextChanged');
     const consoleModel = target.model(SDK.ConsoleModel.ConsoleModel);

front_end/panels/console/ConsolePrompt.ts

@@ -75,7 +75,7 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
   private placeholderCompartment: CodeMirror.Compartment = new CodeMirror.Compartment();
   private teaserContainer?: HTMLDivElement;
   private aiCodeCompletionSetting =
-      Common.Settings.Settings.instance().createSetting('ai-code-completion-fre-completed', false);
+      Common.Settings.Settings.instance().createSetting('ai-code-completion-enabled', false);
   private aiCodeCompletionCitations?: Host.AidaClient.Citation[] = [];
 
   #getJavaScriptCompletionExtensions(): CodeMirror.Extension {

front_end/panels/console/ConsoleView.ts

@@ -333,7 +333,7 @@ export class ConsoleView extends UI.Widget.VBox implements
   #isDetached = false;
   #onIssuesCountUpdateBound = this.#onIssuesCountUpdate.bind(this);
   private aiCodeCompletionSetting =
-      Common.Settings.Settings.instance().createSetting('ai-code-completion-fre-completed', false);
+      Common.Settings.Settings.instance().createSetting('ai-code-completion-enabled', false);
   private aiCodeCompletionSummaryToolbarContainer?: HTMLElement;
   private aiCodeCompletionSummaryToolbar?: AiCodeCompletionSummaryToolbar;
 

front_end/panels/settings/AISettingsTab.test.ts

@@ -62,7 +62,7 @@ describeWithEnvironment('AISettingsTab', () => {
     Common.Settings.moduleSetting('console-insights-enabled').set(false);
     Common.Settings.moduleSetting('ai-assistance-enabled').set(true);
     Common.Settings.moduleSetting('ai-annotations-enabled').set(true);
-    Common.Settings.moduleSetting('ai-code-completion-fre-completed').set(false);
+    Common.Settings.moduleSetting('ai-code-completion-enabled').set(false);
 
     view = new Settings.AISettingsTab.AISettingsTab();
     renderElementIntoDOM(view);
@@ -85,7 +85,7 @@ describeWithEnvironment('AISettingsTab', () => {
     Common.Settings.moduleSetting('console-insights-enabled').set(true);
     Common.Settings.moduleSetting('ai-assistance-enabled').set(true);
     Common.Settings.moduleSetting('ai-annotations-enabled').set(true);
-    Common.Settings.moduleSetting('ai-code-completion-fre-completed').set(true);
+    Common.Settings.moduleSetting('ai-code-completion-enabled').set(true);
 
     view = new Settings.AISettingsTab.AISettingsTab();
     renderElementIntoDOM(view);
@@ -116,7 +116,7 @@ describeWithEnvironment('AISettingsTab', () => {
     Common.Settings.moduleSetting('console-insights-enabled').set(true);
     Common.Settings.moduleSetting('ai-assistance-enabled').set(true);
     Common.Settings.moduleSetting('ai-annotations-enabled').set(true);
-    Common.Settings.moduleSetting('ai-code-completion-fre-completed').set(true);
+    Common.Settings.moduleSetting('ai-code-completion-enabled').set(true);
     updateHostConfig({
       aidaAvailability: {
         enabled: true,

front_end/panels/settings/AISettingsTab.ts

@@ -174,12 +174,12 @@ const UIStrings = {
    * @description Explainer for which data is being sent for the 'Code suggestions' feature
    */
   codeSuggestionsSendData:
-      'To generate code suggestions, your console input, the history of your current console session, and the contents of the currently open file are shared with Google. This data may be seen by human reviewers to improve this feature.',
+      'To generate code suggestions, your console input, the history of your current console session, the currently inspected CSS, and the contents of the currently open file are shared with Google. This data may be seen by human reviewers to improve this feature.',
   /**
    * @description Explainer for which data is being sent for the 'Code suggestions' feature when logging is not enabled
    */
   codeSuggestionsSendDataNoLogging:
-      'To generate code suggestions, your console input, the history of your current console session, and the contents of the currently open file are shared with Google. This data will not be used to improve Google’s AI models.',
+      'To generate code suggestions, your console input, the history of your current console session, the currently inspected CSS, and the contents of the currently open file are shared with Google. This data will not be used to improve Google’s AI models.',
   /**
    * @description Label for a link to the terms of service
    */
@@ -256,7 +256,7 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen
     if (Root.Runtime.hostConfig.devToolsAiCodeCompletion?.enabled) {
       // Get an existing setting or, if it does not exist, create a new one.
       this.#aiCodeCompletionSetting =
-          Common.Settings.Settings.instance().createSetting('ai-code-completion-fre-completed', false);
+          Common.Settings.Settings.instance().createSetting('ai-code-completion-enabled', false);
     }
 
     this.#boundOnAidaAvailabilityChange = this.#onAidaAvailabilityChange.bind(this);

front_end/testing/EnvironmentHelpers.ts

@@ -301,8 +301,7 @@ export async function initializeGlobalVars({reset = true} = {}) {
         Common.Settings.SettingCategory.AI, 'ai-assistance-patching-fre-completed', false,
         Common.Settings.SettingType.BOOLEAN),
     createSettingValue(
-        Common.Settings.SettingCategory.AI, 'ai-code-completion-fre-completed', false,
-        Common.Settings.SettingType.BOOLEAN),
+        Common.Settings.SettingCategory.AI, 'ai-code-completion-enabled', false, Common.Settings.SettingType.BOOLEAN),
     createSettingValue(
         Common.Settings.SettingCategory.MOBILE, 'emulation.show-device-outline', false,
         Common.Settings.SettingType.BOOLEAN),

front_end/ui/visual_logging/KnownContextValues.ts

@@ -344,7 +344,7 @@ export const knownContextValues = new Set([
   'ai-assistance-history-images',
   'ai-assistance-patching-fre-completed',
   'ai-assistance-patching-selected-project-id',
-  'ai-code-completion-fre-completed',
+  'ai-code-completion-enabled',
   'ai-code-completion-teaser-dismissed',
   'ai-code-completion-teaser.dismiss',
   'ai-code-completion-teaser.fre',