Skip to content

Commit 9f00325

Browse files
pfaffeDevtools-frontend LUCI CQ
authored andcommitted
Update tooltip on pattern priority arrows
Also fix settings update when changing the order. Bug: 452856536 Change-Id: Iecd382ed24082f8ff1185bcc63b3be47b9654892 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7124404 Reviewed-by: Eric Leese <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]>
1 parent 2afc707 commit 9f00325

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

front_end/core/sdk/NetworkManager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1812,7 +1812,7 @@ export class RequestConditions extends Common.ObjectWrapper.ObjectWrapper<Reques
18121812
}
18131813

18141814
Platform.ArrayUtilities.swap(this.#conditions, index, index + 1);
1815-
this.dispatchEventToListeners(RequestConditions.Events.REQUEST_CONDITIONS_CHANGED);
1815+
this.#conditionsChanged();
18161816
}
18171817

18181818
increasePriority(condition: RequestCondition): void {
@@ -1822,7 +1822,7 @@ export class RequestConditions extends Common.ObjectWrapper.ObjectWrapper<Reques
18221822
}
18231823

18241824
Platform.ArrayUtilities.swap(this.#conditions, index - 1, index);
1825-
this.dispatchEventToListeners(RequestConditions.Events.REQUEST_CONDITIONS_CHANGED);
1825+
this.#conditionsChanged();
18261826
}
18271827

18281828
delete(condition: RequestCondition): void {

front_end/panels/network/RequestConditionsDrawer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,11 @@ const UIStrings = {
108108
/**
109109
* @description Aria label on a button moving an entry up
110110
*/
111-
increasePriority: 'Increase priority',
111+
increasePriority: 'Move up (higher patterns are checked first)',
112112
/**
113113
* @description Aria label on a button moving an entry down
114114
*/
115-
decreasePriority: 'Decrease priority',
115+
decreasePriority: 'Move down (higher patterns are checked first)',
116116
} as const;
117117
const str_ = i18n.i18n.registerUIStrings('panels/network/RequestConditionsDrawer.ts', UIStrings);
118118
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

0 commit comments

Comments
 (0)