Remove 'autofill-view' experiment

Experiment has been enabled by default for a long time.

Bug: none
Change-Id: I3a1e7756197a438c2257a642fa61c60817c0f0f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387440
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Auto-Submit: Wolfgang Beyer <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>

Author: wolfib

front_end/core/host/UserMetrics.ts

@@ -974,7 +974,6 @@ export enum DevtoolsExperiments {
   'highlight-errors-elements-panel' = 73,
   'use-source-map-scopes' = 76,
   'network-panel-filter-bar-redesign' = 79,
-  'autofill-view' = 82,
   'timeline-show-postmessage-events' = 86,
   'timeline-enhanced-traces' = 90,
   'timeline-compiled-sources' = 91,

front_end/core/root/Runtime.ts

@@ -316,7 +316,6 @@ export const enum ExperimentName {
   HIGHLIGHT_ERRORS_ELEMENTS_PANEL = 'highlight-errors-elements-panel',
   USE_SOURCE_MAP_SCOPES = 'use-source-map-scopes',
   NETWORK_PANEL_FILTER_BAR_REDESIGN = 'network-panel-filter-bar-redesign',
-  AUTOFILL_VIEW = 'autofill-view',
   TIMELINE_SHOW_POST_MESSAGE_EVENTS = 'timeline-show-postmessage-events',
   TIMELINE_DEBUG_MODE = 'timeline-debug-mode',
   TIMELINE_ENHANCED_TRACES = 'timeline-enhanced-traces',

front_end/core/sdk/AutofillModel.test.ts

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Root from '../../core/root/root.js';
 import * as Protocol from '../../generated/protocol.js';
 import {createTarget} from '../../testing/EnvironmentHelpers.js';
 import {describeWithMockConnection} from '../../testing/MockConnection.js';
@@ -12,7 +11,6 @@ import * as SDK from './sdk.js';
 
 describeWithMockConnection('AutofillModel', () => {
   beforeEach(() => {
-    Root.Runtime.experiments.enableForTest(Root.Runtime.ExperimentName.AUTOFILL_VIEW);
     Common.Settings.Settings.instance().createLocalSetting('show-test-addresses-in-autofill-menu-on-event', true);
   });
 

front_end/core/sdk/AutofillModel.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import * as Root from '../../core/root/root.js';
 import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as Host from '../host/host.js';
@@ -142,8 +141,7 @@ export class AutofillModel extends SDKModel<EventTypes> implements ProtocolProxy
   }
 
   enable(): void {
-    if (!Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.AUTOFILL_VIEW) || this.#enabled ||
-        Host.InspectorFrontendHost.isUnderTest()) {
+    if (this.#enabled || Host.InspectorFrontendHost.isUnderTest()) {
       return;
     }
     void this.agent.invoke_enable();

front_end/entrypoints/main/MainImpl.ts

@@ -356,14 +356,6 @@ export class MainImpl {
         'https://crbug.com/1500573',
     );
 
-    Root.Runtime.experiments.register(
-        Root.Runtime.ExperimentName.AUTOFILL_VIEW,
-        'Autofill panel',
-        false,
-        'https://goo.gle/devtools-autofill-panel',
-        'https://crbug.com/329106326',
-    );
-
     Root.Runtime.experiments.register(
         Root.Runtime.ExperimentName.TIMELINE_SHOW_POST_MESSAGE_EVENTS,
         'Performance panel: show postMessage dispatch and handling flows',
@@ -385,7 +377,6 @@ export class MainImpl {
     );
 
     Root.Runtime.experiments.enableExperimentsByDefault([
-      Root.Runtime.ExperimentName.AUTOFILL_VIEW,
       Root.Runtime.ExperimentName.NETWORK_PANEL_FILTER_BAR_REDESIGN,
       Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
       Root.Runtime.ExperimentName.TIMELINE_DIM_UNRELATED_EVENTS,

front_end/models/autofill_manager/AutofillManager.test.ts

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
 import {createTarget} from '../../testing/EnvironmentHelpers.js';
@@ -22,7 +21,6 @@ describeWithMockConnection('AutofillManager', () => {
     model = target.model(SDK.AutofillModel.AutofillModel)!;
     showViewStub = sinon.stub(UI.ViewManager.ViewManager.instance(), 'showView').resolves();
     autofillManager = AutofillManager.AutofillManager.AutofillManager.instance({forceNew: true});
-    Root.Runtime.experiments.enableForTest(Root.Runtime.ExperimentName.AUTOFILL_VIEW);
   });
 
   afterEach(() => {

front_end/models/autofill_manager/AutofillManager.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as UI from '../../ui/legacy/legacy.js';
@@ -44,8 +43,7 @@ export class AutofillManager extends Common.ObjectWrapper.ObjectWrapper<EventTyp
 
   async #addressFormFilled({data}: Common.EventTarget.EventTargetEvent<
                            SDK.AutofillModel.EventTypes[SDK.AutofillModel.Events.ADDRESS_FORM_FILLED]>): Promise<void> {
-    if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.AUTOFILL_VIEW) &&
-        this.#autoOpenViewSetting.get()) {
+    if (this.#autoOpenViewSetting.get()) {
       await UI.ViewManager.ViewManager.instance().showView('autofill-view');
       Host.userMetrics.actionTaken(Host.UserMetrics.Action.AutofillReceivedAndTabAutoOpened);
     } else {

front_end/panels/autofill/AutofillView.test.ts

@@ -99,7 +99,6 @@ describeWithMockConnection('AutofillView', () => {
     const maybeAutofillModel = target.model(SDK.AutofillModel.AutofillModel);
     assert.exists(maybeAutofillModel);
     autofillModel = maybeAutofillModel;
-    Root.Runtime.experiments.enableForTest(Root.Runtime.ExperimentName.AUTOFILL_VIEW);
     showViewStub = sinon.stub(UI.ViewManager.ViewManager.instance(), 'showView').resolves();
     AutofillManager.AutofillManager.AutofillManager.instance({forceNew: true});
   });

front_end/panels/autofill/autofill-meta.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as LegacyWrapper from '../../ui/components/legacy_wrapper/legacy_wrapper.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
@@ -32,7 +31,6 @@ async function loadAutofillModule(): Promise<typeof Autofill> {
 }
 
 UI.ViewManager.registerViewExtension({
-  experiment: Root.Runtime.ExperimentName.AUTOFILL_VIEW,
   location: UI.ViewManager.ViewLocationValues.DRAWER_VIEW,
   id: 'autofill-view',
   title: i18nLazyString(UIStrings.autofill),

front_end/testing/EnvironmentHelpers.ts

@@ -122,7 +122,6 @@ const REGISTERED_EXPERIMENTS = [
   Root.Runtime.ExperimentName.USE_SOURCE_MAP_SCOPES,
   'font-editor',
   Root.Runtime.ExperimentName.NETWORK_PANEL_FILTER_BAR_REDESIGN,
-  Root.Runtime.ExperimentName.AUTOFILL_VIEW,
   Root.Runtime.ExperimentName.TIMELINE_DEBUG_MODE,
   Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE,
   Root.Runtime.ExperimentName.TIMELINE_SHOW_POST_MESSAGE_EVENTS,