Enable crashdumps for CfT in e2e/unit tests on Mac

Example CAS output from patch 12 test crash: https://cas-viewer.appspot.com/projects/chromium-swarm/instances/default_instance/blobs/374bf2bcfafb6c78e181f8b634d6827cdd751eae90bb565db46b054ebfde1b1d/116/tree

Bug: 435279902
Change-Id: I2f5b2a5eb88ce75e57ad46bc895b18f896fa2ae1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6805311
Commit-Queue: Liviu Rau <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>

Author: Liviu Rau

test/e2e_non_hosted/conductor/state-provider.ts

@@ -118,6 +118,7 @@ export class StateProvider {
   }
 
   async closeBrowsers() {
+    this.#settingToBrowser.values().next().value?.copyCrahsDumps();
     await Promise.allSettled([...this.#settingToBrowser.values()].map(async browser => {
       await browser.browser.close();
     }));

test/e2e_non_hosted/shared/browser-helper.ts

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as fs from 'fs';
+import * as os from 'os';
 import * as path from 'path';
 import * as puppeteer from 'puppeteer-core';
 import * as url from 'url';
@@ -24,6 +26,55 @@ export class BrowserWrapper {
   async createBrowserContext() {
     return await this.browser.createBrowserContext();
   }
+
+  copyCrahsDumps() {
+    const crashesPath = this.#getCrashpadDir();
+    if (!fs.existsSync(crashesPath)) {
+      // TODO (liviurau): Determine where exactly does Crashpad store the dumps on
+      // Linux and Windows.
+      console.error('No crash dumps found at location ', crashesPath);
+      return;
+    }
+    for (const file of fs.readdirSync(crashesPath)) {
+      console.error('Collecting crash dump:', file);
+      fs.copyFileSync(path.join(crashesPath, file), path.join(TestConfig.artifactsDir, file));
+    }
+  }
+
+  #getCrashpadDir() {
+    // TODO (liviurau): generate a tmp dir and pass when launching puppeteer
+    // instead of parsing it out of args
+    const userDataArg = this.browser.process()?.spawnargs.find(arg => arg.startsWith('--user-data-dir='));
+    if (userDataArg) {
+      const configuredPath = path.join(userDataArg.split('=')[1], 'Crashpad', 'pending');
+      // `--user-data-dir` generally does not contain Craspad files on any
+      // platform. In the future this might get properly aligned so we search
+      // here first.
+      if (fs.existsSync(configuredPath)) {
+        return configuredPath;
+      }
+    }
+    const homeDir = os.homedir();
+    const platform = os.platform();
+    switch (platform) {
+      case 'darwin':
+        return path.join(
+            homeDir, 'Library', 'Application Support', 'Google', 'Chrome for Testing', 'Crashpad', 'pending');
+      case 'win32': {
+        const localAppData = path.join(
+            process.env.LOCALAPPDATA ?? '', 'Google', 'Chrome for Testing', 'User Data', 'Crashpad', 'pending');
+        if (fs.existsSync(localAppData)) {
+          return localAppData;
+        }
+        return path.join(
+            homeDir, 'AppData', 'Local', 'Google', 'Chrome for Testing', 'User Data', 'Crashpad', 'pending');
+      }
+      case 'linux':
+        return path.join(homeDir, '.config', 'google-chrome-for-testing', 'Crashpad', 'pending');
+      default:
+        throw new Error(`Unsupported platform: ${platform}`);
+    }
+  }
 }
 export class Launcher {
   static async browserSetup(settings: BrowserSettings) {
@@ -52,6 +103,9 @@ export class Launcher {
       `--disable-features=${disabledFeatures.join(',')}`,
       '--auto-open-devtools-for-tabs',
       `--custom-devtools-frontend=${frontEndDirectory}`,
+      '--enable-crash-reporter',
+      // This has no effect (see https://crbug.com/435638630)
+      `--crash-dumps-dir=${TestConfig.artifactsDir}`,
     ];
     const headless = TestConfig.headless;
     // CDP commands in e2e and interaction should not generally take
@@ -65,6 +119,10 @@ export class Launcher {
       dumpio: !headless || Boolean(process.env['LUCI_CONTEXT']),
       protocolTimeout,
       networkEnabled: false,
+      ignoreDefaultArgs: [
+        '--disable-crash-reporter',
+        '--disable-breakpad',
+      ],
     };
 
     TestConfig.configureChrome(executablePath);