Skip to content

Commit a224c32

Browse files
OrKoNDevtools-frontend LUCI CQ
OrKoN
authored and
Devtools-frontend LUCI CQ
committed
Re-enable flaky tests with RasterInducingScroll and CompositeBackgroundColorAnimation disabled
No-Tree-Checks: True Bug: 381055647 Change-Id: I2f8762266fd08c92dcf2e7baad99eb6c9d24259b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6054264 Reviewed-by: Jack Franklin <[email protected]> Commit-Queue: Alex Rudenko <[email protected]>
1 parent 970e566 commit a224c32

File tree

7 files changed

+27
-48
lines changed

7 files changed

+27
-48
lines changed

‎test/conductor/hooks.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@ function launchChrome() {
7979
'DeferRendererTasksAfterInput', // crbug.com/361078921
8080
'PMProcessPriorityPolicy', // crbug.com/361252079
8181
'MojoChannelAssociatedSendUsesRunOrPostTask', // crbug.com/376228320
82+
'RasterInducingScroll', // crbug.com/381055647
83+
'CompositeBackgroundColorAnimation', // crbug.com/381055647
8284
];
8385
const launchArgs = [
8486
'--remote-allow-origins=*',

‎test/e2e/console/console-last-result_test.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ import {
1414
} from '../helpers/console-helpers.js';
1515

1616
describe('The Console Tab', () => {
17-
// Flakey on Windows only after a recent Chromium roll
18-
it.skipOnPlatforms(['win32'], '[crbug.com/381055647] exposes the last evaluation using "$_"', async () => {
17+
it('exposes the last evaluation using "$_"', async () => {
1918
const {frontend} = getBrowserAndPages();
2019

2120
await step('turn off "Autocomplete from history"', async () => {

‎test/e2e/issues/client-hint-issues_test.ts‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,8 @@ import {
1313
} from '../helpers/issues-helpers.js';
1414

1515
describe('Client Hint issues test', () => {
16-
// Flakey on Windows only after a recent Chromium roll
17-
it.skipOnPlatforms(
18-
['win32'],
19-
'[crbug.com/381055647] should display issue when Client Hints are used with invalid origin for DelegateCH',
20-
async () => {
16+
it(
17+
'should display issue when Client Hints are used with invalid origin for DelegateCH', async () => {
2118
await goToResource('issues/client-hint-issue-DelegateCH-MetaTagAllowListInvalidOrigin.html');
2219
await navigateToIssuesTab();
2320
await expandIssue();

‎test/e2e/issues/cors-issues_test.ts‎

Lines changed: 16 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,8 @@ import {
1515
} from '../helpers/issues-helpers.js';
1616

1717
describe('CORS issues', () => {
18-
// Flakey on Windows only after a recent Chromium roll
19-
it.skipOnPlatforms(
20-
['win32'], '[crbug.com/381055647] should display CORS violations with the correct affected resources',
21-
async () => {
18+
it(
19+
'should display CORS violations with the correct affected resources', async () => {
2220
await goToResource('issues/cors-issue.html');
2321
const {target} = getBrowserAndPages();
2422
await target.evaluate(async () => {
@@ -70,11 +68,8 @@ describe('CORS issues', () => {
7068
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
7169
});
7270

73-
// Flakey on Windows only after a recent Chromium roll
74-
it.skipOnPlatforms(
75-
['win32'],
76-
'[crbug.com/381055647] should display credentialed+wildcard CORS issues with the correct affected resources',
77-
async () => {
71+
it(
72+
'should display credentialed+wildcard CORS issues with the correct affected resources', async () => {
7873
await goToResource('empty.html');
7974
const {target} = getBrowserAndPages();
8075
await target.evaluate(async () => {
@@ -221,10 +216,8 @@ describe('CORS issues', () => {
221216
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
222217
});
223218

224-
// Flakey on Windows only after a recent Chromium roll
225-
it.skipOnPlatforms(
226-
['win32'], '[crbug.com/381055647] should display invalid CORS ACAC values with the correct affected resources',
227-
async () => {
219+
it(
220+
'should display invalid CORS ACAC values with the correct affected resources', async () => {
228221
await goToResource('empty.html');
229222
const {target} = getBrowserAndPages();
230223
await target.evaluate(async () => {
@@ -317,11 +310,8 @@ describe('CORS issues', () => {
317310
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
318311
});
319312

320-
// Flakey on Windows only after a recent Chromium roll
321-
it.skipOnPlatforms(
322-
['win32'],
323-
'[crbug.com/381055647] should display CORS requests using disallowed headers with the correct affected resources',
324-
async () => {
313+
it(
314+
'should display CORS requests using disallowed headers with the correct affected resources', async () => {
325315
await goToResource('empty.html');
326316
const {target} = getBrowserAndPages();
327317
await target.evaluate(async () => {
@@ -362,9 +352,8 @@ describe('CORS issues', () => {
362352
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
363353
});
364354

365-
// Flakey on Windows only after a recent Chromium roll
366-
it.skipOnPlatforms(
367-
['win32'], '[crbug.com/381055647] should display CORS requests redirecting to credentialed URLs', async () => {
355+
it(
356+
'should display CORS requests redirecting to credentialed URLs', async () => {
368357
await goToResource('empty.html');
369358
const {target} = getBrowserAndPages();
370359
await target.evaluate(async () => {
@@ -398,9 +387,8 @@ describe('CORS issues', () => {
398387
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
399388
});
400389

401-
// Flakey on Windows only after a recent Chromium roll
402-
it.skipOnPlatforms(
403-
['win32'], '[crbug.com/381055647] should display CORS issues that are disallowed by the mode', async () => {
390+
it(
391+
'should display CORS issues that are disallowed by the mode', async () => {
404392
await goToResource('empty.html');
405393
const {target} = getBrowserAndPages();
406394
await target.evaluate(async () => {
@@ -437,9 +425,8 @@ describe('CORS issues', () => {
437425
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
438426
});
439427

440-
// Flakey on Windows only after a recent Chromium roll
441-
it.skipOnPlatforms(
442-
['win32'], '[crbug.com/381055647] should display CORS issues that are unsupported by the scheme', async () => {
428+
it(
429+
'should display CORS issues that are unsupported by the scheme', async () => {
443430
await goToResource('empty.html');
444431
const {target} = getBrowserAndPages();
445432
await target.evaluate(async () => {
@@ -478,10 +465,8 @@ describe('CORS issues', () => {
478465
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
479466
});
480467

481-
// Flakey on Windows only after a recent Chromium roll
482-
it.skipOnPlatforms(
483-
['win32'], '[crbug.com/381055647] should display CORS issues that are misconfiguring the redirect mode',
484-
async () => {
468+
it(
469+
'should display CORS issues that are misconfiguring the redirect mode', async () => {
485470
await goToResource('empty.html');
486471
const {target} = getBrowserAndPages();
487472
await target.evaluate(async () => {

‎test/e2e/issues/cors-private-network-issues_test.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,8 @@ describe('Cors Private Network issue', () => {
9191
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
9292
});
9393

94-
// Flakey on Windows only after a recent Chromium roll
95-
it.skipOnPlatforms(
96-
['win32'], '[crbug.com/381055647] should display correct information for secure contexts', async () => {
94+
it(
95+
'should display correct information for secure contexts', async () => {
9796
await navigateToIssuesTab();
9897
const {frontend} = getBrowserAndPages();
9998
frontend.evaluate(() => {
@@ -166,9 +165,8 @@ describe('Cors Private Network issue', () => {
166165
await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
167166
});
168167

169-
// Flakey on Windows only after a recent Chromium roll
170-
it.skipOnPlatforms(
171-
['win32'], '[crbug.com/381055647] should display correct information for preflight request errors', async () => {
168+
it(
169+
'should display correct information for preflight request errors', async () => {
172170
await navigateToIssuesTab();
173171
const {frontend} = getBrowserAndPages();
174172
frontend.evaluate(() => {

‎test/e2e/issues/issue-view-caching_test.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ import {
2323
} from '../helpers/issues-helpers.js';
2424

2525
describe('IssueView cache', () => {
26-
// Flakey on Windows only after a recent Chromium roll
27-
it.skipOnPlatforms(['win32'], '[crbug.com/381055647] should correctly update the issue', async () => {
26+
it('should correctly update the issue', async () => {
2827
await goToResource('empty.html');
2928
const {target} = getBrowserAndPages();
3029
async function triggerIssue() {

‎test/e2e/issues/quota-issues_test.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ describe('Quota Issues', () => {
1717
await goToResource('empty.html');
1818
});
1919

20-
// Flakey on Windows only after a recent Chromium roll
21-
it.skipOnPlatforms(['win32'], '[crbug.com/381055647] should display correct information', async () => {
20+
it('should display correct information', async () => {
2221
await navigateToIssuesTab();
2322
const {frontend} = getBrowserAndPages();
2423
frontend.evaluate(() => {

0 commit comments

Comments
 (0)