Skip to content

Commit a370911

Browse files
Kateryna ProkopenkoDevtools-frontend LUCI CQ
authored andcommitted
[GM3Restyling] Use native menu in Peerformance flame chart
Bug: 368240754 Change-Id: Ib6de5c9a14bf71c2ee35f39246dfdd3b7c0a503f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999389 Commit-Queue: Kateryna Prokopenko <[email protected]> Reviewed-by: Kim-Anh Tran <[email protected]> Auto-Submit: Kateryna Prokopenko <[email protected]>
1 parent 7dc9931 commit a370911

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

front_end/panels/timeline/TimelineFlameChartDataProvider.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
217217
return;
218218
}
219219

220-
// TODO(crbug.com/368240754): Temporarily use soft menu for the shortcuts to show, till the accelerators backend CLs land.
221-
const contextMenu = new UI.ContextMenu.ContextMenu(event, {useSoftMenu: true});
220+
const contextMenu = new UI.ContextMenu.ContextMenu(event);
222221

223222
// This action and its 'execute' is defined in `freestyler-meta`
224223
const actionIdDrJ = 'drjones.performance-panel-context';
@@ -244,7 +243,6 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
244243
disabled: !possibleActions?.[PerfUI.FlameChart.FilterAction.MERGE_FUNCTION],
245244
jslogContext: 'hide-function',
246245
});
247-
hideEntryOption.setShortcut('H');
248246
hideEntryOption.setAccelerator(UI.KeyboardShortcut.Keys.H, [UI.KeyboardShortcut.Modifiers.None]);
249247
hideEntryOption.setIsDevToolsPerformanceMenuItem(true);
250248

@@ -254,7 +252,6 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
254252
disabled: !possibleActions?.[PerfUI.FlameChart.FilterAction.COLLAPSE_FUNCTION],
255253
jslogContext: 'hide-children',
256254
});
257-
hideChildrenOption.setShortcut('C');
258255
hideChildrenOption.setAccelerator(UI.KeyboardShortcut.Keys.C, [UI.KeyboardShortcut.Modifiers.None]);
259256
hideChildrenOption.setIsDevToolsPerformanceMenuItem(true);
260257

@@ -265,7 +262,6 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
265262
disabled: !possibleActions?.[PerfUI.FlameChart.FilterAction.COLLAPSE_REPEATING_DESCENDANTS],
266263
jslogContext: 'hide-repeating-children',
267264
});
268-
hideRepeatingChildrenOption.setShortcut('R');
269265
hideRepeatingChildrenOption.setAccelerator(UI.KeyboardShortcut.Keys.R, [UI.KeyboardShortcut.Modifiers.None]);
270266
hideRepeatingChildrenOption.setIsDevToolsPerformanceMenuItem(true);
271267

@@ -275,7 +271,6 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
275271
disabled: !possibleActions?.[PerfUI.FlameChart.FilterAction.RESET_CHILDREN],
276272
jslogContext: 'reset-children',
277273
});
278-
resetChildrenOption.setShortcut('U');
279274
resetChildrenOption.setAccelerator(UI.KeyboardShortcut.Keys.U, [UI.KeyboardShortcut.Modifiers.None]);
280275
resetChildrenOption.setIsDevToolsPerformanceMenuItem(true);
281276

0 commit comments

Comments
 (0)