Skip to content

Commit a67a964

Browse files
bmeurerDevtools-frontend LUCI CQ
authored andcommitted
Remove TODO about CheckLicense from PRESUBMIT.
We follow the Blink approach now, passing `.*` as RegExp for the license header check (basically disabling it). For DevTools we still have an ESLint rule in place that checks the license headers of source files, so we're good for now. Fixed: 40277703 Change-Id: Ibe138a6329de7b35b7e62c0b5444a4f33906bd80 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6885306 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Auto-Submit: Benedikt Meurer <[email protected]>
1 parent a661599 commit a67a964

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

PRESUBMIT.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -532,9 +532,6 @@ def CheckAuthorizedAuthor(input_api, output_api):
532532

533533

534534
def CheckPanProjectChecksOnCommit(input_api, output_api):
535-
# TODO(b/40277703): CheckLicense is explicitly disabled for now until the
536-
# situation around the Blink-inherited Google Inc copyright headers is
537-
# resolved, at which point we need to remove the `license_header` parameter.
538535
return input_api.canned_checks.PanProjectChecks(input_api,
539536
output_api,
540537
license_header=".*",

0 commit comments

Comments
 (0)