[RPP] Remove subtle background highlight for selected track

This was called out as potentially conflicting with the planned dimming
behavior.

Bug: 370836271
Change-Id: I7cb897e2232386c25daec0824500aa2ec5cff0e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5960127
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Paul Irish <[email protected]>

Author: Connor Clark

front_end/ui/legacy/components/perf_ui/FlameChart.ts

@@ -2174,16 +2174,6 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
 
     const {markerIndices, colorBuckets, titleIndices} = this.getDrawableData(context, timelineData);
 
-    context.save();
-    this.forEachGroupInViewport((offset, index, group, isFirst, groupHeight) => {
-      if (this.isGroupFocused(index)) {
-        context.fillStyle =
-            ThemeSupport.ThemeSupport.instance().getComputedValue('--selected-group-background', this.contentElement);
-        context.fillRect(0, offset, canvasWidth, groupHeight - group.style.padding);
-      }
-    });
-    context.restore();
-
     const groups = this.rawTimelineData?.groups || [];
     const trackIndex = groups.findIndex(g => g.name.includes('Main'));
     const group = groups.at(trackIndex);
@@ -2678,14 +2668,9 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
       if (this.isGroupCollapsible(index) && !group.expanded || group.style.shareHeaderLine) {
         // In edit mode, we draw an extra rectangle for the save icon.
         const labelBackgroundWidth = this.labelWidthForGroup(context, group);
-        if (this.isGroupFocused(index)) {
-          context.fillStyle =
-              ThemeSupport.ThemeSupport.instance().getComputedValue('--selected-group-background', this.contentElement);
-        } else {
-          const parsedColor = Common.Color.parse(group.style.backgroundColor);
-          if (parsedColor) {
-            context.fillStyle = (parsedColor.setAlpha(0.8).asString() as string);
-          }
+        const parsedColor = Common.Color.parse(group.style.backgroundColor);
+        if (parsedColor) {
+          context.fillStyle = (parsedColor.setAlpha(0.8).asString() as string);
         }
         context.fillRect(
             iconsWidth + HEADER_LEFT_PADDING, offset + HEADER_LABEL_Y_PADDING, labelBackgroundWidth,

front_end/ui/legacy/components/perf_ui/flameChart.css

@@ -7,12 +7,10 @@
 .flame-chart-main-pane {
   overflow: hidden;
 
-  --selected-group-background: hsl(215deg 85% 98%);
   --selected-group-border: hsl(216deg 68% 54%);
 }
 
 :host-context(.theme-with-dark-background) .flame-chart-main-pane {
-  --selected-group-background: hsl(215deg 85% 15%);
   --selected-group-border: hsl(216deg 68% 46%);
 }