[cleanup] Remove rules/lit_html_data_as_type ESLint rule.

Bug: 375114000
Change-Id: I73e1f7b44733cbd98ad4565dc8e68a88596a3e0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953150
Reviewed-by: Danil Somsikov <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>

Author: bmeurer

extensions/cxx_debugging/src/ExtensionOptions.ts

@@ -4,7 +4,6 @@
 
 /* eslint-disable rulesdir/check_component_naming */
 /* eslint-disable rulesdir/inject_checkbox_styles */
-/* eslint-disable rulesdir/lit_html_data_as_type */
 /* eslint-disable rulesdir/lit_html_host_this */
 
 import {html, render} from 'lit-html';

front_end/.eslintrc.js

@@ -37,7 +37,6 @@ module.exports = {
         'rulesdir/enforce_custom_event_names': 'error',
         'rulesdir/set_data_type_reference': 'error',
         'rulesdir/no_bound_component_methods': 'error',
-        'rulesdir/lit_html_data_as_type': 'error',
         'rulesdir/lit_no_style_interpolation': 'error',
         'rulesdir/ban_self_closing_custom_element_tagnames': 'error',
         'rulesdir/ban_style_tags_in_lit_html': 'error',

front_end/ui/components/docs/building-ui-documentation/ComponentPerformance.md

@@ -80,10 +80,7 @@ set y(y: number) {
 }
 ```
 
-We did this for two reasons:
-
-1. We can provide _some_ type-safety via `.data=${{x: 1, y: 2} as FooData}`.
-2. We avoided having to immediately implement batched rendering.
+We did this to avoid having to immediately implement batched rendering.
 
 However, this decision came with a performance penalty. Lit will only trigger a re-render of a component if one of its properties changes. But when we pass in a new object on each render, we are effectively triggering a re-render every time. Normally this impact isn't noticable, and most components don't re-render with the frequency required to cause performance issues. When a component that takes an object via `set data()` is frequently re-rendered, that causes a non-negligible amount of garbage collection to tidy up the one-use objects we create.
 

front_end/ui/components/docs/building-ui-documentation/CreatingComponents.md

@@ -198,21 +198,6 @@ LitHtml.render(html`
 `, this.#shadow, {host: this});
 ```
 
-To enforce some type safety, we also use TypeScript's `as` keyword to force the compiler to type-check the `data` object against the interface:
-
-```ts
-// Within some component
-LitHtml.render(html`
-  <devtools-elements-breadcrumbs .data=${{
-    selectedNode: node,
-    crumbs: [...],
-  } as ElementsBreadcrumbsData}>
-  </devtools-elements-breadcrumbs>
-`, this.#shadow, {host: this});
-```
-
-This type-checking requirement is enforced by an ESLint rule.
-
 ## Performance concerns with data passing
 
 The approach of `set data(data)` was chosen because: