Skip to content

Commit a9c30a5

Browse files
ktranDevtools-frontend LUCI CQ
authored andcommitted
[GM3Restyling] Update a number of EmptyWidget view titles
This updates the empty widget view headers from: ServiceWorkerCacheViews.ts LayerDetailsView.ts ResourceWebSocketFrameView.ts DataGridWithPreview.ts They all provide a panel for viewing their content (message, cache, ..). Screenshot: https://imgur.com/a/3yrNaax Bug: 325443331 Change-Id: I0d753e5d2fae02dc98da26a24462decdce8fb500 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6170715 Auto-Submit: Kim-Anh Tran <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]> Reviewed-by: Kateryna Prokopenko <[email protected]>
1 parent f63da12 commit a9c30a5

File tree

7 files changed

+37
-6
lines changed

7 files changed

+37
-6
lines changed

front_end/panels/application/CookieItemsView.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ const UIStrings = {
5151
*@description Text for web cookies
5252
*/
5353
cookies: 'Cookies',
54+
/**
55+
*@description Text in Cookie Items View of the Application panel to indicate that no cookie has been selected for preview
56+
*/
57+
noCookieSelected: 'No cookie selected',
5458
/**
5559
*@description Text in Cookie Items View of the Application panel
5660
*/
@@ -199,7 +203,8 @@ export class CookieItemsView extends StorageItemsView {
199203
this.splitWidget.installResizer(resizer);
200204

201205
this.previewWidget = new CookiePreviewWidget();
202-
this.emptyWidget = new UI.EmptyWidget.EmptyWidget('', i18nString(UIStrings.selectACookieToPreviewItsValue));
206+
this.emptyWidget = new UI.EmptyWidget.EmptyWidget(
207+
i18nString(UIStrings.noCookieSelected), i18nString(UIStrings.selectACookieToPreviewItsValue));
203208
this.emptyWidget.show(this.previewPanel.contentElement);
204209

205210
this.onlyIssuesFilterUI = new UI.Toolbar.ToolbarCheckbox(

front_end/panels/application/ServiceWorkerCacheViews.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ const UIStrings = {
3737
*@description Text in Service Worker Cache Views of the Application panel
3838
*/
3939
filterByPath: 'Filter by path',
40+
/**
41+
*@description Text in Service Worker Cache Views of the Application panel that shows if no cache entry is selected for preview
42+
*/
43+
noCacheEntrySelected: 'No cache entry selected',
4044
/**
4145
*@description Text in Service Worker Cache Views of the Application panel
4246
*/
@@ -191,7 +195,8 @@ export class ServiceWorkerCacheView extends UI.View.SimpleView {
191195
this.preview.detach();
192196
}
193197
if (!preview) {
194-
preview = new UI.EmptyWidget.EmptyWidget('', i18nString(UIStrings.selectACacheEntryAboveToPreview));
198+
preview = new UI.EmptyWidget.EmptyWidget(
199+
i18nString(UIStrings.noCacheEntrySelected), i18nString(UIStrings.selectACacheEntryAboveToPreview));
195200
}
196201
this.preview = preview;
197202
this.preview.show(this.previewPanel.element);

front_end/panels/layer_viewer/LayerDetailsView.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ const UIStrings = {
5050
*@description Text in Layer Details View of the Layers panel
5151
*/
5252
selectALayerToSeeItsDetails: 'Select a layer to see its details',
53+
/**
54+
*@description Text in Layer Details View of the Layers panel if no layer is selected for viewing its content
55+
*/
56+
noLayerSelected: 'No layer selected',
5357
/**
5458
*@description Element text content in Layer Details View of the Layers panel
5559
*@example {Touch event handler} PH1
@@ -179,10 +183,12 @@ export class LayerDetailsView extends Common.ObjectWrapper.eventMixin<EventTypes
179183
constructor(layerViewHost: LayerViewHost) {
180184
super(true);
181185
this.element.setAttribute('jslog', `${VisualLogging.pane('layers-details')}`);
186+
this.contentElement.classList.add('layer-details-container');
182187

183188
this.layerViewHost = layerViewHost;
184189
this.layerViewHost.registerView(this);
185-
this.emptyWidget = new UI.EmptyWidget.EmptyWidget('', i18nString(UIStrings.selectALayerToSeeItsDetails));
190+
this.emptyWidget = new UI.EmptyWidget.EmptyWidget(
191+
i18nString(UIStrings.noLayerSelected), i18nString(UIStrings.selectALayerToSeeItsDetails));
186192
this.layerSnapshotMap = this.layerViewHost.getLayerSnapshotMap();
187193

188194
this.buildContent();

front_end/panels/layer_viewer/layerDetailsView.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
* found in the LICENSE file.
55
*/
66

7+
.layer-details-container:has(.empty-view-scroller) {
8+
display: flex;
9+
}
10+
711
table td {
812
padding-left: 8px;
913
}

front_end/panels/network/ResourceWebSocketFrameView.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ const UIStrings = {
5959
*@description Text to filter result items
6060
*/
6161
filter: 'Filter',
62+
/**
63+
*@description Text in Resource Web Socket Frame View of the Network panel that shows if no message is selected for viewing its content
64+
*/
65+
noMessageSelected: 'No message selected',
6266
/**
6367
*@description Text in Resource Web Socket Frame View of the Network panel
6468
*/
@@ -237,7 +241,8 @@ export class ResourceWebSocketFrameView extends UI.Widget.VBox {
237241
mainContainer.setMinimumSize(0, 72);
238242
this.splitWidget.setMainWidget(mainContainer);
239243

240-
this.frameEmptyWidget = new UI.EmptyWidget.EmptyWidget('', i18nString(UIStrings.selectMessageToBrowseItsContent));
244+
this.frameEmptyWidget = new UI.EmptyWidget.EmptyWidget(
245+
i18nString(UIStrings.noMessageSelected), i18nString(UIStrings.selectMessageToBrowseItsContent));
241246
this.splitWidget.setSidebarWidget(this.frameEmptyWidget);
242247

243248
this.selectedNode = null;

front_end/ui/legacy/components/data_grid/DataGridWithPreview.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ describeWithEnvironment('DataGridWithPreview', () => {
101101
await raf();
102102

103103
// Check preview was updated.
104-
assert.strictEqual(dataGridWithPreview.previewPanelForTesting.element.innerText, 'Select a value to preview');
104+
assert.strictEqual(
105+
dataGridWithPreview.previewPanelForTesting.element.innerText, 'No value selected\nSelect a value to preview');
105106
});
106107

107108
it('preview changed when value changes', async () => {

front_end/ui/legacy/components/data_grid/DataGridWithPreview.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ import {ARIAUtils, EmptyWidget, SplitWidget, Widget} from '../../legacy.js';
3434
import {type ColumnDescriptor, DataGridImpl, DataGridNode, Events} from './DataGrid.js';
3535

3636
const UIStrings = {
37+
/**
38+
*@description Text that shows in the Applicaiton Panel if no value is selected for preview
39+
*/
40+
noPreviewSelected: 'No value selected',
3741
/**
3842
*@description Preview text when viewing storage in Application panel
3943
*/
@@ -275,7 +279,8 @@ export class DataGridWithPreview {
275279
this.#preview.detach();
276280
}
277281
if (!preview) {
278-
preview = new EmptyWidget.EmptyWidget('', i18nString(UIStrings.selectAValueToPreview));
282+
preview = new EmptyWidget.EmptyWidget(
283+
i18nString(UIStrings.noPreviewSelected), i18nString(UIStrings.selectAValueToPreview));
279284
}
280285
this.#previewValue = value;
281286
this.#preview = preview;

0 commit comments

Comments
 (0)