Skip to content

Commit ab720e8

Browse files
wolfibDevtools-frontend LUCI CQ
authored andcommitted
[Patch agent] UX improvements for SelectWorkspaceDialog
- Update UI Strings - If there are no existing workspaces to select from, don't show the 'select' button, and make the 'add folder' button a primary button Screenshots: https://imgur.com/a/3mBYCaE Fixed: 404162234 Change-Id: Ie4eb13747c05b055f8ae0b4ff94ae3cfd20f862c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6362474 Auto-Submit: Wolfgang Beyer <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]> Commit-Queue: Wolfgang Beyer <[email protected]>
1 parent 6b5dba9 commit ab720e8

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

front_end/panels/ai_assistance/SelectWorkspaceDialog.ts

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import * as Persistence from '../../models/persistence/persistence.js';
88
import * as Workspace from '../../models/workspace/workspace.js';
99
import * as Buttons from '../../ui/components/buttons/buttons.js';
1010
import * as UI from '../../ui/legacy/legacy.js';
11-
import {html, render} from '../../ui/lit/lit.js';
11+
import {html, nothing, render} from '../../ui/lit/lit.js';
1212

1313
import selectWorkspaceDialogStyles from './selectWorkspaceDialog.css.js';
1414

@@ -19,7 +19,7 @@ const UIStringsNotTranslate = {
1919
/**
2020
*@description Heading of dialog box which asks user to select a workspace folder.
2121
*/
22-
selectFolder: 'Select folder',
22+
selectFolder: 'Select project root folder',
2323
/**
2424
*@description Button text for canceling workspace selection.
2525
*/
@@ -35,7 +35,8 @@ const UIStringsNotTranslate = {
3535
/*
3636
*@description Explainer stating that selected folder's contents are being sent to Google.
3737
*/
38-
sourceCodeSent: 'Source code from the selected folder is sent to Google to generate code suggestions'
38+
sourceCodeSent:
39+
'To save patches directly to your project, select the project root folder containing the source files of the inspected page. Relevant code snippets will be sent to Google to generate code suggestions.'
3940
} as const;
4041

4142
const lockedString = i18n.i18n.lockedString;
@@ -84,6 +85,7 @@ export class SelectWorkspaceDialog extends UI.Widget.VBox {
8485

8586
// clang-format off
8687
this.#view = view ?? ((input, output, target) => {
88+
const hasProjects = input.projects.length > 0;
8789
render(
8890
html`
8991
<div class="dialog-header">${lockedString(UIStringsNotTranslate.selectFolder)}</div>
@@ -115,13 +117,15 @@ export class SelectWorkspaceDialog extends UI.Widget.VBox {
115117
.iconName=${'plus'}
116118
.jslogContext=${'add-folder'}
117119
@click=${input.onAddFolderButtonClick}
118-
.variant=${Buttons.Button.Variant.TONAL}>${lockedString(UIStringsNotTranslate.addFolder)}</devtools-button>
119-
<devtools-button
120-
title=${lockedString(UIStringsNotTranslate.select)}
121-
aria-label="Select"
122-
@click=${input.onSelectButtonClick}
123-
.jslogContext=${'select'}
124-
.variant=${Buttons.Button.Variant.PRIMARY}>${lockedString(UIStringsNotTranslate.select)}</devtools-button>
120+
.variant=${hasProjects ? Buttons.Button.Variant.TONAL : Buttons.Button.Variant.PRIMARY}>${lockedString(UIStringsNotTranslate.addFolder)}</devtools-button>
121+
${hasProjects ? html`
122+
<devtools-button
123+
title=${lockedString(UIStringsNotTranslate.select)}
124+
aria-label="Select"
125+
@click=${input.onSelectButtonClick}
126+
.jslogContext=${'select'}
127+
.variant=${Buttons.Button.Variant.PRIMARY}>${lockedString(UIStringsNotTranslate.select)}</devtools-button>
128+
` : nothing}
125129
</div>
126130
`,
127131
target,

0 commit comments

Comments
 (0)