Skip to content

Commit abecc01

Browse files
legendecasDevtools-frontend LUCI CQ
authored andcommitted
Fix memory trend for Node.js targets
The new memory usage fields are available after V8 13.4. Node.js has not yet been released with this version of V8 yet. Bug: 40734351 Change-Id: Ie3b9777e6983ff26ee625e78ea385158b80252a5 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6317029 Reviewed-by: Simon Zünd <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
1 parent 800ce92 commit abecc01

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

front_end/core/sdk/IsolateManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ export class Isolate {
178178
if (!usage) {
179179
return;
180180
}
181-
this.#usedHeapSizeInternal = usage.usedSize + usage.embedderHeapUsedSize + usage.backingStorageSize;
181+
this.#usedHeapSizeInternal = usage.usedSize + (usage.embedderHeapUsedSize ?? 0) + (usage.backingStorageSize ?? 0);
182182
this.#memoryTrend.add(this.#usedHeapSizeInternal);
183183
IsolateManager.instance().dispatchEventToListeners(Events.MEMORY_CHANGED, this);
184184
}

front_end/core/sdk/RuntimeModel.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,9 @@ export class RuntimeModel extends SDKModel<EventTypes> {
269269
async heapUsage(): Promise<{
270270
usedSize: number,
271271
totalSize: number,
272-
embedderHeapUsedSize: number,
273-
backingStorageSize: number,
272+
// Available after V8 13.4. Node.js has not yet been released with this version of V8 yet.
273+
embedderHeapUsedSize?: number,
274+
backingStorageSize?: number,
274275
}|null> {
275276
const result = await this.agent.invoke_getHeapUsage();
276277
return result.getError() ? null : result;

0 commit comments

Comments
 (0)