[test] Replace assertNotNullOrUndefined with assert.exists in unit tests

[email protected]

Bug: None
Change-Id: I2ac986c36fb8a8f417b72632a9b15fb5c566fef0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6905382
Commit-Queue: Alex Rudenko <[email protected]>
Auto-Submit: Simon Zünd <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>

Author: szuend

front_end/models/bindings/DebuggerLanguagePlugins.test.ts

@@ -108,7 +108,7 @@ describe('DebuggerLanguagePluginManager', () => {
 
       const location = sinon.createStubInstance(SDK.DebuggerModel.Location);
       const result = await pluginManager.getFunctionInfo(script, location);
-      Platform.assertNotNullOrUndefined(result);
+      assert.exists(result);
       assert.deepEqual(result, {missingSymbolFiles: [MISSING_DEBUG_FILES]});
     });
 
@@ -121,7 +121,7 @@ describe('DebuggerLanguagePluginManager', () => {
       const location = sinon.createStubInstance(SDK.DebuggerModel.Location);
 
       const result = await pluginManager.getFunctionInfo(script, location);
-      Platform.assertNotNullOrUndefined(result);
+      assert.exists(result);
       assert.deepEqual(result, {frames: [{name: FUNCTION_NAME}]});
     });
 
@@ -135,7 +135,7 @@ describe('DebuggerLanguagePluginManager', () => {
       const location = sinon.createStubInstance(SDK.DebuggerModel.Location);
 
       const result = await pluginManager.getFunctionInfo(script, location);
-      Platform.assertNotNullOrUndefined(result);
+      assert.exists(result);
       assert.deepEqual(result, {frames: [{name: FUNCTION_NAME}], missingSymbolFiles: [MISSING_DEBUG_FILES]});
     });
   });

front_end/panels/application/BackgroundServiceView.test.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Platform from '../../core/platform/platform.js';
+import type * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
 import {dispatchClickEvent} from '../../testing/DOMHelpers.js';
@@ -94,8 +94,8 @@ describeWithMockConnection('BackgroundServiceView', () => {
 
   it('Triggers record on button click', () => {
     const recordButton = view.contentElement.querySelector('.empty-state devtools-button');
-    Platform.assertNotNullOrUndefined(recordButton);
-    assert.deepEqual(recordButton?.textContent, 'Start recording events');
+    assert.exists(recordButton);
+    assert.deepEqual(recordButton.textContent, 'Start recording events');
 
     const recordingSpy = sinon.spy(view, 'toggleRecording');
     dispatchClickEvent(recordButton);

front_end/panels/common/AiCodeCompletionTeaser.test.ts

@@ -4,7 +4,6 @@
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
-import {assertNotNullOrUndefined} from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 import {renderElementIntoDOM} from '../../testing/DOMHelpers.js';
 import {describeWithEnvironment, updateHostConfig} from '../../testing/EnvironmentHelpers.js';
@@ -43,7 +42,7 @@ describeWithEnvironment('AiCodeCompletionTeaser', () => {
     const showSnackbar = sinon.stub(Snackbars.Snackbar.Snackbar, 'show');
 
     assert.isTrue(widget.isShowing());
-    assertNotNullOrUndefined(view.input.onDismiss);
+    assert.exists(view.input.onDismiss);
     view.input.onDismiss(new Event('click'));
     await widget.updateComplete;
 
@@ -56,12 +55,12 @@ describeWithEnvironment('AiCodeCompletionTeaser', () => {
     const {view, widget} = await createTeaser();
     const showSnackbar = sinon.stub(Snackbars.Snackbar.Snackbar, 'show');
     const showViewStub = sinon.stub(UI.ViewManager.ViewManager.instance(), 'showView');
-    assertNotNullOrUndefined(view.input.onDismiss);
+    assert.exists(view.input.onDismiss);
     view.input.onDismiss(new Event('click'));
 
     sinon.assert.calledOnce(showSnackbar);
     const snackbarOptions = showSnackbar.firstCall.args[0];
-    assertNotNullOrUndefined(snackbarOptions.actionProperties);
+    assert.exists(snackbarOptions.actionProperties);
     snackbarOptions.actionProperties.onClick();
 
     assert.isTrue(showViewStub.calledOnceWith('chrome-ai'));