RPP: make args.data optional for console.timestamp events

We have a trace that has a console timestamp trace event with no
`args.data`, and this breaks the code. This CL updates the types to mark
`args.data` as optional and then updates the code accordingly.

Bug: none
Change-Id: I6167b016cee20da0fa70a82bcbe6f2565b4f654c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6221296
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Andres Olivares <[email protected]>
Commit-Queue: Andres Olivares <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>

Author: jackfranklin

front_end/models/trace/extras/TraceTree.ts

@@ -589,7 +589,7 @@ export function generateEventID(event: Types.Events.Event): string {
     return `f:${name}@${location}`;
   }
 
-  if (Types.Events.isConsoleTimeStamp(event)) {
+  if (Types.Events.isConsoleTimeStamp(event) && event.args.data) {
     return `${event.name}:${event.args.data.name}`;
   }
 

front_end/models/trace/handlers/ExtensionTraceDataHandler.ts

@@ -81,6 +81,9 @@ function createExtensionFlameChartEntries(): void {
 export function extractConsoleAPIExtensionEntries(): void {
   const consoleTimeStamps: readonly Types.Events.ConsoleTimeStamp[] = userTimingsData().timestampEvents;
   for (const currentTimeStamp of consoleTimeStamps) {
+    if (!currentTimeStamp.args.data) {
+      continue;
+    }
     const timeStampName = String(currentTimeStamp.args.data.name);
     timeStampByName.set(timeStampName, currentTimeStamp);
     const extensionData = extensionDataInConsoleTimeStamp(currentTimeStamp);
@@ -254,6 +257,9 @@ export function extensionDataInPerformanceTiming(timing: Types.Events.SyntheticU
  */
 export function extensionDataInConsoleTimeStamp(timeStamp: Types.Events.ConsoleTimeStamp):
     Types.Extensions.ExtensionTrackEntryPayload|null {
+  if (!timeStamp.args.data) {
+    return null;
+  }
   const trackName = timeStamp.args.data.track;
   if (trackName === '' || trackName === undefined) {
     return null;

front_end/models/trace/handlers/UserTimingsHandler.test.ts

@@ -174,9 +174,9 @@ describeWithEnvironment('UserTimingsHandler', function() {
     describe('console.timestamp events parsing', function() {
       it('parses console.timestamp events correctly', async function() {
         assert.lengthOf(timingsData.timestampEvents, 3);
-        assert.strictEqual(timingsData.timestampEvents[0].args.data.name, 'a timestamp');
-        assert.strictEqual(timingsData.timestampEvents[1].args.data.name, 'another timestamp');
-        assert.strictEqual(timingsData.timestampEvents[2].args.data.name, 'yet another timestamp');
+        assert.strictEqual(timingsData.timestampEvents[0].args.data?.name, 'a timestamp');
+        assert.strictEqual(timingsData.timestampEvents[1].args.data?.name, 'another timestamp');
+        assert.strictEqual(timingsData.timestampEvents[2].args.data?.name, 'yet another timestamp');
       });
     });
   });

front_end/models/trace/types/TraceEvents.ts

@@ -1412,7 +1412,7 @@ export interface ConsoleTimeStamp extends Event {
   name: Name.CONSOLE_TIME_STAMP;
   ph: Phase.COMPLETE;
   args: Args&{
-    data: ArgsData & {
+    data?: ArgsData & {
       // The console.timeStamp allows to pass integers as values as well
       // as strings
       name: string | number,

front_end/panels/timeline/TimelineUIUtils.ts

@@ -655,7 +655,7 @@ export class TimelineUIUtils {
     if (Trace.Helpers.Trace.eventHasCategory(event, Trace.Types.Events.Categories.Console)) {
       return title;
     }
-    if (Trace.Types.Events.isConsoleTimeStamp(event)) {
+    if (Trace.Types.Events.isConsoleTimeStamp(event) && event.args.data) {
       return i18nString(UIStrings.sS, {PH1: title, PH2: event.args.data.name});
     }
     if (Trace.Types.Events.isAnimation(event) && event.args.data.name) {

front_end/panels/timeline/TimingsTrackAppender.ts

@@ -244,7 +244,7 @@ export class TimingsTrackAppender implements TrackAppender {
       }
     }
     if (Trace.Types.Events.isConsoleTimeStamp(event)) {
-      return `TimeStamp: ${event.args.data.name}`;
+      return `TimeStamp: ${event.args.data?.name ?? '(name unknown)'}`;
     }
     if (Trace.Types.Events.isPerformanceMark(event)) {
       return `[mark]: ${event.name}`;

front_end/panels/timeline/track_appenders/TimingsTrackAppender.test.ts

@@ -154,7 +154,7 @@ describeWithEnvironment('TimingTrackAppender', function() {
     it('returns the correct title for console timestamps', () => {
       const traceMarkers = parsedTrace.UserTimings.timestampEvents;
       for (const mark of traceMarkers) {
-        assert.strictEqual(timingsTrackAppender.titleForEvent(mark), `TimeStamp: ${mark.args.data.name}`);
+        assert.strictEqual(timingsTrackAppender.titleForEvent(mark), `TimeStamp: ${mark.args.data?.name}`);
       }
     });
   });