Skip to content

Commit ae705ff

Browse files
mathiasbynensDevtools-frontend LUCI CQ
authored andcommitted
Fix UI engineering code samples
The solidus `/>` does not have any special meaning in HTML, and does not replace an end tag. This patch fixes the examples by adding explicit end tags where intended, ensuring that e.g. <devtools-tab-pane> does not get nested under <devtools-widget> in the first example. The distinction is critical as it results in a different DOM structure. Bug: chromium:394001149 Change-Id: I5331103b758693021798adde3e4dbd8c34eb1ff4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6252743 Auto-Submit: Mathias Bynens <[email protected]> Reviewed-by: Danil Somsikov <[email protected]> Commit-Queue: Danil Somsikov <[email protected]>
1 parent b287d00 commit ae705ff

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

docs/ui_engineering.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ This will instantiate a `Widget` class with the web component as its `element` a
4343
```html
4444
<devtools-widget .config=${widgetConfig(ElementsPanel)}>
4545
<devtools-split-widget>
46-
<devtools-widget slot="main".config=${widgetConfig(ElementsTree)} />
47-
<devtools-tab-pane slot="sidebar" />
48-
<devtools-widget .config=${widgetConfig(StylesPane, {element: input.element})} />
49-
<devtools-widget .config=${widgetConfig(ComputedPane, {element: input.element})} />
50-
...
46+
<devtools-widget slot="main".config=${widgetConfig(ElementsTree)}></devtools-widget>
47+
<devtools-tab-pane slot="sidebar">
48+
<devtools-widget .config=${widgetConfig(StylesPane, {element: input.element})}></devtools-widget>
49+
<devtools-widget .config=${widgetConfig(ComputedPane, {element: input.element})}></devtools-widget>
50+
...
5151
</devtools-tab-pane>
5252
</devtools-split-widget>
5353
</devtools-widget>
@@ -57,11 +57,12 @@ This will instantiate a `Widget` class with the web component as its `element` a
5757
class StylesPane extends UI.Widget {
5858
constructor(element, view = (input, output, target) => {
5959
render(html`
60-
<devtools-widget .config=${widgetConfig(MetricsPane, {element: input.element})} />
60+
<devtools-widget .config=${widgetConfig(MetricsPane, {element: input.element})}>
61+
</devtools-widget>
6162
<devtools-toolbar>
62-
<devtools-filter-input @change=${input.onFilter}/>
63-
<devtools-checkbox @change=${input.onShowAll}>Show All<devtools-checkbox>
64-
<devtools-checkbox @change=${input.onGroup}>Group<devtools-checkbox>
63+
<devtools-filter-input @change=${input.onFilter}></devtools-filter-input>
64+
<devtools-checkbox @change=${input.onShowAll}>Show All</devtools-checkbox>
65+
<devtools-checkbox @change=${input.onGroup}>Group</devtools-checkbox>
6566
</devtools-toolbar>
6667
<devtools-tree-outline>
6768
${input.properties.map(p => html`<li>

0 commit comments

Comments
 (0)