Swap out promoteFeature flag to featurePromotionId

Bug: 434870886
Change-Id: I314f5fb223d9fdb28eb495c2e066ae6bbbceca44
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6811474
Auto-Submit: Kateryna Prokopenko <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Kateryna Prokopenko <[email protected]>

Author: Kateryna Prokopenko

front_end/panels/ai_assistance/ai_assistance-meta.ts

@@ -115,7 +115,7 @@ UI.ViewManager.registerViewExtension({
   title: i18nLazyString(UIStrings.aiAssistance),
   order: 10,
   isPreviewFeature: true,
-  promoteFeature: true,
+  featurePromotionId: 'ai-assistance',
   persistence: UI.ViewManager.ViewPersistence.CLOSEABLE,
   hasToolbar: false,
   condition: config => isAnyFeatureAvailable(config) && !isPolicyRestricted(config),

front_end/ui/legacy/ViewManager.ts

@@ -75,8 +75,8 @@ export class PreRegisteredView implements View {
     return Boolean(this.viewRegistration.isPreviewFeature);
   }
 
-  promoteFeature(): boolean {
-    return Boolean(this.viewRegistration.promoteFeature);
+  featurePromotionId(): string|undefined {
+    return this.viewRegistration.featurePromotionId;
   }
 
   iconName(): string|undefined {

front_end/ui/legacy/ViewRegistration.ts

@@ -157,7 +157,7 @@ export interface ViewRegistration {
   /**
    * Whether a view needs to be promoted. A new badge is shown next to the menu items then.
    */
-  promoteFeature?: boolean;
+  featurePromotionId?: string;
 }
 
 const viewIdSet = new Set<string>();

front_end/ui/legacy/components/quick_open/CommandMenu.ts

@@ -73,7 +73,7 @@ export class CommandMenu {
       userActionCode,
       deprecationWarning,
       isPanelOrDrawer,
-      promoteFeature,
+      featurePromotionId,
     } = options;
 
     let handler = executeHandler;
@@ -86,7 +86,7 @@ export class CommandMenu {
     }
     return new Command(
         category, title, keys, shortcut, jslogContext, handler, availableHandler, deprecationWarning, isPanelOrDrawer,
-        promoteFeature);
+        featurePromotionId);
   }
 
   static createSettingCommand<V>(setting: Common.Settings.Setting<V>, title: Common.UIString.LocalizedString, value: V):
@@ -158,7 +158,7 @@ export class CommandMenu {
   }
 
   static createRevealViewCommand(options: RevealViewCommandOptions): Command {
-    const {title, tags, category, userActionCode, id, promoteFeature} = options;
+    const {title, tags, category, userActionCode, id, featurePromotionId} = options;
     if (!category) {
       throw new Error(`Creating '${title}' reveal view command failed. Reveal view has no category.`);
     }
@@ -186,7 +186,7 @@ export class CommandMenu {
       userActionCode,
       availableHandler: undefined,
       isPanelOrDrawer: panelOrDrawer,
-      promoteFeature,
+      featurePromotionId,
     });
   }
 
@@ -210,7 +210,7 @@ export class CommandMenu {
         tags: view.tags() || '',
         category,
         id: view.viewId(),
-        promoteFeature: view.promoteFeature(),
+        featurePromotionId: view.featurePromotionId(),
       };
       this.commandsInternal.push(CommandMenu.createRevealViewCommand(options));
     }
@@ -243,7 +243,7 @@ export interface RevealViewCommandOptions {
   tags: string;
   category: UI.ViewManager.ViewLocationCategory;
   userActionCode?: number;
-  promoteFeature?: boolean;
+  featurePromotionId?: string;
 }
 
 export interface CreateCommandOptions {
@@ -257,7 +257,7 @@ export interface CreateCommandOptions {
   userActionCode?: number;
   deprecationWarning?: Platform.UIString.LocalizedString;
   isPanelOrDrawer?: PanelOrDrawer;
-  promoteFeature?: boolean;
+  featurePromotionId?: string;
 }
 
 export const enum PanelOrDrawer {
@@ -320,7 +320,7 @@ export class CommandMenuProvider extends Provider {
     const command = this.commands[itemIndex];
     let score = Diff.Diff.DiffWrapper.characterScore(query.toLowerCase(), command.title.toLowerCase());
     // Increase score of promoted items so that these appear on top of the list
-    if (command.promoteFeature) {
+    if (command.featurePromotionId) {
       score = Number.MAX_VALUE;
       return score;
     }
@@ -344,7 +344,7 @@ export class CommandMenuProvider extends Provider {
     UI.UIUtils.createTextChild(titleElement, command.title);
     FilteredListWidget.highlightRanges(titleElement, query, true);
 
-    if (command.promoteFeature) {
+    if (command.featurePromotionId) {
       const badge = UI.UIUtils.maybeCreateNewBadge('ai-asisstance');
       if (badge) {
         titleElement.parentElement?.insertBefore(badge, subtitleElement);
@@ -416,7 +416,7 @@ export class Command {
   readonly jslogContext: string;
   readonly deprecationWarning?: Platform.UIString.LocalizedString;
   readonly isPanelOrDrawer?: PanelOrDrawer;
-  readonly promoteFeature?: boolean;
+  readonly featurePromotionId?: string;
 
   readonly #executeHandler: () => unknown;
   readonly #availableHandler?: () => boolean;
@@ -425,7 +425,7 @@ export class Command {
       category: Common.UIString.LocalizedString, title: Common.UIString.LocalizedString, key: string, shortcut: string,
       jslogContext: string, executeHandler: () => unknown, availableHandler?: () => boolean,
       deprecationWarning?: Platform.UIString.LocalizedString, isPanelOrDrawer?: PanelOrDrawer,
-      promoteFeature?: boolean) {
+      featurePromotionId?: string) {
     this.category = category;
     this.title = title;
     this.key = category + '\0' + title + '\0' + key;
@@ -435,7 +435,7 @@ export class Command {
     this.#availableHandler = availableHandler;
     this.deprecationWarning = deprecationWarning;
     this.isPanelOrDrawer = isPanelOrDrawer;
-    this.promoteFeature = promoteFeature;
+    this.featurePromotionId = featurePromotionId;
   }
 
   available(): boolean {