[eslint] Include ExtensionAPI

This makes all current files under DevTools lintable with EsLint
by default.
Also remove the rule for default export for configs.

Bug: 397260638
Change-Id: I3b380ad4351eb53c65207b242d7f8221e7788e48
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357121
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>

Author: Lightning00Blade

eslint.config.mjs

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/* eslint-disable import/no-default-export */
-
 import stylisticPlugin from '@stylistic/eslint-plugin';
 import typescriptPlugin from '@typescript-eslint/eslint-plugin';
 import tsParser from '@typescript-eslint/parser';
@@ -842,4 +840,13 @@ export default [
       'import/no-default-export': 'off',
     },
   },
+  {
+    name: 'Config files',
+    files: ['eslint.config.mjs', '**/*/rollup.config.mjs'],
+    rules: {
+      // The config operate on the default export
+      // So allow it for them
+      'import/no-default-export': 'off',
+    },
+  },
 ];

extension-api/ExtensionAPI.d.ts

@@ -4,6 +4,7 @@
 
 export namespace Chrome {
   export namespace DevTools {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     export interface EventSink<ListenerT extends(...args: any) => void> {
       addListener(listener: ListenerT): void;
       removeListener(listener: ListenerT): void;
@@ -43,7 +44,7 @@ export namespace Chrome {
             details: unknown[],
             isError: boolean,
             isException: boolean,
-            value: string
+            value: string,
           }) => unknown): void;
       getResources(callback: (resources: Resource[]) => unknown): void;
       reload(reloadOptions?: {ignoreCache?: boolean, injectedScript?: string, userAgent?: string}): void;
@@ -169,10 +170,13 @@ export namespace Chrome {
     export type RecorderExtensionPlugin = RecorderExtensionExportPlugin|RecorderExtensionReplayPlugin;
 
     export interface RecorderExtensionExportPlugin {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       stringify(recording: Record<string, any>): Promise<string>;
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       stringifyStep(step: Record<string, any>): Promise<string>;
     }
     export interface RecorderExtensionReplayPlugin {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       replay(recording: Record<string, any>): void;
     }
 
@@ -182,6 +186,7 @@ export namespace Chrome {
     export interface RemoteObject {
       type: RemoteObjectType;
       className?: string;
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       value?: any;
       description?: string;
       objectId?: RemoteObjectId;
@@ -244,9 +249,8 @@ export namespace Chrome {
        * Retrieve function name(s) for the function(s) containing the rawLocation. This returns more than one entry if
        * the location is inside of an inlined function with the innermost function at index 0.
        */
-      getFunctionInfo(rawLocation: RawLocation):
-          Promise<{frames: Array<FunctionInfo>, missingSymbolFiles: Array<string>}|{missingSymbolFiles: Array<string>}|
-                  {frames: Array<FunctionInfo>}>;
+      getFunctionInfo(rawLocation: RawLocation): Promise<{frames: FunctionInfo[], missingSymbolFiles: string[]}|
+                                                         {missingSymbolFiles: string[]}|{frames: FunctionInfo[]}>;
 
       /**
        * Find locations in raw modules corresponding to the inline function
@@ -284,9 +288,9 @@ export namespace Chrome {
       releaseObject(objectId: RemoteObjectId): Promise<void>;
     }
 
-
     export interface SupportedScriptTypes {
       language: string;
+      // eslint-disable-next-line @typescript-eslint/naming-convention
       symbol_types: string[];
     }
 

front_end/Images/rollup.config.mjs

@@ -4,7 +4,6 @@
 import {importMetaAssets} from '@web/rollup-plugin-import-meta-assets';
 import {optimize} from 'svgo';
 
-// eslint-disable-next-line import/no-default-export
 export default {
   treeshake: false,
   output: [{

front_end/models/live-metrics/web-vitals-injected/rollup.config.mjs

@@ -13,7 +13,6 @@ function isEnvVarTrue(envVar) {
   return envVar === 'true';
 }
 
-// eslint-disable-next-line import/no-default-export
 export default {
   treeshake: true,
   output: [{format: 'iife'}],

front_end/panels/recorder/injected/rollup.config.mjs

@@ -13,7 +13,6 @@ function isEnvVarTrue(envVar) {
   return envVar === 'true';
 }
 
-// eslint-disable-next-line import/no-default-export
 export default {
   treeshake: false,
   output: [{format: 'iife'}],

scripts/build/rollup.config.mjs

@@ -10,7 +10,7 @@ import sourcemaps from 'rollup-plugin-sourcemaps2';
 import { devtoolsPlugin } from './devtools_plugin.js';
 
 /** @type {function({configSourcemaps: boolean}): import("rollup").MergedRollupOptions} */
-// eslint-disable-next-line import/no-default-export
+
 export default commandLineArgs => ({
   treeshake: false,
   context: 'self',

scripts/test/run_lint_check.mjs

@@ -40,6 +40,7 @@ const flags = yargs(hideBin(process.argv))
         'scripts',
         'test',
         'extensions',
+        'extension-api',
       ],
     });
   })