Skip to content

Commit b67db54

Browse files
szuendDevtools-frontend LUCI CQ
authored andcommitted
[browser_tests] Rethrow in setupLegacyFilesForTest
This is part of a 3-way change to get rid of DOMMessageQueue in LoadLegacyFilesInFrontend [1]. "ExecJS" can await promises, so all we need is to make sure that the async function promise is rejected when the imports fail. Once this CL has landed we can remove the DOMMessageQueue and just call "ExecJS" with the default "await promise" option. The last step is to remove the try-catch alltogether in the frontend. [1]: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/devtools/devtools_browsertest.cc;l=221-231;drc=f633fa3cf093bc8b9eb3243e7b05ff0d64e4bff9 [email protected] Bug: 382003727 Change-Id: I7cee60082f285cf3fe0ea562424269da74f5b989 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6063120 Commit-Queue: Alex Rudenko <[email protected]> Auto-Submit: Simon Zünd <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
1 parent 63d550e commit b67db54

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

front_end/Tests.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@
190190
this.reportOk_();
191191
} catch (e) {
192192
this.reportFailure_(e);
193+
throw e;
193194
}
194195
};
195196

0 commit comments

Comments
 (0)