Skip to content

Commit b750d0e

Browse files
Adam RaineDevtools-frontend LUCI CQ
authored andcommitted
[RPP Observations] Prefix warning messages with warning icon
https://screenshot.googleplex.com/8zGux5ZqUS4PEVe Bug: None Change-Id: I94ccf6dfc025bdfdcaf2f40eeecc6f41c62b953d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6050443 Reviewed-by: Connor Clark <[email protected]> Auto-Submit: Adam Raine <[email protected]> Commit-Queue: Connor Clark <[email protected]>
1 parent 7641ee3 commit b750d0e

File tree

2 files changed

+47
-2
lines changed

2 files changed

+47
-2
lines changed

front_end/panels/timeline/components/liveMetricsView.css

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,20 @@
280280
.field-data-warning {
281281
margin-top: 4px;
282282
color: var(--sys-color-error);
283+
font-size: var(--sys-typescale-body4-size);
284+
line-height: var(--sys-typescale-body4-line-height);
285+
display: flex;
286+
287+
&::before {
288+
content: " ";
289+
width: var(--sys-typescale-body4-line-height);
290+
height: var(--sys-typescale-body4-line-height);
291+
mask-size: var(--sys-typescale-body4-line-height);
292+
mask-image: var(--image-file-warning);
293+
background-color: var(--sys-color-error);
294+
margin-right: 4px;
295+
flex-shrink: 0;
296+
}
283297
}
284298

285299
.collection-period-range {

front_end/panels/timeline/components/metricCard.css

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,20 @@
5959
.warning {
6060
margin-top: 4px;
6161
color: var(--sys-color-error);
62+
font-size: var(--sys-typescale-body4-size);
63+
line-height: var(--sys-typescale-body4-line-height);
64+
display: flex;
65+
66+
&::before {
67+
content: " ";
68+
width: var(--sys-typescale-body4-line-height);
69+
height: var(--sys-typescale-body4-line-height);
70+
mask-size: var(--sys-typescale-body4-line-height);
71+
mask-image: var(--image-file-warning);
72+
background-color: var(--sys-color-error);
73+
margin-right: 4px;
74+
flex-shrink: 0;
75+
}
6276
}
6377

6478
.good-bg {
@@ -90,17 +104,34 @@
90104
}
91105

92106
.environment-recs {
93-
margin: 12px 0;
107+
margin: 9px 0;
94108
}
95109

96110
.environment-recs > summary {
97111
font-weight: var(--ref-typeface-weight-medium);
98112
margin-bottom: 4px;
113+
font-size: var(--sys-typescale-body4-size);
114+
line-height: var(--sys-typescale-body4-line-height);
115+
display: flex;
116+
117+
&::before {
118+
content: " ";
119+
width: var(--sys-typescale-body4-line-height);
120+
height: var(--sys-typescale-body4-line-height);
121+
mask-size: var(--sys-typescale-body4-line-height);
122+
mask-image: var(--image-file-triangle-right);
123+
background-color: var(--icon-default);
124+
margin-right: 4px;
125+
flex-shrink: 0;
126+
}
127+
}
128+
129+
details.environment-recs[open] > summary::before {
130+
mask-image: var(--image-file-triangle-down);
99131
}
100132

101133
.environment-recs-list {
102134
margin: 0;
103-
padding-left: 20px;
104135
}
105136

106137
.detailed-compare-text {

0 commit comments

Comments
 (0)