Re-enabling DisallowedOptGroupChild-related tests

Tests related to the issue type `DisallowedOptGroupChild` started to
fail, most likely due to the enablement of InputClosesSelect by default
in crrev.com/c/chromium/src/+/6257633. Since the resource
select-element-accessibility-issue-DisallowedOptGroupChild.html used an
`<input />` to trigger the issue, this CL just changes it to a
`<button>` and re-enables both tests.

Bug: 396633671
Change-Id: Id1ed99129f99b606bd6daa20a6047dbef3cce8e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6289171
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Changhao Han <[email protected]>

Author: Ana Sollano Kim

test/e2e/host/user-metrics_test.ts

@@ -534,20 +534,17 @@ describe('User Metrics for Issue Panel', () => {
     ]);
   });
 
-  // crbug.com/396633671 failing with latest Cft roll
-  it.skip(
-      '[crbug.com/396633671] dispatches an event when a SelectElementAccessibility DisallowedOptGroupChild issue is created',
-      async () => {
-        await goToResource('issues/select-element-accessibility-issue-DisallowedOptGroupChild.html');
-        await waitFor('.issue');
-
-        await assertHistogramEventsInclude([
-          {
-            actionName: 'DevTools.IssueCreated',
-            actionCode: 87,  // SelectElementAccessibilityIssue::DisallowedOptGroupChild
-          },
-        ]);
-      });
+  it('dispatches an event when a SelectElementAccessibility DisallowedOptGroupChild issue is created', async () => {
+    await goToResource('issues/select-element-accessibility-issue-DisallowedOptGroupChild.html');
+    await waitFor('.issue');
+
+    await assertHistogramEventsInclude([
+      {
+        actionName: 'DevTools.IssueCreated',
+        actionCode: 87,  // SelectElementAccessibilityIssue::DisallowedOptGroupChild
+      },
+    ]);
+  });
 
   it('dispatches an event when a SelectElementAccessibility NonPhrasingContentOptionChild issue is created',
      async () => {

test/e2e/issues/select-element-accessibility-issues_test.ts

@@ -26,22 +26,19 @@ describe('Select element accessibility issues test', () => {
     await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
   });
 
-  // crbug.com/396633671 failing with latest Cft roll
-  it.skip(
-      '[crbug.com/396633671] should display issue when there is a disallowed child of an optgroup element',
-      async () => {
-        await goToResource('issues/select-element-accessibility-issue-DisallowedOptGroupChild.html');
-        await navigateToIssuesTab();
-        const issueElement = await getAndExpandSpecificIssueByTitle('Invalid element or text node within <optgroup>');
-        assertNotNullOrUndefined(issueElement);
+  it('should display issue when there is a disallowed child of an optgroup element', async () => {
+    await goToResource('issues/select-element-accessibility-issue-DisallowedOptGroupChild.html');
+    await navigateToIssuesTab();
+    const issueElement = await getAndExpandSpecificIssueByTitle('Invalid element or text node within <optgroup>');
+    assertNotNullOrUndefined(issueElement);
 
-        const section = await getResourcesElement('1 element', issueElement);
-        await ensureResourceSectionIsExpanded(section);
-        const expectedTableRows = [
-          ['Disallowed descendant'],
-        ];
-        await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
-      });
+    const section = await getResourcesElement('1 element', issueElement);
+    await ensureResourceSectionIsExpanded(section);
+    const expectedTableRows = [
+      ['Disallowed descendant'],
+    ];
+    await waitForTableFromResourceSectionContents(section.content, expectedTableRows);
+  });
 
   it('should display issue when there is a non-phrasing child element of an option element', async () => {
     await goToResource('issues/select-element-accessibility-issue-NonPhrasingContentOptionChild.html');

test/e2e/resources/issues/select-element-accessibility-issue-DisallowedOptGroupChild.html

@@ -11,7 +11,7 @@
     <select>
       <optgroup>
         <option>..</option>
-        <input/>
+        <button></button>
       </optgroup>
     </select>
   </body>