[cleanup] Fixes for noUnusedParameters

When enabled this places get reported. Either silence with prefixing
`_` or remove where possible.

Bug: 409278895
Change-Id: I72223f5ba2119ef05adc3c69edb4fbe33eb3a8bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6441441
Reviewed-by: Benedikt Meurer <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

extensions/cxx_debugging/e2e/TestDriver.ts

@@ -242,7 +242,7 @@ async function scrollToLine(lineNumber: number): Promise<void> {
 }
 
 async function doActions({actions, reason}: {actions?: Action[], reason: string}) {
-  const {frontend, target} = getBrowserAndPages();
+  const {target} = getBrowserAndPages();
   let continuation;
   if (actions) {
     for (const step of actions) {
@@ -258,7 +258,7 @@ async function doActions({actions, reason}: {actions?: Action[], reason: string}
           }
           await openFileInEditor(file);
           await scrollToLine(Number(breakpoint));
-          await addBreakpointForLine(frontend, breakpoint);
+          await addBreakpointForLine(breakpoint);
           break;
         }
         case 'remove_breakpoint': {
@@ -267,7 +267,7 @@ async function doActions({actions, reason}: {actions?: Action[], reason: string}
             throw new Error('Invalid breakpoint spec: missing `breakpoint`');
           }
           await scrollToLine(Number(breakpoint));
-          await removeBreakpointForLine(frontend, breakpoint);
+          await removeBreakpointForLine(breakpoint);
           break;
         }
         case 'step_over':

extensions/cxx_debugging/e2e/standalone/MemoryInspector_test.ts

@@ -33,7 +33,7 @@ describe('LinearMemoryInspector', () => {
     const file = 'scope-view-primitives.c';
     const breakpoint = 14;
     await openFileInEditor(file);
-    await addBreakpointForLine(frontend, Number(breakpoint));
+    await addBreakpointForLine(Number(breakpoint));
 
     await target.reload();
     await waitForFunction(async () => ((await getPendingEvents(frontend, 'DevTools.DebuggerPaused')) || []).length > 0);

front_end/core/common/Color.ts

@@ -512,7 +512,7 @@ export function desiredLuminance(luminance: number, contrast: number, lighter: b
  * calculated luminance of `candidateHSVA` approximates `desiredLuminance`.
  */
 export function approachColorValue(
-    candidateHSVA: Color4D, bgRGBA: Color4D, index: number, desiredLuminance: number,
+    candidateHSVA: Color4D, index: number, desiredLuminance: number,
     candidateLuminance: (arg0: Color4D) => number): number|null {
   const epsilon = 0.0002;
 
@@ -567,12 +567,12 @@ export function findFgColorForContrast(fgColor: Legacy, bgColor: Legacy, require
   const saturationComponentIndex = 1;
   const valueComponentIndex = 2;
 
-  if (approachColorValue(candidateHSVA, bgRGBA, valueComponentIndex, desired, candidateLuminance)) {
+  if (approachColorValue(candidateHSVA, valueComponentIndex, desired, candidateLuminance)) {
     return Legacy.fromHSVA(candidateHSVA);
   }
 
   candidateHSVA[valueComponentIndex] = 1;
-  if (approachColorValue(candidateHSVA, bgRGBA, saturationComponentIndex, desired, candidateLuminance)) {
+  if (approachColorValue(candidateHSVA, saturationComponentIndex, desired, candidateLuminance)) {
     return Legacy.fromHSVA(candidateHSVA);
   }
 
@@ -581,7 +581,6 @@ export function findFgColorForContrast(fgColor: Legacy, bgColor: Legacy, require
 
 export function findFgColorForContrastAPCA(fgColor: Legacy, bgColor: Legacy, requiredContrast: number): Legacy|null {
   const candidateHSVA = fgColor.as(Format.HSL).hsva();
-  const bgRGBA = bgColor.rgba();
 
   const candidateLuminance = (candidateHSVA: Color4D): number => {
     return luminanceAPCA(Legacy.fromHSVA(candidateHSVA).rgba());
@@ -595,15 +594,15 @@ export function findFgColorForContrastAPCA(fgColor: Legacy, bgColor: Legacy, req
   const saturationComponentIndex = 1;
   const valueComponentIndex = 2;
 
-  if (approachColorValue(candidateHSVA, bgRGBA, valueComponentIndex, desiredLuminance, candidateLuminance)) {
+  if (approachColorValue(candidateHSVA, valueComponentIndex, desiredLuminance, candidateLuminance)) {
     const candidate = Legacy.fromHSVA(candidateHSVA);
     if (Math.abs(contrastRatioAPCA(bgColor.rgba(), candidate.rgba())) >= requiredContrast) {
       return candidate;
     }
   }
 
   candidateHSVA[valueComponentIndex] = 1;
-  if (approachColorValue(candidateHSVA, bgRGBA, saturationComponentIndex, desiredLuminance, candidateLuminance)) {
+  if (approachColorValue(candidateHSVA, saturationComponentIndex, desiredLuminance, candidateLuminance)) {
     const candidate = Legacy.fromHSVA(candidateHSVA);
     if (Math.abs(contrastRatioAPCA(bgColor.rgba(), candidate.rgba())) >= requiredContrast) {
       return candidate;

front_end/core/common/Settings.ts

@@ -519,7 +519,7 @@ export class Setting<V> {
       try {
         this.storage.set(this.name, settingString);
       } catch (e) {
-        this.printSettingsSavingError(e.message, this.name, settingString);
+        this.printSettingsSavingError(e.message, settingString);
       }
     } catch (e) {
       Console.instance().error('Cannot stringify setting with name: ' + this.name + ', error: ' + e.message);
@@ -606,7 +606,7 @@ export class Setting<V> {
     return this.#deprecation;
   }
 
-  private printSettingsSavingError(message: string, name: string, value: string): void {
+  private printSettingsSavingError(message: string, value: string): void {
     const errorMessage =
         'Error saving setting with name: ' + this.name + ', value length: ' + value.length + '. Error: ' + message;
     console.error(errorMessage);

front_end/core/host/InspectorFrontendHost.ts

@@ -145,22 +145,22 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   closeWindow(): void {
   }
 
-  setIsDocked(isDocked: boolean, callback: () => void): void {
+  setIsDocked(_isDocked: boolean, callback: () => void): void {
     window.setTimeout(callback, 0);
   }
 
-  showSurvey(trigger: string, callback: (arg0: ShowSurveyResult) => void): void {
+  showSurvey(_trigger: string, callback: (arg0: ShowSurveyResult) => void): void {
     window.setTimeout(() => callback({surveyShown: false}), 0);
   }
 
-  canShowSurvey(trigger: string, callback: (arg0: CanShowSurveyResult) => void): void {
+  canShowSurvey(_trigger: string, callback: (arg0: CanShowSurveyResult) => void): void {
     window.setTimeout(() => callback({canShowSurvey: false}), 0);
   }
 
   /**
    * Requests inspected page to be placed atop of the inspector frontend with specified bounds.
    */
-  setInspectedPageBounds(bounds: {
+  setInspectedPageBounds(_bounds: {
     x: number,
     y: number,
     width: number,
@@ -171,7 +171,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   inspectElementCompleted(): void {
   }
 
-  setInjectedScriptForOrigin(origin: string, script: string): void {
+  setInjectedScriptForOrigin(_origin: string, _script: string): void {
   }
 
   inspectedURLChanged(url: Platform.DevToolsPath.UrlString): void {
@@ -192,19 +192,19 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     window.open(url, '_blank');
   }
 
-  openSearchResultsInNewTab(query: string): void {
+  openSearchResultsInNewTab(_query: string): void {
     Common.Console.Console.instance().error(
         'Search is not enabled in hosted mode. Please inspect using chrome://inspect');
   }
 
-  showItemInFolder(fileSystemPath: Platform.DevToolsPath.RawPathString): void {
+  showItemInFolder(_fileSystemPath: Platform.DevToolsPath.RawPathString): void {
     Common.Console.Console.instance().error(
         'Show item in folder is not enabled in hosted mode. Please inspect using chrome://inspect');
   }
 
   save(
-      url: Platform.DevToolsPath.RawPathString|Platform.DevToolsPath.UrlString, content: string, forceSaveAs: boolean,
-      isBase64: boolean): void {
+      url: Platform.DevToolsPath.RawPathString|Platform.DevToolsPath.UrlString, content: string, _forceSaveAs: boolean,
+      _isBase64: boolean): void {
     let buffer = this.#urlsBeingSaved.get(url);
     if (!buffer) {
       buffer = [];
@@ -246,7 +246,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     URL.revokeObjectURL(blobUrl);
   }
 
-  sendMessageToBackend(message: string): void {
+  sendMessageToBackend(_message: string): void {
   }
 
   recordCountHistogram(histogramName: string, sample: number, min: number, exclusiveMax: number, bucketSize: number):
@@ -257,7 +257,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     this.recordedCountHistograms.push({histogramName, sample, min, exclusiveMax, bucketSize});
   }
 
-  recordEnumeratedHistogram(actionName: EnumeratedHistogram, actionCode: number, bucketSize: number): void {
+  recordEnumeratedHistogram(actionName: EnumeratedHistogram, actionCode: number, _bucketSize: number): void {
     if (this.recordedEnumeratedHistograms.length >= MAX_RECORDED_HISTOGRAMS_SIZE) {
       this.recordedEnumeratedHistograms.shift();
     }
@@ -271,7 +271,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     this.recordedPerformanceHistograms.push({histogramName, duration});
   }
 
-  recordUserMetricsAction(umaName: string): void {
+  recordUserMetricsAction(_umaName: string): void {
   }
 
   connectAutomaticFileSystem(
@@ -283,14 +283,14 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     queueMicrotask(() => callback({success: false}));
   }
 
-  disconnectAutomaticFileSystem(fileSystemPath: Platform.DevToolsPath.RawPathString): void {
+  disconnectAutomaticFileSystem(_fileSystemPath: Platform.DevToolsPath.RawPathString): void {
   }
 
   requestFileSystems(): void {
     this.events.dispatchEventToListeners(Events.FileSystemsLoaded, []);
   }
 
-  addFileSystem(type?: string): void {
+  addFileSystem(_type?: string): void {
     const onFileSystem = (fs: FileSystem): void => {
       this.#fileSystem = fs;
       const fileSystem = {
@@ -304,7 +304,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     window.webkitRequestFileSystem(window.TEMPORARY, 1024 * 1024, onFileSystem);
   }
 
-  removeFileSystem(fileSystemPath: Platform.DevToolsPath.RawPathString): void {
+  removeFileSystem(_fileSystemPath: Platform.DevToolsPath.RawPathString): void {
     const removalCallback = (entries: Entry[]): void => {
       entries.forEach(entry => {
         if (entry.isDirectory) {
@@ -323,12 +323,12 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     this.events.dispatchEventToListeners(Events.FileSystemRemoved, OVERRIDES_FILE_SYSTEM_PATH);
   }
 
-  isolatedFileSystem(fileSystemId: string, registeredName: string): FileSystem|null {
+  isolatedFileSystem(_fileSystemId: string, _registeredName: string): FileSystem|null {
     return this.#fileSystem;
   }
 
   loadNetworkResource(
-      url: string, headers: string, streamId: number, callback: (arg0: LoadNetworkResourceResult) => void): void {
+      url: string, _headers: string, streamId: number, callback: (arg0: LoadNetworkResourceResult) => void): void {
     // Read the first 3 bytes looking for the gzip signature in the file header
     function isGzip(ab: ArrayBuffer): boolean {
       const buf = new Uint8Array(ab);
@@ -376,7 +376,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
         });
   }
 
-  registerPreference(name: string, options: {synced?: boolean}): void {
+  registerPreference(_name: string, _options: {synced?: boolean}): void {
   }
 
   getPreferences(callback: (arg0: {
@@ -452,16 +452,16 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     callback(hostConfigForHostedMode);
   }
 
-  upgradeDraggedFileSystemPermissions(fileSystem: FileSystem): void {
+  upgradeDraggedFileSystemPermissions(_fileSystem: FileSystem): void {
   }
 
-  indexPath(requestId: number, fileSystemPath: Platform.DevToolsPath.RawPathString, excludedFolders: string): void {
+  indexPath(_requestId: number, _fileSystemPath: Platform.DevToolsPath.RawPathString, _excludedFolders: string): void {
   }
 
-  stopIndexing(requestId: number): void {
+  stopIndexing(_requestId: number): void {
   }
 
-  searchInPath(requestId: number, fileSystemPath: Platform.DevToolsPath.RawPathString, query: string): void {
+  searchInPath(_requestId: number, _fileSystemPath: Platform.DevToolsPath.RawPathString, _query: string): void {
   }
 
   zoomFactor(): number {
@@ -477,16 +477,16 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   resetZoom(): void {
   }
 
-  setWhitelistedShortcuts(shortcuts: string): void {
+  setWhitelistedShortcuts(_shortcuts: string): void {
   }
 
-  setEyeDropperActive(active: boolean): void {
+  setEyeDropperActive(_active: boolean): void {
   }
 
-  showCertificateViewer(certChain: string[]): void {
+  showCertificateViewer(_certChain: string[]): void {
   }
 
-  reattach(callback: () => void): void {
+  reattach(_callback: () => void): void {
   }
 
   readyForTest(): void {
@@ -495,64 +495,64 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   connectionReady(): void {
   }
 
-  setOpenNewWindowForPopups(value: boolean): void {
+  setOpenNewWindowForPopups(_value: boolean): void {
   }
 
-  setDevicesDiscoveryConfig(config: Adb.Config): void {
+  setDevicesDiscoveryConfig(_config: Adb.Config): void {
   }
 
-  setDevicesUpdatesEnabled(enabled: boolean): void {
+  setDevicesUpdatesEnabled(_enabled: boolean): void {
   }
 
-  openRemotePage(browserId: string, url: string): void {
+  openRemotePage(_browserId: string, _url: string): void {
   }
 
   openNodeFrontend(): void {
   }
 
-  showContextMenuAtPoint(x: number, y: number, items: ContextMenuDescriptor[], document: Document): void {
+  showContextMenuAtPoint(_x: number, _y: number, _items: ContextMenuDescriptor[], _document: Document): void {
     throw new Error('Soft context menu should be used');
   }
 
   isHostedMode(): boolean {
     return true;
   }
 
-  setAddExtensionCallback(callback: (arg0: ExtensionDescriptor) => void): void {
+  setAddExtensionCallback(_callback: (arg0: ExtensionDescriptor) => void): void {
     // Extensions are not supported in hosted mode.
   }
 
   async initialTargetId(): Promise<string|null> {
     return null;
   }
 
-  doAidaConversation(request: string, streamId: number, callback: (result: DoAidaConversationResult) => void): void {
+  doAidaConversation(_request: string, _streamId: number, callback: (result: DoAidaConversationResult) => void): void {
     callback({
       error: 'Not implemented',
     });
   }
 
-  registerAidaClientEvent(request: string, callback: (result: AidaClientResult) => void): void {
+  registerAidaClientEvent(_request: string, callback: (result: AidaClientResult) => void): void {
     callback({
       error: 'Not implemented',
     });
   }
 
-  recordImpression(event: ImpressionEvent): void {
+  recordImpression(_event: ImpressionEvent): void {
   }
-  recordResize(event: ResizeEvent): void {
+  recordResize(_event: ResizeEvent): void {
   }
-  recordClick(event: ClickEvent): void {
+  recordClick(_event: ClickEvent): void {
   }
-  recordHover(event: HoverEvent): void {
+  recordHover(_event: HoverEvent): void {
   }
-  recordDrag(event: DragEvent): void {
+  recordDrag(_event: DragEvent): void {
   }
-  recordChange(event: ChangeEvent): void {
+  recordChange(_event: ChangeEvent): void {
   }
-  recordKeyDown(event: KeyDownEvent): void {
+  recordKeyDown(_event: KeyDownEvent): void {
   }
-  recordSettingAccess(event: SettingAccessEvent): void {
+  recordSettingAccess(_event: SettingAccessEvent): void {
   }
 }
 
@@ -568,7 +568,7 @@ class InspectorFrontendAPIImpl {
     }
   }
 
-  private dispatch(name: symbol, signature: string[], runOnceLoaded: boolean, ...params: string[]): void {
+  private dispatch(name: symbol, signature: string[], _runOnceLoaded: boolean, ...params: string[]): void {
     // Single argument methods get dispatched with the param.
     if (signature.length < 2) {
       try {

front_end/core/platform/TypescriptUtilities.ts

@@ -13,7 +13,7 @@ export function assertNotNullOrUndefined<T>(val: T, message?: string): asserts v
   }
 }
 
-export function assertNever(type: never, message: string): never {
+export function assertNever(_type: never, message: string): never {
   throw new Error(message);
 }
 

front_end/core/sdk/CSSMatchedStyles.ts

@@ -123,9 +123,9 @@ function cleanUserAgentPayload(payload: Protocol.CSS.RuleMatch[]): Protocol.CSS.
     if (rule.origin !== 'user-agent' || !matchingSelectors.length) {
       return;
     }
-    rule.selectorList.selectors = rule.selectorList.selectors.filter((item, i) => matchingSelectors.includes(i));
+    rule.selectorList.selectors = rule.selectorList.selectors.filter((_, i) => matchingSelectors.includes(i));
     rule.selectorList.text = rule.selectorList.selectors.map(item => item.text).join(', ');
-    ruleMatch.matchingSelectors = matchingSelectors.map((item, i) => i);
+    ruleMatch.matchingSelectors = matchingSelectors.map((_, i) => i);
   }
 }