Skip to content

Commit b98124f

Browse files
Robert LinDevtools-frontend LUCI CQ
authored andcommitted
preload: Add error message for Prerenders closed via window.close()
Bug: 374064165 Change-Id: I6725cc57178c8cc62527751fdf59a39014e74f09 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5942301 Reviewed-by: Danil Somsikov <[email protected]> Commit-Queue: Huanpo Lin <[email protected]>
1 parent 5cfe4e7 commit b98124f

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

front_end/panels/application/preloading/components/PreloadingString.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,10 @@ const UIStrings = {
373373
*/
374374
prerenderFinalStatusAllPrerenderingCanceled:
375375
'All prerendered pages were unloaded by the browser for some reason (For example, WebViewCompat.addWebMessageListener() was called during prerendering.)',
376+
/**
377+
* Description text for PrenderFinalStatus::kWindowClosed.
378+
*/
379+
prerenderFinalStatusWindowClosed: 'The prerendered page was unloaded because it called window.close().',
376380

377381
/**
378382
*@description Text in grid and details: Preloading attempt is not yet triggered.
@@ -680,6 +684,7 @@ export function prerenderFailureReason(attempt: SDK.PreloadingModel.PrerenderAtt
680684
case Protocol.Preload.PrerenderFinalStatus.AllPrerenderingCanceled:
681685
return i18nString(UIStrings.prerenderFinalStatusAllPrerenderingCanceled);
682686
case Protocol.Preload.PrerenderFinalStatus.WindowClosed:
687+
return i18nString(UIStrings.prerenderFinalStatusWindowClosed);
683688
case Protocol.Preload.PrerenderFinalStatus.SlowNetwork:
684689
case Protocol.Preload.PrerenderFinalStatus.OtherPrerenderedPageActivated:
685690
case Protocol.Preload.PrerenderFinalStatus.V8OptimizerDisabled:

0 commit comments

Comments
 (0)